All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] libs/devicemodel: fix test for DM_OP availability
Date: Mon, 4 Jan 2021 18:33:35 +0100	[thread overview]
Message-ID: <20210104173335.h3kojpev4hol3xxp@Air-de-Roger> (raw)
In-Reply-To: <20210104141202.71724-1-roger.pau@citrix.com>

On Mon, Jan 04, 2021 at 03:12:02PM +0100, Roger Pau Monne wrote:
> Current check for DM_OP availability in osdep_xendevicemodel_open will
> always fail, because using DOMID_INVALID as the domain parameter will
> make the hypervisor return -ESRCH, which will disable the usage of
> the DOM_OP interface.
> 
> Fix this by checking the errno code of the test ioctl against
> the privcmd unimplemented errno.

Forget about this patch, it's my fault for not realizing Linux privcmd
checks that the num is != 0 before issuing the hypercall.

Sorry for the noise.

Roger.


      reply	other threads:[~2021-01-04 17:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 14:12 [PATCH] libs/devicemodel: fix test for DM_OP availability Roger Pau Monne
2021-01-04 17:33 ` Roger Pau Monné [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210104173335.h3kojpev4hol3xxp@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.