From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BCA7C433E0 for ; Mon, 4 Jan 2021 20:41:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4634D22273 for ; Mon, 4 Jan 2021 20:41:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727910AbhADUlG (ORCPT ); Mon, 4 Jan 2021 15:41:06 -0500 Received: from vulcan.natalenko.name ([104.207.131.136]:49628 "EHLO vulcan.natalenko.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbhADUlG (ORCPT ); Mon, 4 Jan 2021 15:41:06 -0500 Received: from localhost (home.natalenko.name [151.237.229.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vulcan.natalenko.name (Postfix) with ESMTPSA id A35E19171B5; Mon, 4 Jan 2021 21:40:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name; s=dkim-20170712; t=1609792823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m3kO4/0YnkBsr3+eyXx74q8og9elDAs3U+DeFXahA8A=; b=FiJIQEVMIEGPLRLwuTGiz0LgbHiNrwZda/w+m5WNew9UE/smj6ZbT7folHdXgHqguQydum pChH4fK/2zTYv6kdpT/RPyhrCv0lEV4MJbh5/hSOuQwAd6HpUd2nQEspDu24KX3iNtRvXo pxRLyacsJLJ6upCC2Nx0AVbC43LhTLA= Date: Mon, 4 Jan 2021 21:40:23 +0100 From: Oleksandr Natalenko To: Andre Tomt Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Harry Wentland , Alex Deucher , Nicholas Kazlauskas , Stylon Wang Subject: Re: [PATCH 5.10 637/717] drm/amd/display: Fix memory leaks in S3 resume Message-ID: <20210104204023.nloe547uwfxgjnl4@spock.localdomain> References: <20201228125020.963311703@linuxfoundation.org> <20201228125051.444911072@linuxfoundation.org> <20210104201016.bncnhyq25zz2y76h@spock.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210104201016.bncnhyq25zz2y76h@spock.localdomain> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2021 at 09:10:17PM +0100, Oleksandr Natalenko wrote: > On Mon, Jan 04, 2021 at 08:04:08PM +0100, Andre Tomt wrote: > > On 28.12.2020 13:50, Greg Kroah-Hartman wrote: > > > From: Stylon Wang > > > > > > commit a135a1b4c4db1f3b8cbed9676a40ede39feb3362 upstream. > > > > > > EDID parsing in S3 resume pushes new display modes > > > to probed_modes list but doesn't consolidate to actual > > > mode list. This creates a race condition when > > > amdgpu_dm_connector_ddc_get_modes() re-initializes the > > > list head without walking the list and results in memory leak. > > > > This commit is causing me problems on 5.10.4: when I turn off the display (a > > LG TV in this case), and turn it back on again later there is no video > > output and I get the following in the kernel log: > > > > [ 8245.259628] [drm:dm_restore_drm_connector_state [amdgpu]] *ERROR* > > Restoring old state failed with -12 > > Uh, it seems you've just saved me a ton of gray hair. I have the very > same issue and I'm going to revert this patch now in order to check > whether it makes any difference. Confirmed, reverting this patch makes my monitor light back after turning off/on. Also, during testing, I've noticed that with the stock v5.10.4 kernel once reboot sequence is initiated and xorg gets killed, the monitor also lights back and shows the console. My HW: 0a:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Lexa PRO [Radeon 540/540X/550/550X / RX 540X/550/550X] (rev c7) > > Thanks! > > > > > I've found another report on this commit as well: > > https://bugzilla.kernel.org/show_bug.cgi?id=211033 > > > > And I suspect this is the same: > > https://bugs.archlinux.org/task/69202 > > > > Reverting it from 5.10.4 makes things behave again. > > > > Have not tested 5.4.86 or 5.11-rc. > > > > I'm using a RX570 Polaris based card. -- Oleksandr Natalenko (post-factum)