All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/wqy-zenhei: new package
Date: Mon, 4 Jan 2021 21:18:27 +0100	[thread overview]
Message-ID: <20210104211827.762fa2b8@windsurf.home> (raw)
In-Reply-To: <12678409-b5dc-71fa-f0d1-9caf625f75c5@linux.vnet.ibm.com>

Hello Klaus,

On Mon, 4 Jan 2021 16:42:39 -0300
Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com> wrote:

> > Indeed for consistency reason, we try to only use the lower-case
> > package name as the short prompt for packags.  
> 
> I was puzzled by this comment so I looked at the commit and I think you
> meant to say that you removed the "(Free Chinese-capable fonts)" from the bool.
> That makes sense, thanks!

Gah, absolutely. I made a bogus copy/paste which made my whole
explanation confusing indeed, but it seems you understood what I meant
anyway :-)

> > Indicating the URL from which the tarball is downloaded and then the
> > hash calculated locally is not very useful. Also, SourceForge provides
> > md5 and sha1 hashes, and the hash of the license file was missing. So,
> > I've changed to:  
> 
> I understand the md5 and sha1 hashes that I completely missed, but couldn't decode why the locally computed/calculated
> sha256 is not useful.

The locally computed sha256 is useful. What was not is the comment:

# locally calculated from http://.....tar.gz

because it's obvious from where it has been calculated, so we tend to say just:

# locally calculated

or, if indeed there was another verification method:

# locally calculated, after checking the signature with ...

Does that make sense? But really, this is very tiny minor detail.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2021-01-04 20:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 14:17 [Buildroot] [PATCH 1/1] package/wqy-zenhei: new package Klaus Heinrich Kiwi
2021-01-02 17:42 ` Thomas Petazzoni
2021-01-04 19:42   ` Klaus Heinrich Kiwi
2021-01-04 20:18     ` Thomas Petazzoni [this message]
2021-01-05  1:28       ` Klaus Heinrich Kiwi
  -- strict thread matches above, loose matches on Subject: below --
2020-11-09 17:41 Klaus Heinrich Kiwi
2020-11-13 12:08 ` Klaus Heinrich Kiwi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210104211827.762fa2b8@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.