From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9DC4C433E0 for ; Mon, 4 Jan 2021 21:26:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 703E921919 for ; Mon, 4 Jan 2021 21:26:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbhADVZ5 (ORCPT ); Mon, 4 Jan 2021 16:25:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:39598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbhADVZ5 (ORCPT ); Mon, 4 Jan 2021 16:25:57 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F0401216C4; Mon, 4 Jan 2021 21:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609795516; bh=ENuN3yW4AW1o6Z39AIixJU3HWpYwrvRogBcKSXsjZPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IDb5rwA/zMWUNyO+pboCFAAgX12vqdTkFlumCsmAim1FSponJel41VPzIXa/pK4qs eNVFlZjx344b3sPtocDH5AOxyah5I0VS01awbekP+/VB52yzjraMLcDQU7wBFWTrlV 8aZEJPUwsXeN8+Qc6HKZfP0gIkA58Q/tUBI2FwzeXp+dEB41iVjx28QGgwZamJVyNI zXqmzaP0rNOKaK0e42V3MgCR+kzV1gOlr4m/q321iXqgcF56IYLpTZWMJXfwrezhiT 1mDDlfzfVbGkg3qxr1VfNIlQXcnAOmJV0rMWBu5BJ4wXO74mI18LOuit/7/35rodZY fQ/PfBzUCum1w== Date: Mon, 4 Jan 2021 21:24:49 +0000 From: Mark Brown To: Krzysztof Kozlowski Cc: Timon Baetz , Marek Szyprowski , Liam Girdwood , Rob Herring , MyungJoo Ham , Chanwoo Choi , Lee Jones , Sebastian Reichel , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Message-ID: <20210104212449.GJ5645@sirena.org.uk> References: <20201230205139.1812366-1-timon.baetz@protonmail.com> <20201230205139.1812366-2-timon.baetz@protonmail.com> <20210104135156.GB5645@sirena.org.uk> <20210104181825.GB27043@kozik-lap> <20210104182734.GH5645@sirena.org.uk> <20210104183821.GA29033@kozik-lap> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/qIPZgKzMPM+y5U5" Content-Disposition: inline In-Reply-To: <20210104183821.GA29033@kozik-lap> X-Cookie: Stupidity is its own reward. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/qIPZgKzMPM+y5U5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 04, 2021 at 07:38:21PM +0100, Krzysztof Kozlowski wrote: > On Mon, Jan 04, 2021 at 06:27:34PM +0000, Mark Brown wrote: > > We can indicate the presence of features without adding new compatible > > strings, that's just encoding the way Linux currently divides things up > > into the bindings. For example having an extcon property seems like it > > should be enough to figure out if we're using extcon. > It won't be enough because MFD will create device for extcon and bind > the driver. The same for the charger. We have a board where max8997 is > used only as PMIC (providing regulators) without battery and USB > connectivity. I'm not sure I follow, sorry? Either the core driver can parse the bindings enough to know what children it has or (probably better) it can instantiate the children unconditionally and then the function drivers can figure out if they need to do anything. > Another point, is that this reflects the real hardware. The same as we > model entire SoC as multiple children of soc node (with their own > properties), here we represent smaller chip which also has > sub-components. Components we're calling things like "extcon"... --/qIPZgKzMPM+y5U5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/zh6AACgkQJNaLcl1U h9D85Qf9HAkIDxqmUT3DuU1gC8iLvHOzcvGAFb/R2kAgDBX9QGM4PIo36fI1p7o2 xwEdAv60V7yNTtP6gpTMfRj+IAl+URIZys7CzALyL77mH7uCc1EZOJgMHEN8FMif jngEiDVMzp816XxUJHO9SX9n4vTnWr/9D3j/qD/LdkA2wx98SqyOfUhCs4csGqns QUkI2r52B5op3cpVNlxlqcaWBF8b+4dMSNhGoSTw7ZnDCjz3ZVrNalGcQ5DOIi2q HbFlJkSA7jHdnrXf6HGfa3hAGRDNaQAg935Zzvc+PV8Sz5kaqxOYa1SoYASV1NZ4 nwhwhH1ADHFKfU9mTF33rkqAKR8QYQ== =Xd45 -----END PGP SIGNATURE----- --/qIPZgKzMPM+y5U5-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB19C433DB for ; Mon, 4 Jan 2021 21:27:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD3E9216C4 for ; Mon, 4 Jan 2021 21:27:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD3E9216C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OrLb4NXCjTV/DAxcaDxihz9uYMseUy9qJ4JHWXSlOLA=; b=uQw9lvHSET3UYlrCxlU5HvAK6 HpsB1zS/AIwDvJaP4DLoZUL7UImnNkiV/JltYxpDuTixxBmR/fPKMl5c5u4hXD3+VlVu2XCUAi03p 8GkinJZ2URXSvjZcWx+S5Wy3zGCPv6qEl1WXRsTLGUQdFTSJB7IaGEmKC2MKnmXTQUrvPDEMscu9v 2v1KXkRD2JyPvyXf8THjwOjCg2Tar1i2oClMHkeXFMI8xf0GIC6pMANj8VWSEBxz46eLvQC97zfg+ PKJXaH4aBcIi2w8iP2SE/r9+Y1rQVc7fruKKqUKJbG2zjjbxPrWMiGe9nZQX+7VOSBRG48E1OYHj8 Di6zckbAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwXLs-00041v-PK; Mon, 04 Jan 2021 21:25:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwXLp-0003zk-JO for linux-arm-kernel@lists.infradead.org; Mon, 04 Jan 2021 21:25:18 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id F0401216C4; Mon, 4 Jan 2021 21:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609795516; bh=ENuN3yW4AW1o6Z39AIixJU3HWpYwrvRogBcKSXsjZPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IDb5rwA/zMWUNyO+pboCFAAgX12vqdTkFlumCsmAim1FSponJel41VPzIXa/pK4qs eNVFlZjx344b3sPtocDH5AOxyah5I0VS01awbekP+/VB52yzjraMLcDQU7wBFWTrlV 8aZEJPUwsXeN8+Qc6HKZfP0gIkA58Q/tUBI2FwzeXp+dEB41iVjx28QGgwZamJVyNI zXqmzaP0rNOKaK0e42V3MgCR+kzV1gOlr4m/q321iXqgcF56IYLpTZWMJXfwrezhiT 1mDDlfzfVbGkg3qxr1VfNIlQXcnAOmJV0rMWBu5BJ4wXO74mI18LOuit/7/35rodZY fQ/PfBzUCum1w== Date: Mon, 4 Jan 2021 21:24:49 +0000 From: Mark Brown To: Krzysztof Kozlowski Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Message-ID: <20210104212449.GJ5645@sirena.org.uk> References: <20201230205139.1812366-1-timon.baetz@protonmail.com> <20201230205139.1812366-2-timon.baetz@protonmail.com> <20210104135156.GB5645@sirena.org.uk> <20210104181825.GB27043@kozik-lap> <20210104182734.GH5645@sirena.org.uk> <20210104183821.GA29033@kozik-lap> MIME-Version: 1.0 In-Reply-To: <20210104183821.GA29033@kozik-lap> X-Cookie: Stupidity is its own reward. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210104_162517_795951_9FB42654 X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Rob Herring , Timon Baetz , Chanwoo Choi , MyungJoo Ham , ~postmarketos/upstreaming@lists.sr.ht, Sebastian Reichel , Lee Jones , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: multipart/mixed; boundary="===============5887204513714962343==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5887204513714962343== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/qIPZgKzMPM+y5U5" Content-Disposition: inline --/qIPZgKzMPM+y5U5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 04, 2021 at 07:38:21PM +0100, Krzysztof Kozlowski wrote: > On Mon, Jan 04, 2021 at 06:27:34PM +0000, Mark Brown wrote: > > We can indicate the presence of features without adding new compatible > > strings, that's just encoding the way Linux currently divides things up > > into the bindings. For example having an extcon property seems like it > > should be enough to figure out if we're using extcon. > It won't be enough because MFD will create device for extcon and bind > the driver. The same for the charger. We have a board where max8997 is > used only as PMIC (providing regulators) without battery and USB > connectivity. I'm not sure I follow, sorry? Either the core driver can parse the bindings enough to know what children it has or (probably better) it can instantiate the children unconditionally and then the function drivers can figure out if they need to do anything. > Another point, is that this reflects the real hardware. The same as we > model entire SoC as multiple children of soc node (with their own > properties), here we represent smaller chip which also has > sub-components. Components we're calling things like "extcon"... --/qIPZgKzMPM+y5U5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/zh6AACgkQJNaLcl1U h9D85Qf9HAkIDxqmUT3DuU1gC8iLvHOzcvGAFb/R2kAgDBX9QGM4PIo36fI1p7o2 xwEdAv60V7yNTtP6gpTMfRj+IAl+URIZys7CzALyL77mH7uCc1EZOJgMHEN8FMif jngEiDVMzp816XxUJHO9SX9n4vTnWr/9D3j/qD/LdkA2wx98SqyOfUhCs4csGqns QUkI2r52B5op3cpVNlxlqcaWBF8b+4dMSNhGoSTw7ZnDCjz3ZVrNalGcQ5DOIi2q HbFlJkSA7jHdnrXf6HGfa3hAGRDNaQAg935Zzvc+PV8Sz5kaqxOYa1SoYASV1NZ4 nwhwhH1ADHFKfU9mTF33rkqAKR8QYQ== =Xd45 -----END PGP SIGNATURE----- --/qIPZgKzMPM+y5U5-- --===============5887204513714962343== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5887204513714962343==--