From: akpm@linux-foundation.org
To: arnd@arndb.de, elver@google.com, georgepope@android.com,
keescook@chromium.org, mm-commits@vger.kernel.org,
natechancellor@gmail.com, ndesaulniers@google.com,
sfr@canb.auug.org.au
Subject: + ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang.patch added to -mm tree
Date: Mon, 04 Jan 2021 15:33:49 -0800 [thread overview]
Message-ID: <20210104233349.rTI26tb9N%akpm@linux-foundation.org> (raw)
The patch titled
Subject: ubsan: disable unsigned-integer-overflow sanitizer with clang
has been added to the -mm tree. Its filename is
ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Arnd Bergmann <arnd@arndb.de>
Subject: ubsan: disable unsigned-integer-overflow sanitizer with clang
Building ubsan kernels even for compile-testing introduced these warnings
in my randconfig environment:
crypto/blake2b_generic.c:98:13: error: stack frame size of 9636 bytes in function 'blake2b_compress' [-Werror,-Wframe-larger-than=]
static void blake2b_compress(struct blake2b_state *S,
crypto/sha512_generic.c:151:13: error: stack frame size of 1292 bytes in function 'sha512_generic_block_fn' [-Werror,-Wframe-larger-than=]
static void sha512_generic_block_fn(struct sha512_state *sst, u8 const *src,
lib/crypto/curve25519-fiat32.c:312:22: error: stack frame size of 2180 bytes in function 'fe_mul_impl' [-Werror,-Wframe-larger-than=]
static noinline void fe_mul_impl(u32 out[10], const u32 in1[10], const u32 in2[10])
lib/crypto/curve25519-fiat32.c:444:22: error: stack frame size of 1588 bytes in function 'fe_sqr_impl' [-Werror,-Wframe-larger-than=]
static noinline void fe_sqr_impl(u32 out[10], const u32 in1[10])
Further testing showed that this is caused by
-fsanitize=unsigned-integer-overflow.
The one in blake2b immediately overflows the 8KB stack area on 32-bit
architectures, so better ensure this never happens by making this option
gcc-only.
Link: https://lkml.kernel.org/r/20201230154749.746641-1-arnd@kernel.org
Fixes: d0a3ac549f38 ("ubsan: enable for all*config builds")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Marco Elver <elver@google.com>
Cc: George Popescu <georgepope@android.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/Kconfig.ubsan | 2 ++
1 file changed, 2 insertions(+)
--- a/lib/Kconfig.ubsan~ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang
+++ a/lib/Kconfig.ubsan
@@ -122,6 +122,8 @@ config UBSAN_SIGNED_OVERFLOW
config UBSAN_UNSIGNED_OVERFLOW
bool "Perform checking for unsigned arithmetic overflow"
+ # clang hugely expands stack usage with -fsanitize=object-size
+ depends on !CC_IS_CLANG
depends on $(cc-option,-fsanitize=unsigned-integer-overflow)
help
This option enables -fsanitize=unsigned-integer-overflow which checks
_
Patches currently in -mm which might be from arnd@arndb.de are
ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang.patch
reply other threads:[~2021-01-04 23:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104233349.rTI26tb9N%akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=elver@google.com \
--cc=georgepope@android.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.