From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D1B7C433DB for ; Tue, 5 Jan 2021 00:37:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F52022286 for ; Tue, 5 Jan 2021 00:37:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F52022286 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwaLl-0000Hq-ND for qemu-devel@archiver.kernel.org; Mon, 04 Jan 2021 19:37:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwaKD-0007uZ-PY for qemu-devel@nongnu.org; Mon, 04 Jan 2021 19:35:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42616) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kwaK8-0001QI-HC for qemu-devel@nongnu.org; Mon, 04 Jan 2021 19:35:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609806943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cWQrimwdkNaUp+SUZ6Nf/XT7lGtx3h5RrfGgVyY++Cc=; b=AFyJc/W8WTkqnIIrZI+g7b2+JlfzZ0vRD0XoYouqawCuEl8uVCyi0MPwMGuT5yqIvGBlqr ZiPtVu4f/AEqaeQP+AITQlDEdUU3EDeEuGDtTueo6Nu1tG2gzw2+o/WE59GtW5IAs5c4cF Ee18y/s1yFy6NGax2bBHtmdTh/xkbuw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-261-bw7bDEiPOPe1CvKjH9qMPQ-1; Mon, 04 Jan 2021 19:35:41 -0500 X-MC-Unique: bw7bDEiPOPe1CvKjH9qMPQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0EDE9800D62; Tue, 5 Jan 2021 00:35:40 +0000 (UTC) Received: from localhost (unknown [10.40.208.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF53360C15; Tue, 5 Jan 2021 00:35:31 +0000 (UTC) Date: Tue, 5 Jan 2021 01:35:29 +0100 From: Igor Mammedov To: "Michael S. Tsirkin" Subject: Re: [PATCH v3 3/8] acpi/gpex: Inform os to keep firmware resource map Message-ID: <20210105013529.4addf44f@redhat.com> In-Reply-To: <20201230161942-mutt-send-email-mst@kernel.org> References: <20201223090836.9075-1-cenjiahui@huawei.com> <20201223090836.9075-4-cenjiahui@huawei.com> <20201229144142.66583852@redhat.com> <20201230161942-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.243, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xieyingtai@huawei.com, Jiahui Cen , Eduardo Habkost , Richard Henderson , qemu-devel@nongnu.org, Ard Biesheuvel , Paolo Bonzini , Laszlo Ersek , wu.wubin@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 30 Dec 2020 16:22:08 -0500 "Michael S. Tsirkin" wrote: > On Tue, Dec 29, 2020 at 02:41:42PM +0100, Igor Mammedov wrote: > > On Wed, 23 Dec 2020 17:08:31 +0800 > > Jiahui Cen wrote: > > > > > There may be some differences in pci resource assignment between guest os > > > and firmware. > > > > > > Eg. A Bridge with Bus [d2] > > > -+-[0000:d2]---01.0-[d3]----01.0 > > > > > > where [d2:01.00] is a pcie-pci-bridge with BAR0 (mem, 64-bit, non-pref) [size=256] > > > [d3:01.00] is a PCI Device with BAR0 (mem, 64-bit, pref) [size=128K] > > > BAR4 (mem, 64-bit, pref) [size=64M] > > > > > > In EDK2, the Resource Map would be: > > > PciBus: Resource Map for Bridge [D2|01|00] > > > Type = PMem64; Base = 0x8004000000; Length = 0x4100000; Alignment = 0x3FFFFFF > > > Base = 0x8004000000; Length = 0x4000000; Alignment = 0x3FFFFFF; Owner = PCI [D3|01|00:20] > > > Base = 0x8008000000; Length = 0x20000; Alignment = 0x1FFFF; Owner = PCI [D3|01|00:10] > > > Type = Mem64; Base = 0x8008100000; Length = 0x100; Alignment = 0xFFF > > > It would use 0x4100000 to calculate the root bus's PMem64 resource window. > > > > > > While in Linux, kernel will use 0x1FFFFFF as the alignment to calculate > > > the PMem64 size, which would be 0x6000000. So kernel would try to > > > allocate 0x6000000 from the PMem64 resource window, but since the window > > > size is 0x4100000 as assigned by EDK2, the allocation would fail. > > > > > > The diffences could result in resource assignment failure. > > > > > > Using _DSM #5 method to inform guest os not to ignore the PCI configuration > > > that firmware has done at boot time could handle the differences. > > > > I'm not sure about this one, > > OS should able to reconfigure PCI resources according to what and where is plugged > > (and it even more true is hotplug is taken into account) > > spec says this: > > 0: No (The operating system must not ignore the PCI configuration that firmware has done > at boot time. However, the operating system is free to configure the devices in this hierarchy > that have not been configured by the firmware. There may be a reduced level of hot plug > capability support in this hierarchy due to resource constraints. This situation is the same as > the legacy situation where this _DSM is not provided.) > 1: Yes (The operating system may ignore the PCI configuration that the firmware has done > at boot time, and reconfigure/rebalance the resources in the hierarchy.) I sort of convinced my self that's is just hotplug work might need to implement reconfiguration in guest kernel and maybe QEMU Though I have a question, 1. does it work for PC machine with current kernel, if so why? 2. what it would take to make it work for arm/virt? > and > > IMPLEMENTATION NOTE > This _DSM function provides backwards compatibility on platforms that can run legacy operating > systems. > Operating systems for two different architectures (e.g., x86 and x64) can be installed on a platform. > The firmware cannot distinguish the operating system in time to change the boot configuration of > devices. Say for instance, an x86 operating system in non-PAE mode is installed on a system. The > x86 operating system cannot access device resource space above 4 GiB. So the firmware is required > to configure devices at boot time using addresses below 4 GiB. On the other hand, if an x64 > operating system is installed on this system, it can access device resources above the 4 GiB so it does > not want the firmware to constrain the resource assignment below 4 GiB that the firmware > configures at boot time. It is not possible for the firmware to change this by the time it boots the > operating system. Ignoring the configurations done by firmware at boot time will allow the > operating system to push resource assignment using addresses above 4 GiB for an x64 operating > system while constrain it to addresses below 4 GiB for an x86 operating system. > > so fundamentally, saying "1" here just means "you can ignore what > firmware configured if you like". > > > I have a different question though: our CRS etc is based on what > firmware configured. Is that ok? Or is ACPI expected to somehow > reconfigure itself when OS reconfigures devices? > Think it's ok but could not find documentation either way. guest consume DSDT only at boot time, reconfiguration can done later by PCI subsystem without ACPI (at least it used to be so). However DSM is dynamic, and maybe evaluated at runtime, though I don't know if kernel would re-evaluate this feature bit after boot > > > > > > > > Signed-off-by: Jiahui Cen > > > --- > > > hw/pci-host/gpex-acpi.c | 18 ++++++++++++++++-- > > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > > > diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci-host/gpex-acpi.c > > > index 11b3db8f71..c189306599 100644 > > > --- a/hw/pci-host/gpex-acpi.c > > > +++ b/hw/pci-host/gpex-acpi.c > > > @@ -112,10 +112,24 @@ static void acpi_dsdt_add_pci_osc(Aml *dev) > > > UUID = aml_touuid("E5C937D0-3553-4D7A-9117-EA4D19C3434D"); > > > ifctx = aml_if(aml_equal(aml_arg(0), UUID)); > > > ifctx1 = aml_if(aml_equal(aml_arg(2), aml_int(0))); > > > - uint8_t byte_list[1] = {1}; > > > - buf = aml_buffer(1, byte_list); > > > + uint8_t byte_list[] = { > > > + 0x1 << 0 /* support for functions other than function 0 */ | > > > + 0x1 << 5 /* support for function 5 */ > > > + }; > > > + buf = aml_buffer(ARRAY_SIZE(byte_list), byte_list); > > > aml_append(ifctx1, aml_return(buf)); > > > aml_append(ifctx, ifctx1); > > > + > > > + /* PCI Firmware Specification 3.1 > > > + * 4.6.5. _DSM for Ignoring PCI Boot Configurations > > > + */ > > > + /* Arg2: Function Index: 5 */ > > > + ifctx1 = aml_if(aml_equal(aml_arg(2), aml_int(5))); > > > + /* 0 - The operating system must not ignore the PCI configuration that > > > + * firmware has done at boot time. > > > + */ > > > + aml_append(ifctx1, aml_return(aml_int(0))); > > > + aml_append(ifctx, ifctx1); > > > aml_append(method, ifctx); > > > > > > byte_list[0] = 0; > >