All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: [igt-dev] [PATCH i-g-t v12 19/31] tests/gem_mmap_offset: Use intel_buf wrapper code instead direct
Date: Tue,  5 Jan 2021 09:10:36 +0100	[thread overview]
Message-ID: <20210105081048.14389-20-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20210105081048.14389-1-zbigniew.kempczynski@intel.com>

Generally when playing with intel_buf we should use wrapper code
instead of adding it to intel_bb directly. Code checks required
alignment on specific gens so protects us from passing unaligned
properly addresses.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_mmap_offset.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
index 8b29d0a0a..8f2006274 100644
--- a/tests/i915/gem_mmap_offset.c
+++ b/tests/i915/gem_mmap_offset.c
@@ -614,8 +614,8 @@ static void blt_coherency(int i915)
 	dst = create_bo(bops, 1, width, height);
 	size = src->surface[0].size;
 
-	intel_bb_add_object(ibb, src->handle, size, src->addr.offset, false);
-	intel_bb_add_object(ibb, dst->handle, size, dst->addr.offset, true);
+	intel_bb_add_intel_buf(ibb, src, false);
+	intel_bb_add_intel_buf(ibb, dst, true);
 
 	intel_bb_blt_copy(ibb,
 			  src, 0, 0, src->surface[0].stride,
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-01-05  8:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05  8:10 [igt-dev] [PATCH i-g-t v12 00/31] Introduce IGT allocator Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 01/31] lib/igt_list: igt_hlist implementation Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 02/31] lib/igt_map: Introduce igt_map Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 03/31] lib/igt_core: Track child process pid and tid Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 04/31] lib/intel_allocator_simple: Add simple allocator Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 05/31] lib/intel_allocator_random: Add random allocator Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 06/31] lib/intel_allocator: Add intel_allocator core Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 07/31] lib/intel_allocator: Try to stop smoothly instead of deinit Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 08/31] lib/intel_allocator_msgchannel: Scale to 4k of parallel clients Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 09/31] lib/intel_bufops: Removes handle from allocator, change size Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 10/31] lib/intel_bufops: Add init with handle and size function Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 11/31] lib/intel_batchbuffer: Integrate intel_bb with allocator Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 12/31] lib/intel_batchbuffer: Add tracking intel_buf to intel_bb Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 13/31] lib/intel_aux_pgtable: Get addresses for aux table from an allocator Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 14/31] lib/igt_fb: Initialize intel_buf with same size as fb Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 15/31] tests/api_intel_bb: Modify test to verify intel_bb with allocator Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 16/31] tests/api_intel_bb: Add compressed->compressed copy Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 17/31] tests/api_intel_allocator: Simple allocator test suite Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 18/31] tests/gem|kms: Remove intel_bb from fixture Zbigniew Kempczyński
2021-01-05  8:10 ` Zbigniew Kempczyński [this message]
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 20/31] tests/gem_ppgtt: Adopt test to use intel_bb with allocator Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 21/31] tests/gem_render_copy_redux: Adopt to use with intel_bb and allocator Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 22/31] tests/perf.c: Remove buffer from batch Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 23/31] tests/gem_linear_blits: Use intel allocator Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 24/31] lib/ioctl_wrappers: Add gem_has_relocations() check Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 25/31] lib/intel_batchbuffer: Use relocations in intel-bb up to gen12 Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 26/31] tests/api_intel_*: Adopt to use relocations as default " Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 27/31] tests/gem_ppgtt: Migrate memory check out of render blits Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 28/31] tests/api_intel_bb: Remove check-canonical test Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 29/31] tests/api_intel_bb: Use allocator in delta-check test Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 30/31] lib/intel_allocator: Separate allocator multiprocess start Zbigniew Kempczyński
2021-01-05  8:10 ` [igt-dev] [PATCH i-g-t v12 31/31] tests/api_intel_allocator: Prepare to run with sanitizer Zbigniew Kempczyński
2021-01-05  9:10 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce IGT allocator (rev13) Patchwork
2021-01-05 10:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210105081048.14389-20-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.