From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BC6BC433E0 for ; Tue, 5 Jan 2021 10:01:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F01D722482 for ; Tue, 5 Jan 2021 10:01:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728146AbhAEKBo (ORCPT ); Tue, 5 Jan 2021 05:01:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:55966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727768AbhAEKBn (ORCPT ); Tue, 5 Jan 2021 05:01:43 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 505FE20739; Tue, 5 Jan 2021 10:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609840863; bh=fl36DTv2HFF+3AErrEcVkIXvTzoCJTTN10qAMRZyCyA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fYU1zxe+c/RByYIbFcQOYdSDTQfY7jddZX8YNVGRNns58KGOqMGwvKOQD0T9+hWk4 MhVy+87ZBBIoB6N+zSQGMW6o8zUms9r4oE10Y7aquuAzMmosZoJGR/CkbUEz8EvVNg p2YOPZEblHlmiH0avWlXBI/SDdPvCj3w5OZb2TL4Sh8B4OtMEqh+vsPevF4l+bZauY GGSEaWTCC0qlW+u+ds+WlxibtG9lGnvBWQ3u5MYMNINqCvVLtFHen/X5ebL2WFVHqQ LR+y0NaElpmQAQyW8OVXIOAUmjd5w62JKknfd/Nzz3xaWMpi9smxjBzIkNXGwFiaV+ 1sE/z8pDi37ew== Date: Tue, 5 Jan 2021 12:00:58 +0200 From: Leon Romanovsky To: Heiner Kallweit Cc: Bjorn Helgaas , Russell King - ARM Linux , Realtek linux nic maintainers , David Miller , Jakub Kicinski , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH 1/3] PCI: Disable parity checking if broken_parity_status is set Message-ID: <20210105100058.GQ31158@unreal> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 05, 2021 at 10:41:26AM +0100, Heiner Kallweit wrote: > If we know that a device has broken parity checking, then disable it. > This avoids quirks like in r8169 where on the first parity error > interrupt parity checking will be disabled if broken_parity_status > is set. Make pci_quirk_broken_parity() public so that it can be used > by platform code, e.g. for Thecus N2100. > > Signed-off-by: Heiner Kallweit > --- > drivers/pci/quirks.c | 17 +++++++++++------ > include/linux/pci.h | 2 ++ > 2 files changed, 13 insertions(+), 6 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D8DC433DB for ; Tue, 5 Jan 2021 10:02:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 960BC22288 for ; Tue, 5 Jan 2021 10:02:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 960BC22288 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4I19EQ6Hf4EXc45mUgRzyphYTTko+MutJS2E12J3Fxs=; b=kjjfgGcezDGzLqFrOfQyKPXHx Ni7z6RSzY/DC5mgBwQriAWPKdomoG63ObMgUyiRHceA08Ck7560f8vB/5wbEhLZ9xT5XiPS/YCvlS 2SJ70th/ViMHJQV0jaf3SN9n4M7RJx9YA7icvt9IF7yDuma4DdMXFk/Iz5ELSa4R7rZOyy2EMcfhD JT6uctiA1zNxpTjLLrCfepm7tZMao51jQ3tVof2zbkIsr5Gjj6280w6ghapBSqmFaBBbJAREpfpyR soBYuM9q2xfj392DgrSiLdY+WiDDAqRI01Y+bpeHvWtc3x6wd8AM3XZmav+wW6vC+5tr8NQklVla7 73/v7L1HQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwj9G-0004Up-Um; Tue, 05 Jan 2021 10:01:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwj9E-0004Tx-GC for linux-arm-kernel@lists.infradead.org; Tue, 05 Jan 2021 10:01:05 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 505FE20739; Tue, 5 Jan 2021 10:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609840863; bh=fl36DTv2HFF+3AErrEcVkIXvTzoCJTTN10qAMRZyCyA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fYU1zxe+c/RByYIbFcQOYdSDTQfY7jddZX8YNVGRNns58KGOqMGwvKOQD0T9+hWk4 MhVy+87ZBBIoB6N+zSQGMW6o8zUms9r4oE10Y7aquuAzMmosZoJGR/CkbUEz8EvVNg p2YOPZEblHlmiH0avWlXBI/SDdPvCj3w5OZb2TL4Sh8B4OtMEqh+vsPevF4l+bZauY GGSEaWTCC0qlW+u+ds+WlxibtG9lGnvBWQ3u5MYMNINqCvVLtFHen/X5ebL2WFVHqQ LR+y0NaElpmQAQyW8OVXIOAUmjd5w62JKknfd/Nzz3xaWMpi9smxjBzIkNXGwFiaV+ 1sE/z8pDi37ew== Date: Tue, 5 Jan 2021 12:00:58 +0200 From: Leon Romanovsky To: Heiner Kallweit Subject: Re: [PATCH 1/3] PCI: Disable parity checking if broken_parity_status is set Message-ID: <20210105100058.GQ31158@unreal> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_050104_624680_C52A3A8E X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Realtek linux nic maintainers , "linux-pci@vger.kernel.org" , Russell King - ARM Linux , "netdev@vger.kernel.org" , Bjorn Helgaas , Jakub Kicinski , David Miller , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 05, 2021 at 10:41:26AM +0100, Heiner Kallweit wrote: > If we know that a device has broken parity checking, then disable it. > This avoids quirks like in r8169 where on the first parity error > interrupt parity checking will be disabled if broken_parity_status > is set. Make pci_quirk_broken_parity() public so that it can be used > by platform code, e.g. for Thecus N2100. > > Signed-off-by: Heiner Kallweit > --- > drivers/pci/quirks.c | 17 +++++++++++------ > include/linux/pci.h | 2 ++ > 2 files changed, 13 insertions(+), 6 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel