All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V2 4/6] block: set .bi_max_vecs as actual allocated vector number
Date: Tue,  5 Jan 2021 20:42:01 +0800	[thread overview]
Message-ID: <20210105124203.3726599-5-ming.lei@redhat.com> (raw)
In-Reply-To: <20210105124203.3726599-1-ming.lei@redhat.com>

bvec_alloc() may allocate more bio vectors than requested, so set
.bi_max_vecs as actual allocated vector number, instead of the requested
number. This way can help fs build bigger bio because new bio often won't
be allocated until the current one becomes full.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 block/bio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/block/bio.c b/block/bio.c
index cd3c58ee2458..9857893d550f 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -505,12 +505,13 @@ struct bio *bio_alloc_bioset(gfp_t gfp_mask, unsigned int nr_iovecs,
 			goto err_free;
 
 		bio->bi_flags |= idx << BVEC_POOL_OFFSET;
+		bio->bi_max_vecs = bvec_nr_vecs(idx);
 	} else if (nr_iovecs) {
 		bvl = bio->bi_inline_vecs;
+		bio->bi_max_vecs = inline_vecs;
 	}
 
 	bio->bi_pool = bs;
-	bio->bi_max_vecs = nr_iovecs;
 	bio->bi_io_vec = bvl;
 	return bio;
 
-- 
2.28.0


  parent reply	other threads:[~2021-01-05 12:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 12:41 [PATCH V2 0/6] block: improvement on bioset & bvec allocation Ming Lei
2021-01-05 12:41 ` [PATCH V2 1/6] block: manage bio slab cache by xarray Ming Lei
2021-01-05 15:40   ` Christoph Hellwig
2021-01-05 12:41 ` [PATCH V2 2/6] block: don't pass BIOSET_NEED_BVECS for q->bio_split Ming Lei
2021-01-05 12:42 ` [PATCH V2 3/6] block: don't allocate inline bvecs if this bioset needn't bvecs Ming Lei
2021-01-05 15:41   ` Christoph Hellwig
2021-01-05 12:42 ` Ming Lei [this message]
2021-01-05 12:42 ` [PATCH V2 5/6] block: move three bvec helpers declaration into private helper Ming Lei
2021-01-05 12:42 ` [PATCH V2 6/6] bcache: don't pass BIOSET_NEED_BVECS for the 'bio_set' embedded in 'cache_set' Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210105124203.3726599-5-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.