From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE56BC433DB for ; Tue, 5 Jan 2021 12:52:29 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 6815622AAD for ; Tue, 5 Jan 2021 12:52:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6815622AAD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C7E244B19F; Tue, 5 Jan 2021 07:52:28 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qoyCsN+cbZrr; Tue, 5 Jan 2021 07:52:27 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BD1EC4B1A4; Tue, 5 Jan 2021 07:52:27 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 911684B1A4 for ; Tue, 5 Jan 2021 07:52:26 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wXk1ao7s8AIp for ; Tue, 5 Jan 2021 07:52:25 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id A82F84B19F for ; Tue, 5 Jan 2021 07:52:25 -0500 (EST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 1C31922AAA; Tue, 5 Jan 2021 12:52:22 +0000 (UTC) Date: Tue, 5 Jan 2021 12:52:20 +0000 From: Catalin Marinas To: Marc Zyngier Subject: Re: [PATCH] arm64: Fix labels in el2_setup macros Message-ID: <20210105125220.GD11802@gaia> References: <20201223121131.255551-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201223121131.255551-1-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Dec 23, 2020 at 12:11:31PM +0000, Marc Zyngier wrote: > If someone happens to write the following code: > > b 1f > init_el2_state vhe > 1: > [...] > > they will be in for a long debugging session, as the label "1f" > will be resolved *inside* the init_el2_state macro instead of > after it. Not really what one expects. > > Instead, rewite the EL2 setup macros to use unambiguous labels, > thanks to the usual macro counter trick. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/el2_setup.h | 24 ++++++++++++------------ In case you need an ack: Acked-by: Catalin Marinas _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3780C433DB for ; Tue, 5 Jan 2021 12:53:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C45620735 for ; Tue, 5 Jan 2021 12:53:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C45620735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bUOZHBVVu6pPj8BlIudgGFiupYR3fQuAeKI3OjoHW80=; b=imKmwJVx9JL0f4UuXndg6F/+E xhJhEf9lnVS2FhR/UjCCNPEmQw6OUElPUpXjarYGYjn1PlXaDtHqzzBhpggcO4vdmvnwnhVE+eu2M LUAk3JWKNQQY7+jR+jm46n6azxxQljQOksyIB1+8AhLwd1DkH2wfJL/EFScF6e8hZ0vRxSuYpw+EI ZkAMuJCPCoyQMddKrRBRQbd4IL+RXD3Gmba5KvKLjeRZHuwtyUv3amX0wXGOZjaRTT6QQ+WO4qMqj 43MmzUPZVz1U/vtN/MfIiwBP35kBG7pJ65dzwWgdiiVzPvLW5B7KpYGu8KEF72afEFuG/PJU8Mc9k JUbVDX7zQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwlp6-0008BW-D0; Tue, 05 Jan 2021 12:52:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwlp3-0008B9-KL for linux-arm-kernel@lists.infradead.org; Tue, 05 Jan 2021 12:52:26 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1C31922AAA; Tue, 5 Jan 2021 12:52:22 +0000 (UTC) Date: Tue, 5 Jan 2021 12:52:20 +0000 From: Catalin Marinas To: Marc Zyngier Subject: Re: [PATCH] arm64: Fix labels in el2_setup macros Message-ID: <20210105125220.GD11802@gaia> References: <20201223121131.255551-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201223121131.255551-1-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_075225_763145_18BDE6C1 X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki K Poulose , Alexandru Elisei , James Morse , Julien Thierry , David Brazdil , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 23, 2020 at 12:11:31PM +0000, Marc Zyngier wrote: > If someone happens to write the following code: > > b 1f > init_el2_state vhe > 1: > [...] > > they will be in for a long debugging session, as the label "1f" > will be resolved *inside* the init_el2_state macro instead of > after it. Not really what one expects. > > Instead, rewite the EL2 setup macros to use unambiguous labels, > thanks to the usual macro counter trick. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/el2_setup.h | 24 ++++++++++++------------ In case you need an ack: Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel