All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Leo Li" <sunpeng.li@amd.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Daniel Kolesa" <daniel@octaforge.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Dave Martin" <dave.martin@arm.com>
Subject: Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"
Date: Tue, 5 Jan 2021 13:04:58 +0000	[thread overview]
Message-ID: <20210105130458.GA11108@willie-the-truck> (raw)
In-Reply-To: <CADnq5_PKV4Hekm9Dd_1U2e2RAeb3Mhz_uFSCabWgBNk2gCaAYw@mail.gmail.com>

On Mon, Jan 04, 2021 at 11:27:24AM -0500, Alex Deucher wrote:
> On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel <ardb@kernel.org> wrote:
> > >
> > > On Wed, 16 Dec 2020 at 19:00, Alex Deucher <alexdeucher@gmail.com> wrote:
> > > >
> > > > On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> > > > >
> > > > > This reverts commit c38d444e44badc557cf29fdfdfb823604890ccfa.
> > > > >
> > > > > Simply disabling -mgeneral-regs-only left and right is risky, given that
> > > > > the standard AArch64 ABI permits the use of FP/SIMD registers anywhere,
> > > > > and GCC is known to use SIMD registers for spilling, and may invent
> > > > > other uses of the FP/SIMD register file that have nothing to do with the
> > > > > floating point code in question. Note that putting kernel_neon_begin()
> > > > > and kernel_neon_end() around the code that does use FP is not sufficient
> > > > > here, the problem is in all the other code that may be emitted with
> > > > > references to SIMD registers in it.
> > > > >
> > > > > So the only way to do this properly is to put all floating point code in
> > > > > a separate compilation unit, and only compile that unit with
> > > > > -mgeneral-regs-only. But perhaps the use of floating point here is
> > > > > something that should be reconsidered entirely.
> > > > >
> > > > > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > > > > Cc: Will Deacon <will@kernel.org>
> > > > > Cc: Dave Martin <dave.martin@arm.com>
> > > > > Cc: Rob Herring <robh@kernel.org>
> > > > > Cc: Leo Li <sunpeng.li@amd.com>
> > > > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > > > Cc: "Christian König" <christian.koenig@amd.com>
> > > > > Cc: David Airlie <airlied@linux.ie>
> > > > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > > > Cc: Daniel Kolesa <daniel@octaforge.org>
> > > > > Cc: amd-gfx@lists.freedesktop.org
> > > > > Cc: dri-devel@lists.freedesktop.org
> > > > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > >
> > > > Can rebase this on Linus' master branch?  There were a number of new
> > > > asics added which copy pasted the ARM64 support.
> > > >
> > >
> > > Not sure what you are asking me here. Reverting commit c38d444e44badc5
> > > on top of mainline is not going to fix the other code that was added.
> > > Or are you asking me to go and find the patches (how many?) that added
> > > new ASICs and fix them for arm64?
> > >
> > > Note that this code is critically broken, as it may corrupt user
> > > process state arbitrarily. So if new code was added that contains the
> > > same bug, it should be reverted so that the respective authors can fix
> > > it and resubmit.
> > >
> >
> > Is this simply about dropping the newly added references to
> > $(dml_rcflags) from the Makefile? Because that is quite trivial ...
> 
> Yes, I was thinking something like the attached patch.
> 
> Alex

> From fbc93ca7d7739861ce63f6b483cf23d7cf1d69fb Mon Sep 17 00:00:00 2001
> From: Alex Deucher <alexander.deucher@amd.com>
> Date: Mon, 4 Jan 2021 11:24:20 -0500
> Subject: [PATCH] drm/amdgpu/display: drop DCN support for aarch64
> 
> From Ard:
> 
> "Simply disabling -mgeneral-regs-only left and right is risky, given that
> the standard AArch64 ABI permits the use of FP/SIMD registers anywhere,
> and GCC is known to use SIMD registers for spilling, and may invent
> other uses of the FP/SIMD register file that have nothing to do with the
> floating point code in question. Note that putting kernel_neon_begin()
> and kernel_neon_end() around the code that does use FP is not sufficient
> here, the problem is in all the other code that may be emitted with
> references to SIMD registers in it.
> 
> So the only way to do this properly is to put all floating point code in
> a separate compilation unit, and only compile that unit with
> -mgeneral-regs-only."
> 
> Disable support until the code can be properly refactored to support this
> properly on aarch64.
> 
> Reported-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/display/Kconfig           |  2 +-
>  drivers/gpu/drm/amd/display/dc/calcs/Makefile |  4 ----
>  .../gpu/drm/amd/display/dc/clk_mgr/Makefile   | 21 -------------------
>  drivers/gpu/drm/amd/display/dc/dcn10/Makefile |  7 -------
>  .../drm/amd/display/dc/dcn10/dcn10_resource.c |  7 -------
>  drivers/gpu/drm/amd/display/dc/dcn20/Makefile |  4 ----
>  drivers/gpu/drm/amd/display/dc/dcn21/Makefile |  4 ----
>  drivers/gpu/drm/amd/display/dc/dcn30/Makefile |  5 -----
>  .../gpu/drm/amd/display/dc/dcn301/Makefile    |  4 ----
>  .../gpu/drm/amd/display/dc/dcn302/Makefile    |  4 ----
>  drivers/gpu/drm/amd/display/dc/dml/Makefile   |  4 ----
>  drivers/gpu/drm/amd/display/dc/dsc/Makefile   |  4 ----
>  drivers/gpu/drm/amd/display/dc/os_types.h     |  4 ----
>  13 files changed, 1 insertion(+), 73 deletions(-)

Acked-by: Will Deacon <will@kernel.org>

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Leo Li" <sunpeng.li@amd.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Daniel Kolesa" <daniel@octaforge.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Dave Martin" <dave.martin@arm.com>
Subject: Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"
Date: Tue, 5 Jan 2021 13:04:58 +0000	[thread overview]
Message-ID: <20210105130458.GA11108@willie-the-truck> (raw)
In-Reply-To: <CADnq5_PKV4Hekm9Dd_1U2e2RAeb3Mhz_uFSCabWgBNk2gCaAYw@mail.gmail.com>

On Mon, Jan 04, 2021 at 11:27:24AM -0500, Alex Deucher wrote:
> On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel <ardb@kernel.org> wrote:
> > >
> > > On Wed, 16 Dec 2020 at 19:00, Alex Deucher <alexdeucher@gmail.com> wrote:
> > > >
> > > > On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> > > > >
> > > > > This reverts commit c38d444e44badc557cf29fdfdfb823604890ccfa.
> > > > >
> > > > > Simply disabling -mgeneral-regs-only left and right is risky, given that
> > > > > the standard AArch64 ABI permits the use of FP/SIMD registers anywhere,
> > > > > and GCC is known to use SIMD registers for spilling, and may invent
> > > > > other uses of the FP/SIMD register file that have nothing to do with the
> > > > > floating point code in question. Note that putting kernel_neon_begin()
> > > > > and kernel_neon_end() around the code that does use FP is not sufficient
> > > > > here, the problem is in all the other code that may be emitted with
> > > > > references to SIMD registers in it.
> > > > >
> > > > > So the only way to do this properly is to put all floating point code in
> > > > > a separate compilation unit, and only compile that unit with
> > > > > -mgeneral-regs-only. But perhaps the use of floating point here is
> > > > > something that should be reconsidered entirely.
> > > > >
> > > > > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > > > > Cc: Will Deacon <will@kernel.org>
> > > > > Cc: Dave Martin <dave.martin@arm.com>
> > > > > Cc: Rob Herring <robh@kernel.org>
> > > > > Cc: Leo Li <sunpeng.li@amd.com>
> > > > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > > > Cc: "Christian König" <christian.koenig@amd.com>
> > > > > Cc: David Airlie <airlied@linux.ie>
> > > > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > > > Cc: Daniel Kolesa <daniel@octaforge.org>
> > > > > Cc: amd-gfx@lists.freedesktop.org
> > > > > Cc: dri-devel@lists.freedesktop.org
> > > > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > >
> > > > Can rebase this on Linus' master branch?  There were a number of new
> > > > asics added which copy pasted the ARM64 support.
> > > >
> > >
> > > Not sure what you are asking me here. Reverting commit c38d444e44badc5
> > > on top of mainline is not going to fix the other code that was added.
> > > Or are you asking me to go and find the patches (how many?) that added
> > > new ASICs and fix them for arm64?
> > >
> > > Note that this code is critically broken, as it may corrupt user
> > > process state arbitrarily. So if new code was added that contains the
> > > same bug, it should be reverted so that the respective authors can fix
> > > it and resubmit.
> > >
> >
> > Is this simply about dropping the newly added references to
> > $(dml_rcflags) from the Makefile? Because that is quite trivial ...
> 
> Yes, I was thinking something like the attached patch.
> 
> Alex

> From fbc93ca7d7739861ce63f6b483cf23d7cf1d69fb Mon Sep 17 00:00:00 2001
> From: Alex Deucher <alexander.deucher@amd.com>
> Date: Mon, 4 Jan 2021 11:24:20 -0500
> Subject: [PATCH] drm/amdgpu/display: drop DCN support for aarch64
> 
> From Ard:
> 
> "Simply disabling -mgeneral-regs-only left and right is risky, given that
> the standard AArch64 ABI permits the use of FP/SIMD registers anywhere,
> and GCC is known to use SIMD registers for spilling, and may invent
> other uses of the FP/SIMD register file that have nothing to do with the
> floating point code in question. Note that putting kernel_neon_begin()
> and kernel_neon_end() around the code that does use FP is not sufficient
> here, the problem is in all the other code that may be emitted with
> references to SIMD registers in it.
> 
> So the only way to do this properly is to put all floating point code in
> a separate compilation unit, and only compile that unit with
> -mgeneral-regs-only."
> 
> Disable support until the code can be properly refactored to support this
> properly on aarch64.
> 
> Reported-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/display/Kconfig           |  2 +-
>  drivers/gpu/drm/amd/display/dc/calcs/Makefile |  4 ----
>  .../gpu/drm/amd/display/dc/clk_mgr/Makefile   | 21 -------------------
>  drivers/gpu/drm/amd/display/dc/dcn10/Makefile |  7 -------
>  .../drm/amd/display/dc/dcn10/dcn10_resource.c |  7 -------
>  drivers/gpu/drm/amd/display/dc/dcn20/Makefile |  4 ----
>  drivers/gpu/drm/amd/display/dc/dcn21/Makefile |  4 ----
>  drivers/gpu/drm/amd/display/dc/dcn30/Makefile |  5 -----
>  .../gpu/drm/amd/display/dc/dcn301/Makefile    |  4 ----
>  .../gpu/drm/amd/display/dc/dcn302/Makefile    |  4 ----
>  drivers/gpu/drm/amd/display/dc/dml/Makefile   |  4 ----
>  drivers/gpu/drm/amd/display/dc/dsc/Makefile   |  4 ----
>  drivers/gpu/drm/amd/display/dc/os_types.h     |  4 ----
>  13 files changed, 1 insertion(+), 73 deletions(-)

Acked-by: Will Deacon <will@kernel.org>

Will
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Rob Herring" <robh@kernel.org>, "Leo Li" <sunpeng.li@amd.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Daniel Kolesa" <daniel@octaforge.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Dave Martin" <dave.martin@arm.com>
Subject: Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"
Date: Tue, 5 Jan 2021 13:04:58 +0000	[thread overview]
Message-ID: <20210105130458.GA11108@willie-the-truck> (raw)
In-Reply-To: <CADnq5_PKV4Hekm9Dd_1U2e2RAeb3Mhz_uFSCabWgBNk2gCaAYw@mail.gmail.com>

On Mon, Jan 04, 2021 at 11:27:24AM -0500, Alex Deucher wrote:
> On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel <ardb@kernel.org> wrote:
> > >
> > > On Wed, 16 Dec 2020 at 19:00, Alex Deucher <alexdeucher@gmail.com> wrote:
> > > >
> > > > On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> > > > >
> > > > > This reverts commit c38d444e44badc557cf29fdfdfb823604890ccfa.
> > > > >
> > > > > Simply disabling -mgeneral-regs-only left and right is risky, given that
> > > > > the standard AArch64 ABI permits the use of FP/SIMD registers anywhere,
> > > > > and GCC is known to use SIMD registers for spilling, and may invent
> > > > > other uses of the FP/SIMD register file that have nothing to do with the
> > > > > floating point code in question. Note that putting kernel_neon_begin()
> > > > > and kernel_neon_end() around the code that does use FP is not sufficient
> > > > > here, the problem is in all the other code that may be emitted with
> > > > > references to SIMD registers in it.
> > > > >
> > > > > So the only way to do this properly is to put all floating point code in
> > > > > a separate compilation unit, and only compile that unit with
> > > > > -mgeneral-regs-only. But perhaps the use of floating point here is
> > > > > something that should be reconsidered entirely.
> > > > >
> > > > > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > > > > Cc: Will Deacon <will@kernel.org>
> > > > > Cc: Dave Martin <dave.martin@arm.com>
> > > > > Cc: Rob Herring <robh@kernel.org>
> > > > > Cc: Leo Li <sunpeng.li@amd.com>
> > > > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > > > Cc: "Christian König" <christian.koenig@amd.com>
> > > > > Cc: David Airlie <airlied@linux.ie>
> > > > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > > > Cc: Daniel Kolesa <daniel@octaforge.org>
> > > > > Cc: amd-gfx@lists.freedesktop.org
> > > > > Cc: dri-devel@lists.freedesktop.org
> > > > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > > >
> > > > Can rebase this on Linus' master branch?  There were a number of new
> > > > asics added which copy pasted the ARM64 support.
> > > >
> > >
> > > Not sure what you are asking me here. Reverting commit c38d444e44badc5
> > > on top of mainline is not going to fix the other code that was added.
> > > Or are you asking me to go and find the patches (how many?) that added
> > > new ASICs and fix them for arm64?
> > >
> > > Note that this code is critically broken, as it may corrupt user
> > > process state arbitrarily. So if new code was added that contains the
> > > same bug, it should be reverted so that the respective authors can fix
> > > it and resubmit.
> > >
> >
> > Is this simply about dropping the newly added references to
> > $(dml_rcflags) from the Makefile? Because that is quite trivial ...
> 
> Yes, I was thinking something like the attached patch.
> 
> Alex

> From fbc93ca7d7739861ce63f6b483cf23d7cf1d69fb Mon Sep 17 00:00:00 2001
> From: Alex Deucher <alexander.deucher@amd.com>
> Date: Mon, 4 Jan 2021 11:24:20 -0500
> Subject: [PATCH] drm/amdgpu/display: drop DCN support for aarch64
> 
> From Ard:
> 
> "Simply disabling -mgeneral-regs-only left and right is risky, given that
> the standard AArch64 ABI permits the use of FP/SIMD registers anywhere,
> and GCC is known to use SIMD registers for spilling, and may invent
> other uses of the FP/SIMD register file that have nothing to do with the
> floating point code in question. Note that putting kernel_neon_begin()
> and kernel_neon_end() around the code that does use FP is not sufficient
> here, the problem is in all the other code that may be emitted with
> references to SIMD registers in it.
> 
> So the only way to do this properly is to put all floating point code in
> a separate compilation unit, and only compile that unit with
> -mgeneral-regs-only."
> 
> Disable support until the code can be properly refactored to support this
> properly on aarch64.
> 
> Reported-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/display/Kconfig           |  2 +-
>  drivers/gpu/drm/amd/display/dc/calcs/Makefile |  4 ----
>  .../gpu/drm/amd/display/dc/clk_mgr/Makefile   | 21 -------------------
>  drivers/gpu/drm/amd/display/dc/dcn10/Makefile |  7 -------
>  .../drm/amd/display/dc/dcn10/dcn10_resource.c |  7 -------
>  drivers/gpu/drm/amd/display/dc/dcn20/Makefile |  4 ----
>  drivers/gpu/drm/amd/display/dc/dcn21/Makefile |  4 ----
>  drivers/gpu/drm/amd/display/dc/dcn30/Makefile |  5 -----
>  .../gpu/drm/amd/display/dc/dcn301/Makefile    |  4 ----
>  .../gpu/drm/amd/display/dc/dcn302/Makefile    |  4 ----
>  drivers/gpu/drm/amd/display/dc/dml/Makefile   |  4 ----
>  drivers/gpu/drm/amd/display/dc/dsc/Makefile   |  4 ----
>  drivers/gpu/drm/amd/display/dc/os_types.h     |  4 ----
>  13 files changed, 1 insertion(+), 73 deletions(-)

Acked-by: Will Deacon <will@kernel.org>

Will
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2021-01-05 13:06 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 17:52 [PATCH] drm/amd/display: Revert "add DCN support for aarch64" Ard Biesheuvel
2020-12-14 17:52 ` Ard Biesheuvel
2020-12-14 17:52 ` Ard Biesheuvel
2020-12-14 23:50 ` Will Deacon
2020-12-14 23:50   ` Will Deacon
2020-12-14 23:50   ` Will Deacon
2020-12-16 18:00 ` Alex Deucher
2020-12-16 18:00   ` Alex Deucher
2020-12-16 18:00   ` Alex Deucher
2020-12-16 22:26   ` Ard Biesheuvel
2020-12-16 22:26     ` Ard Biesheuvel
2020-12-16 22:26     ` Ard Biesheuvel
2020-12-29 13:17     ` Ard Biesheuvel
2020-12-29 13:17       ` Ard Biesheuvel
2020-12-29 13:17       ` Ard Biesheuvel
2021-01-04 16:27       ` Alex Deucher
2021-01-04 16:27         ` Alex Deucher
2021-01-04 16:27         ` Alex Deucher
2021-01-04 16:42         ` Ard Biesheuvel
2021-01-04 16:42           ` Ard Biesheuvel
2021-01-04 16:42           ` Ard Biesheuvel
2021-01-05 13:04         ` Will Deacon [this message]
2021-01-05 13:04           ` Will Deacon
2021-01-05 13:04           ` Will Deacon
2021-01-05 16:23           ` Alex Deucher
2021-01-05 16:23             ` Alex Deucher
2021-01-05 16:23             ` Alex Deucher
2021-01-20  8:20             ` Ard Biesheuvel
2021-01-20  8:20               ` Ard Biesheuvel
2021-01-20  8:20               ` Ard Biesheuvel
2021-01-20 22:38               ` Alex Deucher
2021-01-20 22:38                 ` Alex Deucher
2021-01-20 22:38                 ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210105130458.GA11108@willie-the-truck \
    --to=will@kernel.org \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=daniel@octaforge.org \
    --cc=dave.martin@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.