From: Ira Weiny <ira.weiny@intel.com>
To: Hao Li <lihao2018.fnst@cn.fujitsu.com>
Cc: corbet@lwn.net, davem@davemloft.net, gregkh@linuxfoundation.org,
alexander.deucher@amd.com, mchehab+huawei@kernel.org,
lee.jones@linaro.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Documentation/dax: Update description of DAX policy changing
Date: Tue, 5 Jan 2021 21:45:41 -0800 [thread overview]
Message-ID: <20210106054541.GR3097896@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20210106015000.5263-1-lihao2018.fnst@cn.fujitsu.com>
On Wed, Jan 06, 2021 at 09:50:00AM +0800, Hao Li wrote:
> After commit 77573fa310d9 ("fs: Kill DCACHE_DONTCACHE dentry even if
> DCACHE_REFERENCED is set"), changes to DAX policy will take effect
> as soon as all references to this file are gone.
>
> Update the documentation accordingly.
>
> Signed-off-by: Hao Li <lihao2018.fnst@cn.fujitsu.com>
LGTM
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> Changes in v2:
> * simplify sentences and fix style problems.
>
> Documentation/filesystems/dax.txt | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/filesystems/dax.txt b/Documentation/filesystems/dax.txt
> index 8fdb78f3c6c9..e03c20564f3a 100644
> --- a/Documentation/filesystems/dax.txt
> +++ b/Documentation/filesystems/dax.txt
> @@ -83,20 +83,9 @@ Summary
> directories. This has runtime constraints and limitations that are
> described in 6) below.
>
> - 6. When changing the S_DAX policy via toggling the persistent FS_XFLAG_DAX flag,
> - the change in behaviour for existing regular files may not occur
> - immediately. If the change must take effect immediately, the administrator
> - needs to:
> -
> - a) stop the application so there are no active references to the data set
> - the policy change will affect
> -
> - b) evict the data set from kernel caches so it will be re-instantiated when
> - the application is restarted. This can be achieved by:
> -
> - i. drop-caches
> - ii. a filesystem unmount and mount cycle
> - iii. a system reboot
> + 6. When changing the S_DAX policy via toggling the persistent FS_XFLAG_DAX
> + flag, the change to existing regular files won't take effect until the
> + files are closed by all processes.
>
>
> Details
> --
> 2.29.2
>
>
>
next prev parent reply other threads:[~2021-01-06 5:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 1:50 [PATCH v2] Documentation/dax: Update description of DAX policy changing Hao Li
2021-01-06 5:45 ` Ira Weiny [this message]
2021-01-11 19:59 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106054541.GR3097896@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=alexander.deucher@amd.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=lihao2018.fnst@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.