All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muchun Song <songmuchun@bytedance.com>
To: mike.kravetz@oracle.com, akpm@linux-foundation.org
Cc: n-horiguchi@ah.jp.nec.com, ak@linux.intel.com, mhocko@suse.cz,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Muchun Song <songmuchun@bytedance.com>,
	Yang Shi <shy828301@gmail.com>
Subject: [PATCH v2 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one
Date: Wed,  6 Jan 2021 16:47:34 +0800	[thread overview]
Message-ID: <20210106084739.63318-2-songmuchun@bytedance.com> (raw)
In-Reply-To: <20210106084739.63318-1-songmuchun@bytedance.com>

If the refcount is one when it is migrated, it means that the page
was freed from under us. So we are done and do not need to migrate.

Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Acked-by: Yang Shi <shy828301@gmail.com>
---
 mm/migrate.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/mm/migrate.c b/mm/migrate.c
index 4385f2fb5d18..a6631c4eb6a6 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1279,6 +1279,12 @@ static int unmap_and_move_huge_page(new_page_t get_new_page,
 		return -ENOSYS;
 	}
 
+	if (page_count(hpage) == 1) {
+		/* page was freed from under us. So we are done. */
+		putback_active_hugepage(hpage);
+		return MIGRATEPAGE_SUCCESS;
+	}
+
 	new_hpage = get_new_page(hpage, private);
 	if (!new_hpage)
 		return -ENOMEM;
-- 
2.11.0


  reply	other threads:[~2021-01-06  8:50 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06  8:47 [PATCH v2 0/6] Fix some bugs about HugeTLB code Muchun Song
2021-01-06  8:47 ` Muchun Song [this message]
2021-01-06 16:13   ` [PATCH v2 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one Michal Hocko
2021-01-07  2:52     ` [External] " Muchun Song
2021-01-07  2:52       ` Muchun Song
2021-01-07 11:16       ` Michal Hocko
2021-01-07 11:24         ` Muchun Song
2021-01-07 11:24           ` Muchun Song
2021-01-07 11:48           ` Michal Hocko
2021-01-06  8:47 ` [PATCH v2 2/6] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page Muchun Song
2021-01-06 16:35   ` Michal Hocko
2021-01-06 19:30     ` Mike Kravetz
2021-01-06 20:02       ` Michal Hocko
2021-01-06 21:07         ` Mike Kravetz
2021-01-07  8:36           ` Michal Hocko
2021-01-07  2:58     ` [External] " Muchun Song
2021-01-07  2:58       ` Muchun Song
2021-01-06  8:47 ` [PATCH v2 3/6] mm: hugetlb: fix a race between freeing and dissolving the page Muchun Song
2021-01-06 16:56   ` Michal Hocko
2021-01-06 20:58     ` Mike Kravetz
2021-01-07  3:08       ` [External] " Muchun Song
2021-01-07  3:08         ` Muchun Song
2021-01-07  8:40       ` Michal Hocko
2021-01-08  0:52         ` Mike Kravetz
2021-01-08  8:28           ` Michal Hocko
2021-01-07  5:39     ` [External] " Muchun Song
2021-01-07  5:39       ` Muchun Song
2021-01-07  8:41       ` Michal Hocko
2021-01-07  8:53         ` Muchun Song
2021-01-07  8:53           ` Muchun Song
2021-01-07 11:18           ` Michal Hocko
2021-01-07 11:38             ` Muchun Song
2021-01-07 11:38               ` Muchun Song
2021-01-07 12:38               ` Michal Hocko
2021-01-07 12:59                 ` Muchun Song
2021-01-07 12:59                   ` Muchun Song
2021-01-07 14:11                   ` Michal Hocko
2021-01-07 15:11                     ` Muchun Song
2021-01-07 15:11                       ` Muchun Song
2021-01-08  1:06                       ` Mike Kravetz
2021-01-08  2:38                         ` Muchun Song
2021-01-08  2:38                           ` Muchun Song
2021-01-08  8:43                       ` Michal Hocko
2021-01-08  9:01                         ` Muchun Song
2021-01-08  9:01                           ` Muchun Song
2021-01-08  9:31                           ` Michal Hocko
2021-01-08 10:08                             ` Muchun Song
2021-01-08 10:08                               ` Muchun Song
2021-01-08 11:44                               ` Michal Hocko
2021-01-08 11:52                                 ` Muchun Song
2021-01-08 11:52                                   ` Muchun Song
2021-01-08 12:04                                   ` Michal Hocko
2021-01-08 12:24                                     ` Muchun Song
2021-01-08 12:24                                       ` Muchun Song
2021-01-06  8:47 ` [PATCH v2 4/6] mm: hugetlb: add return -EAGAIN for dissolve_free_huge_page Muchun Song
2021-01-06 17:07   ` Michal Hocko
2021-01-07  3:11     ` [External] " Muchun Song
2021-01-07  3:11       ` Muchun Song
2021-01-07  8:39       ` Michal Hocko
2021-01-07  9:01         ` Muchun Song
2021-01-07  9:01           ` Muchun Song
2021-01-07 11:22           ` Michal Hocko
2021-01-06  8:47 ` [PATCH v2 5/6] mm: hugetlb: fix a race between isolating and freeing page Muchun Song
2021-01-06 17:10   ` Michal Hocko
2021-01-06  8:47 ` [PATCH v2 6/6] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active Muchun Song
2021-01-06 17:16   ` Michal Hocko
2021-01-08 22:24   ` Mike Kravetz
2021-01-09  4:07     ` [External] " Muchun Song
2021-01-09  4:07       ` Muchun Song
2021-01-07  9:30 ` [PATCH v2 0/6] Fix some bugs about HugeTLB code David Hildenbrand
2021-01-07  9:40   ` [External] " Muchun Song
2021-01-07  9:40     ` Muchun Song
2021-01-07 10:10     ` David Hildenbrand
2021-01-07 10:16       ` Muchun Song
2021-01-07 10:16         ` Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210106084739.63318-2-songmuchun@bytedance.com \
    --to=songmuchun@bytedance.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=mike.kravetz@oracle.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=shy828301@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.