From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C05C433DB for ; Wed, 6 Jan 2021 14:52:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AAAE23106 for ; Wed, 6 Jan 2021 14:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726852AbhAFOwm (ORCPT ); Wed, 6 Jan 2021 09:52:42 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:59658 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726499AbhAFOwl (ORCPT ); Wed, 6 Jan 2021 09:52:41 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 106Ena0t075317; Wed, 6 Jan 2021 14:51:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=tIA8GlTWf3yVssgYetYQok6eZau6hlzofE7mX8MNTEQ=; b=KioYAGiejyEuyCo0AjAS3xp3TP9zuynp6zh6M2UScSTILVHPrJT7ZKZcC0mLm6C5cS5o zvdjNZRLVOE9MRJXpfeT7/+qmEsTZhyrtoeK9HSHBW9jpfoOIlxNN0fx6msHaCXGMqQi vcVW8gyijz3d+hUAksNndW0TkWSbBPYmzHQBQNRjNxkb89O5ZXyrXbQR47eC4LivtOaV g1N9sFXCe6vhtkvoFvdRqq8qizyBGiBGxBONuQdLwRa0Yge9QbzHybYD9/XXbbSTSs/m AMs9v4meU/bFqHyO0SbTxlUPuMyibfyEAVLzoGvGUNzT+Cx++XcMRTWQI2isjpfXxxSz Mw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 35wepm85xj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 06 Jan 2021 14:51:14 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 106EoSs8166955; Wed, 6 Jan 2021 14:51:14 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 35v4rcrryg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Jan 2021 14:51:14 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 106EpB1w011216; Wed, 6 Jan 2021 14:51:12 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 06 Jan 2021 06:51:08 -0800 Date: Wed, 6 Jan 2021 17:51:00 +0300 From: Dan Carpenter To: Zheng Yongjun Cc: clabbe@baylibre.com, mchehab@kernel.org, mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH -next] media: zoran: use resource_size Message-ID: <20210106145100.GJ2809@kadam> References: <20210106131702.32507-1-zhengyongjun3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210106131702.32507-1-zhengyongjun3@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9855 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101060093 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9855 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 clxscore=1011 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101060093 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 06, 2021 at 09:17:02PM +0800, Zheng Yongjun wrote: > Use resource_size rather than a verbose computation on > the end and start fields. > > Signed-off-by: Zheng Yongjun > --- > drivers/staging/media/zoran/zoran_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c > index 808196ea5b81..d60b4c73ea80 100644 > --- a/drivers/staging/media/zoran/zoran_driver.c > +++ b/drivers/staging/media/zoran/zoran_driver.c > @@ -1020,7 +1020,7 @@ int zoran_queue_init(struct zoran *zr, struct vb2_queue *vq) > vq->buf_struct_size = sizeof(struct zr_buffer); > vq->ops = &zr_video_qops; > vq->mem_ops = &vb2_dma_contig_memops; > - vq->gfp_flags = GFP_DMA32, > + vq->gfp_flags = GFP_DMA32; The commit doesn't match the patch. Also this driver is in staging because it's going to be deleted soon so there probably isn't much point doing cleanups. If you're looking at the Smatch resource_size() message, then that's a tricky thing because of the + 1 on part of the "end - start + 1"... It's sometimes hard to know if we should add the + 1 which resource_size() does or not. (That check is ancient and not up to modern standards). regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3BACC433DB for ; Wed, 6 Jan 2021 14:51:21 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D41B2311B for ; Wed, 6 Jan 2021 14:51:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D41B2311B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id E0A8D86A25; Wed, 6 Jan 2021 14:51:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SwCZUdl2AmK7; Wed, 6 Jan 2021 14:51:19 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id E0AA686A14; Wed, 6 Jan 2021 14:51:19 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id A2A8C1BF5A4 for ; Wed, 6 Jan 2021 14:51:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9F07285313 for ; Wed, 6 Jan 2021 14:51:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fMfs5s8PVU3N for ; Wed, 6 Jan 2021 14:51:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by fraxinus.osuosl.org (Postfix) with ESMTPS id E13A685277 for ; Wed, 6 Jan 2021 14:51:17 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 106Ena0t075317; Wed, 6 Jan 2021 14:51:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=tIA8GlTWf3yVssgYetYQok6eZau6hlzofE7mX8MNTEQ=; b=KioYAGiejyEuyCo0AjAS3xp3TP9zuynp6zh6M2UScSTILVHPrJT7ZKZcC0mLm6C5cS5o zvdjNZRLVOE9MRJXpfeT7/+qmEsTZhyrtoeK9HSHBW9jpfoOIlxNN0fx6msHaCXGMqQi vcVW8gyijz3d+hUAksNndW0TkWSbBPYmzHQBQNRjNxkb89O5ZXyrXbQR47eC4LivtOaV g1N9sFXCe6vhtkvoFvdRqq8qizyBGiBGxBONuQdLwRa0Yge9QbzHybYD9/XXbbSTSs/m AMs9v4meU/bFqHyO0SbTxlUPuMyibfyEAVLzoGvGUNzT+Cx++XcMRTWQI2isjpfXxxSz Mw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 35wepm85xj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 06 Jan 2021 14:51:14 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 106EoSs8166955; Wed, 6 Jan 2021 14:51:14 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 35v4rcrryg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Jan 2021 14:51:14 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 106EpB1w011216; Wed, 6 Jan 2021 14:51:12 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 06 Jan 2021 06:51:08 -0800 Date: Wed, 6 Jan 2021 17:51:00 +0300 From: Dan Carpenter To: Zheng Yongjun Subject: Re: [PATCH -next] media: zoran: use resource_size Message-ID: <20210106145100.GJ2809@kadam> References: <20210106131702.32507-1-zhengyongjun3@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210106131702.32507-1-zhengyongjun3@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9855 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101060093 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9855 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 clxscore=1011 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101060093 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mjpeg-users@lists.sourceforge.net, clabbe@baylibre.com, mchehab@kernel.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Wed, Jan 06, 2021 at 09:17:02PM +0800, Zheng Yongjun wrote: > Use resource_size rather than a verbose computation on > the end and start fields. > > Signed-off-by: Zheng Yongjun > --- > drivers/staging/media/zoran/zoran_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c > index 808196ea5b81..d60b4c73ea80 100644 > --- a/drivers/staging/media/zoran/zoran_driver.c > +++ b/drivers/staging/media/zoran/zoran_driver.c > @@ -1020,7 +1020,7 @@ int zoran_queue_init(struct zoran *zr, struct vb2_queue *vq) > vq->buf_struct_size = sizeof(struct zr_buffer); > vq->ops = &zr_video_qops; > vq->mem_ops = &vb2_dma_contig_memops; > - vq->gfp_flags = GFP_DMA32, > + vq->gfp_flags = GFP_DMA32; The commit doesn't match the patch. Also this driver is in staging because it's going to be deleted soon so there probably isn't much point doing cleanups. If you're looking at the Smatch resource_size() message, then that's a tricky thing because of the + 1 on part of the "end - start + 1"... It's sometimes hard to know if we should add the + 1 which resource_size() does or not. (That check is ancient and not up to modern standards). regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel