All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Aya Levin <ayal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Daniel Axtens <dja@axtens.net>,
	netdev@vger.kernel.org, Moshe Shemesh <moshe@mellanox.com>,
	Tariq Toukan <tariqt@nvidia.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH net V2] net: ipv6: Validate GSO SKB before finish IPv6 processing
Date: Wed, 6 Jan 2021 15:52:06 -0800	[thread overview]
Message-ID: <20210106155206.6f872e08@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1609854201-30143-1-git-send-email-ayal@nvidia.com>

On Tue,  5 Jan 2021 15:43:21 +0200 Aya Levin wrote:
> There are cases where GSO segment's length exceeds the egress MTU.

Please name same for posterity.

Please widen the CC list.

> If so:
>  - Consume the SKB and its segments.
>  - Issue an ICMP packet with 'Packet Too Big' message containing the
>    MTU, allowing the source host to reduce its Path MTU appropriately.
> 
> Note: These cases are handled in the same manner in IPv4 output finish.
> This patch aligns the behavior of IPv6 and the one of IPv4.
>
> Fixes: 9e50849054a4 ("netfilter: ipv6: move POSTROUTING invocation before fragmentation")

Not sure if this commit actually adds the problem or just moves the
problematic snippet around. But probably doesn't matter that much for
10+ years old code.

> Signed-off-by: Aya Levin <ayal@nvidia.com>
> Reviewed-by: Tariq Toukan <tariqt@nvidia.com>

The code itself looks reasonable AFAICT.

      reply	other threads:[~2021-01-06 23:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 13:43 [PATCH net V2] net: ipv6: Validate GSO SKB before finish IPv6 processing Aya Levin
2021-01-06 23:52 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210106155206.6f872e08@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=ayal@nvidia.com \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=dja@axtens.net \
    --cc=moshe@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.