Re: [PATCH v2 net-next 01/10] net: switchdev: remove vid_begin -> vid_end range from VLAN objects

From: Vladimir Oltean <olteanv@gmail.com>
To: Ido Schimmel <idosch@idosch.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	Woojung Huh <woojung.huh@microchip.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Sean Wang <sean.wang@mediatek.com>,
	Landen Chao <Landen.Chao@mediatek.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Vadym Kochan <vkochan@marvell.com>,
	Taras Chornyi <tchornyi@marvell.com>,
	Jiri Pirko <jiri@nvidia.com>, Ido Schimmel <idosch@nvidia.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Ivan Vecera <ivecera@redhat.com>
Subject: Re: [PATCH v2 net-next 01/10] net: switchdev: remove vid_begin -> vid_end range from VLAN objects
Date: Wed, 6 Jan 2021 19:15:59 +0200	[thread overview]
Message-ID: <20210106171559.abu2jffskjsry77b@skbuf> (raw)
In-Reply-To: <20210106170818.GA1080217@shredder.lan>

On Wed, Jan 06, 2021 at 07:08:18PM +0200, Ido Schimmel wrote:
> On Wed, Jan 06, 2021 at 03:09:57PM +0200, Vladimir Oltean wrote:
> > Let's go off and finish the job of commit 29ab586c3d83 by deleting the
> > bogus iteration through the VLAN ranges from the drivers. Some aspects
> > of this feature never made too much sense in the first place. For
> > example, what is a range of VLANs all having the BRIDGE_VLAN_INFO_PVID
> > flag supposed to mean, when a port can obviously have a single pvid? The
> > switchdev drivers have so far interpreted this to mean that the last
> > VLAN in the range should be the only one which should get programmed
> > with that attribute.
> 
> See commit 6623c60dc28e ("bridge: vlan: enforce no pvid flag in vlan
> ranges")

No, I agree, but still it changes nothing in terms of the hoops that a
driver must go through. It should still only program vlan->vid_end as
pvid either way. Which is strikingly odd.

> > Of the existing switchdev pieces of hardware, it appears that only
> > Mellanox Spectrum supports offloading more than one VLAN at a time.
> > I have kept that code internal to the driver, because there is some more
> > bookkeeping that makes use of it, but I deleted it from the switchdev
> > API. But since the switchdev support for ranges has already been de
> > facto deleted by a Mellanox employee and nobody noticed for 4 years, I'm
> > going to assume it's not a biggie.
> 
> Which code are you referring to?

mlxsw_sp_port_vlan_set

> For the switchdev and mlxsw parts:
> 
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> 
> I applied the series to our queue, so I should have regression results
> tomorrow

Thanks. Could you wait for me to send a v3 though, with that small fixup
in mv88e6xxx? I'm sure it will raise some red flags for your testing too.