From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,HK_RANDOM_FROM, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14534C433DB for ; Thu, 7 Jan 2021 05:56:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 568B222E00 for ; Thu, 7 Jan 2021 05:56:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 568B222E00 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bu.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxOHH-0003Dd-Ks for qemu-devel@archiver.kernel.org; Thu, 07 Jan 2021 00:56:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxOG4-0002Qp-Cu for qemu-devel@nongnu.org; Thu, 07 Jan 2021 00:54:52 -0500 Received: from relay68.bu.edu ([128.197.228.73]:33014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxOG2-0007Nf-I4 for qemu-devel@nongnu.org; Thu, 07 Jan 2021 00:54:51 -0500 X-Envelope-From: alxndr@bu.edu X-BU-AUTH: mozz.bu.edu [128.197.127.33] Received: from BU-AUTH (localhost.localdomain [127.0.0.1]) (authenticated bits=0) by relay68.bu.edu (8.14.3/8.14.3) with ESMTP id 1075s8nW010641 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Thu, 7 Jan 2021 00:54:11 -0500 Date: Thu, 7 Jan 2021 00:54:08 -0500 From: Alexander Bulekov To: Qiuhao Li Subject: Re: [PATCH v4 6/7] fuzz: add minimization options Message-ID: <20210107055408.dj2fdn6rpjeucedn@mozz.bu.edu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=128.197.228.73; envelope-from=alxndr@bu.edu; helo=relay68.bu.edu X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, qemu-devel@nongnu.org, darren.kenny@oracle.com, bsd@redhat.com, stefanha@redhat.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 201229 1240, Qiuhao Li wrote: > -M1: loop around the remove minimizer > -M2: try setting bits in operand of write/out to zero > Signed-off-by: Qiuhao Li Reviewed-by: Alexander Bulekov > --- > scripts/oss-fuzz/minimize_qtest_trace.py | 32 +++++++++++++++++++----- > 1 file changed, 26 insertions(+), 6 deletions(-) > > diff --git a/scripts/oss-fuzz/minimize_qtest_trace.py b/scripts/oss-fuzz/minimize_qtest_trace.py > index 70ac0c5366..a681984076 100755 > --- a/scripts/oss-fuzz/minimize_qtest_trace.py > +++ b/scripts/oss-fuzz/minimize_qtest_trace.py > @@ -16,6 +16,10 @@ QEMU_PATH = None > TIMEOUT = 5 > CRASH_TOKEN = None > > +# Minimization levels > +M1 = False # loop around the remove minimizer > +M2 = False # try setting bits in operand of write/out to zero > + > write_suffix_lookup = {"b": (1, "B"), > "w": (2, "H"), > "l": (4, "L"), > @@ -23,10 +27,20 @@ write_suffix_lookup = {"b": (1, "B"), > > def usage(): > sys.exit("""\ > -Usage: QEMU_PATH="/path/to/qemu" QEMU_ARGS="args" {} input_trace output_trace > +Usage: > + > +QEMU_PATH="/path/to/qemu" QEMU_ARGS="args" {} [Options] input_trace output_trace > + > By default, will try to use the second-to-last line in the output to identify > whether the crash occred. Optionally, manually set a string that idenitifes the > crash by setting CRASH_TOKEN= > + > +Options: > + > +-M1: enable a loop around the remove minimizer, which may help decrease some > + timing dependant instructions. Off by default. > +-M2: try setting bits in operand of write/out to zero. Off by default. > + > """.format((sys.argv[0]))) > > deduplication_note = """\n\ > @@ -213,24 +227,30 @@ def minimize_trace(inpath, outpath): > print("Setting the timeout for {} seconds".format(TIMEOUT)) > > newtrace = trace[:] > - > + global M1, M2 > # remove minimizer > old_len = len(newtrace) + 1 > while(old_len > len(newtrace)): > old_len = len(newtrace) > + print("trace lenth = ", old_len) > remove_minimizer(newtrace, outpath) > + if not M1 and not M2: > + break > newtrace = list(filter(lambda s: s != "", newtrace)) > assert(check_if_trace_crashes(newtrace, outpath)) > > - # set zero minimizer > - set_zero_minimizer(newtrace, outpath) > + if M2: > + set_zero_minimizer(newtrace, outpath) > assert(check_if_trace_crashes(newtrace, outpath)) > > > if __name__ == '__main__': > if len(sys.argv) < 3: > usage() > - > + if "-M1" in sys.argv: > + M1 = True > + if "-M2" in sys.argv: > + M2 = True > QEMU_PATH = os.getenv("QEMU_PATH") > QEMU_ARGS = os.getenv("QEMU_ARGS") > if QEMU_PATH is None or QEMU_ARGS is None: > @@ -239,4 +259,4 @@ if __name__ == '__main__': > # QEMU_ARGS += " -accel qtest" > CRASH_TOKEN = os.getenv("CRASH_TOKEN") > QEMU_ARGS += " -qtest stdio -monitor none -serial none " > - minimize_trace(sys.argv[1], sys.argv[2]) > + minimize_trace(sys.argv[-2], sys.argv[-1]) > -- > 2.25.1 >