From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B31F2C433E6 for ; Thu, 7 Jan 2021 17:14:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A35E233FD for ; Thu, 7 Jan 2021 17:14:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728123AbhAGROe (ORCPT ); Thu, 7 Jan 2021 12:14:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:52534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727673AbhAGROd (ORCPT ); Thu, 7 Jan 2021 12:14:33 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 371D222C9F; Thu, 7 Jan 2021 17:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610039633; bh=ZVeD39col6jONCCqdvgtIVCmR0m41a3iw2QJUE5Geso=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P3EsmxxZDZh+F/f5tlaofaJqMd5SBB6Zzx4Df/sO7K6IHNHmcW8nV6biybCNuPije phTg+dzw1zVcV5q/coL0nQTMcPoiAqBamR8K80XNlXKtYVPLkDsCki0KvVKrv2JcUw vV2G0R5N/lHvKIqiJdB8otQbbpRiDK8uOXnGtZ5I/1P1iPsUoZMxJqUpUjJ+IsUEtP iCGswzpdvUle21jW7H1NM1sJEf2egDy7U67pJfRlnRmgrkumx93nobtiruHy9g4QMx Lu5cn2+Yr8MO7qpOXgRe82PONDK1FmXrIQLxsv9+OLdkAyCbrXamQ5tzAfBTh3bHIh Wna+832kPIoSQ== Date: Thu, 7 Jan 2021 09:13:52 -0800 From: Jakub Kicinski To: Guillaume Nault Cc: Stephen Hemminger , netdev@vger.kernel.org, David Ahern Subject: Re: [PATCH iproute2] tc: flower: fix json output with mpls lse Message-ID: <20210107091352.610abd6f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210107164856.GC17363@linux.home> References: <1ef12e7d378d5b1dad4f056a2225d5ae9d5326cb.1608330201.git.gnault@redhat.com> <20210107164856.GC17363@linux.home> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 7 Jan 2021 17:48:56 +0100 Guillaume Nault wrote: > On Fri, Dec 18, 2020 at 11:25:32PM +0100, Guillaume Nault wrote: > > The json output of the TCA_FLOWER_KEY_MPLS_OPTS attribute was invalid. > > > > Example: > > > > $ tc filter add dev eth0 ingress protocol mpls_uc flower mpls \ > > lse depth 1 label 100 \ > > lse depth 2 label 200 > > > > $ tc -json filter show dev eth0 ingress > > ...{"eth_type":"8847", > > " mpls":[" lse":["depth":1,"label":100], > > " lse":["depth":2,"label":200]]}... > > Is there any problem with this patch? > It's archived in patchwork, but still in state "new". Therefore I guess > it was dropped before being considered for review. Erm, that's weird. I think Alexei mentioned that auto-archiving is turned on in the new netdevbpf patchwork instance. My guess is it got auto archived :S Here is the list of all patches that are Archived as New: https://patchwork.kernel.org/project/netdevbpf/list/?state=1&archive=true Should any of these have been reviewed?