From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3358C433E6 for ; Thu, 7 Jan 2021 10:41:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E9EE23142 for ; Thu, 7 Jan 2021 10:41:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727626AbhAGKln (ORCPT ); Thu, 7 Jan 2021 05:41:43 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:41557 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbhAGKlm (ORCPT ); Thu, 7 Jan 2021 05:41:42 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id CEABE581EFE; Thu, 7 Jan 2021 05:40:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 07 Jan 2021 05:40:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=MCmIJt q4hRR5BVUY23nJFlJG797H219UllbajszlMjo=; b=q7lzUZqvR+v/PvaF+uFvf4 kuUzh/xo1FMiAFE1/edjuF3FGGLqAlbnUdY2TVNEK9Ha3A+29Bw3I+kvG2ELZHhV 6d3m1JOo6lp3e20mTT4kYjwkEO/Gcv2daNJ/Z0ZjmJ7UsiqEmyy+Ab3eWY0W0oRr acIHHTR3gbDIbArlv/bqO+/l+m1ozZq/c7Myt+UMAFjs9ev2iTtTHXx2sOOkwuSl 5VKazR1Yi7Pp/OWVYgbTIO1cU6llL8yy0g5qbQqPCr/NbjA1GAodt28hN0bp2xBu g4VbVXFxmcXhGxu2iZkBMXs3l8VR/aqD2raPkm5Pj69BCwQgcp+YmmTTyvSfdurg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdegvddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedtffekkeefudffveegueejffejhfetgfeuuefgvedtieehudeuueekhfduheel teenucfkphepkeegrddvvdelrdduheefrdeggeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: from localhost (igld-84-229-153-44.inter.net.il [84.229.153.44]) by mail.messagingengine.com (Postfix) with ESMTPA id DD9401080057; Thu, 7 Jan 2021 05:40:50 -0500 (EST) Date: Thu, 7 Jan 2021 12:40:48 +0200 From: Ido Schimmel To: Vladimir Oltean , petrm@nvidia.com Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , Microchip Linux Driver Support , Sean Wang , Landen Chao , Claudiu Manoil , Alexandre Belloni , Linus Walleij , Vadym Kochan , Taras Chornyi , Jiri Pirko , Ido Schimmel , Grygorii Strashko , Ioana Ciornei , Ivan Vecera Subject: Re: [PATCH v3 net-next 03/11] net: switchdev: remove the transaction structure from port object notifiers Message-ID: <20210107104048.GB1102653@shredder.lan> References: <20210106231728.1363126-1-olteanv@gmail.com> <20210106231728.1363126-4-olteanv@gmail.com> <20210107103835.GA1102653@shredder.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210107103835.GA1102653@shredder.lan> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Forgot to actually add Petr On Thu, Jan 07, 2021 at 12:38:39PM +0200, Ido Schimmel wrote: > +Petr > > On Thu, Jan 07, 2021 at 01:17:20AM +0200, Vladimir Oltean wrote: > > static int mlxsw_sp_port_obj_add(struct net_device *dev, > > const struct switchdev_obj *obj, > > - struct switchdev_trans *trans, > > struct netlink_ext_ack *extack) > > { > > struct mlxsw_sp_port *mlxsw_sp_port = netdev_priv(dev); > > const struct switchdev_obj_port_vlan *vlan; > > + struct switchdev_trans trans; > > int err = 0; > > > > switch (obj->id) { > > case SWITCHDEV_OBJ_ID_PORT_VLAN: > > vlan = SWITCHDEV_OBJ_PORT_VLAN(obj); > > - err = mlxsw_sp_port_vlans_add(mlxsw_sp_port, vlan, trans, > > + > > Got the regression results. The call to mlxsw_sp_span_respin() should be > placed here because it needs to be triggered regardless of the return > value of mlxsw_sp_port_vlans_add(). > > I'm looking into another failure, which might not be related to these > patches. I will also have results with a debug kernel tomorrow (takes > almost a day to complete). Will let you know. > > > + trans.ph_prepare = true; > > + err = mlxsw_sp_port_vlans_add(mlxsw_sp_port, vlan, &trans, > > extack); > > + if (err) > > + break; > > > > - if (switchdev_trans_ph_prepare(trans)) { > > - /* The event is emitted before the changes are actually > > - * applied to the bridge. Therefore schedule the respin > > - * call for later, so that the respin logic sees the > > - * updated bridge state. > > - */ > > - mlxsw_sp_span_respin(mlxsw_sp_port->mlxsw_sp); > > - } > > + /* The event is emitted before the changes are actually > > + * applied to the bridge. Therefore schedule the respin > > + * call for later, so that the respin logic sees the > > + * updated bridge state. > > + */ > > + mlxsw_sp_span_respin(mlxsw_sp_port->mlxsw_sp); > > + > > + trans.ph_prepare = false; > > + err = mlxsw_sp_port_vlans_add(mlxsw_sp_port, vlan, &trans, > > + extack); > > break; > > case SWITCHDEV_OBJ_ID_PORT_MDB: > > err = mlxsw_sp_port_mdb_add(mlxsw_sp_port, > > - SWITCHDEV_OBJ_PORT_MDB(obj), > > - trans); > > + SWITCHDEV_OBJ_PORT_MDB(obj)); > > break; > > default: > > err = -EOPNOTSUPP;