All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: arnd@arndb.de, elver@google.com, georgepope@android.com,
	mm-commits@vger.kernel.org, natechancellor@gmail.com,
	ndesaulniers@google.com, sfr@canb.auug.org.au
Subject: Re: [folded-merged] ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix.patch removed from -mm tree
Date: Thu, 7 Jan 2021 15:06:37 -0800	[thread overview]
Message-ID: <20210107150637.e95a8c6173a7febeb02564cd@linux-foundation.org> (raw)
In-Reply-To: <202101071308.8854B1428B@keescook>

On Thu, 7 Jan 2021 13:09:29 -0800 Kees Cook <keescook@chromium.org> wrote:

> > --- a/lib/Kconfig.ubsan~ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix
> > +++ a/lib/Kconfig.ubsan
> > @@ -122,7 +122,7 @@ config UBSAN_SIGNED_OVERFLOW
> >  
> >  config UBSAN_UNSIGNED_OVERFLOW
> >  	bool "Perform checking for unsigned arithmetic overflow"
> > -	# clang hugely expands stack usage with -fsanitize=object-size
> > +	# clang hugely expands stack usage with -fsanitize=unsigned-integer-overflow
> >  	depends on !CC_IS_CLANG
> 
> The above "!CC_IS_CLANG" needs to be dropped. I makes it impossible to use at
> all (unsigned UBSAN overflow is only implemented for Clang).

It isn't clear to me that this patch remains valid anyway - I'll drop
it.


  reply	other threads:[~2021-01-07 23:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07  0:34 [folded-merged] ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix.patch removed from -mm tree akpm
2021-01-07 21:09 ` Kees Cook
2021-01-07 23:06   ` Andrew Morton [this message]
2021-01-08  3:56     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107150637.e95a8c6173a7febeb02564cd@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=elver@google.com \
    --cc=georgepope@android.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=natechancellor@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.