From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F51C433E0 for ; Thu, 7 Jan 2021 16:45:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5370D23403 for ; Thu, 7 Jan 2021 16:45:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728413AbhAGQpH (ORCPT ); Thu, 7 Jan 2021 11:45:07 -0500 Received: from mx2.suse.de ([195.135.220.15]:35346 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726294AbhAGQpG (ORCPT ); Thu, 7 Jan 2021 11:45:06 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1610037859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wSvk/N4VsMaZmRt/5EtC0lSsod9zly1e3L1YQgG9tsU=; b=CHWH7qAy13X86IPtbS3dAIJCL0GjcydL626E4T0HnkuK4vD19rHyhc5LHWICFUKdpV5sp9 mxoO3UPtyRo4Le2VDlVE8TwZW+wIPi/bD2Z3qvhtzEHVHEWbhsDmG6sL3WOWSH8zPzrOwi /u3LZKf2l9BI3IJpZKtUhDMgiAl4BgI= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4D4C6B771; Thu, 7 Jan 2021 16:44:19 +0000 (UTC) From: Petr Mladek To: Sergey Senozhatsky , Steven Rostedt , John Ogness Cc: Linus Torvalds , Guenter Roeck , Shreyas Joshi , shreyasjoshi15@gmail.com, Greg Kroah-Hartman , Sergey Senozhatsky , Greg Ungerer , Vineet Gupta , Thomas Meyer , David Gow , Brendan Higgins , Andy Shevchenko , Shuah Khan , linux-kernel@vger.kernel.org, Petr Mladek Subject: [PATCH 0/1] console: Blank console - userspace regression Date: Thu, 7 Jan 2021 17:43:59 +0100 Message-Id: <20210107164400.17904-1-pmladek@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The commit 757055ae8dedf5333af17b3b ("init/console: Use ttynull as a fallback when there is no console") caused several regressions. The ttynull console has been selected by default when no console was configured on the command line and ttynull_init() was the first initcall calling register_console(). There were few possible workarounds but I was not happy with them. I worked on a proper solution but it became too complicated to be used at this stage. The console registration code is a sad story. There are many hidden catches. The ordering of registered consoles is not well defined. Any change in the code tends to break some particular system. The good news is that I become more and more familiar with it. I hope that I will be able to clean it up step by step in the future. But it is definitely not a good idea to do any big refactoring in rc phase. Hence I propose to revert the problematic commit as the least risky solution. Petr Mladek (1): Revert "init/console: Use ttynull as a fallback when there is no console" drivers/tty/Kconfig | 14 ++++++++++++++ drivers/tty/Makefile | 3 ++- drivers/tty/ttynull.c | 18 ------------------ include/linux/console.h | 3 --- init/main.c | 10 ++-------- 5 files changed, 18 insertions(+), 30 deletions(-) -- 2.26.2