From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E16BDC433E0 for ; Thu, 7 Jan 2021 22:29:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DF20235FD for ; Thu, 7 Jan 2021 22:29:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728697AbhAGW3Y (ORCPT ); Thu, 7 Jan 2021 17:29:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728423AbhAGW3X (ORCPT ); Thu, 7 Jan 2021 17:29:23 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B82F4C0612FC for ; Thu, 7 Jan 2021 14:28:26 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id e25so6859531wme.0 for ; Thu, 07 Jan 2021 14:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fdYSuYQvqNKVpq92aM/7Wd5ow52H+eR0/gXxomb4sjQ=; b=p1pIzZixnJJdVf3tNQtie+BS/J9X6mCCyj5oom4aY6rxUcdFR87nVvnNZxj3/d6AO5 +sNJy7DbIn38NuGPBAawa3G83YzTRF8eR4XWGg3sdoEkaGhKStegzMKZf27WgeVyAA/w X+Esuf7b+chUIP8OTLp6wNCNuQhZIFgggjlH5mSgYwQpAG8r8DGTnoiulIDD2EsNYkcy WMD2VK/d4+AfT417dztTwV9dZIFxX1guExgmLZrKXKQBbzAhmuVA1UPH35tM1rPdyno1 +zSDdxO8II4oA8Jswe7FjtDcjPzY1uNyYVTnYsSEFF7Zqecnu1rPlgF1lQFwjb6VaapS zNRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=fdYSuYQvqNKVpq92aM/7Wd5ow52H+eR0/gXxomb4sjQ=; b=XPHrbS4rRoASc8z9WIZB/+z3lL+M3Slzntyp/eVgEfHpp15QrW0aA+4fbCONfHuMeg vi2O48riu/LUccDU5GsXDW+HRbIesTRjPTI+sNbTsPawD3ZS4HmmcxPsk+kzKHtgNRJi BbQNqYnaj4WIeHMUvTlzCXJN/CXYsAN+vI1MkLtZf9d1/jyZc8VT2JiDkzgdfXM+tnTQ cbGunnbg8wVJIz08/Fey0S7qCRNzgW9pGVFAhEFJJ6cn8ly1PUlSgUL6SCGF+2X1nUL6 6GudaPqXU/0emGQ4zmbK5uAqoSz+EzqGHw0fqztnZliCUYaQB0cSm6FjBK+Y9kC0cwJ9 H+kQ== X-Gm-Message-State: AOAM530s6NkqOlh7S/StVQdS8puLJY5b7TdoEpW/NlX4Si/ds1tEHF8X DbNR/iIbWfp6zAw7X5UiGrc= X-Google-Smtp-Source: ABdhPJws5xak3FcT1HkGs0Ly6rut//3AP/lYHP4MA74T0CtSIKncybZuO1pBYPc0CUfac9oScLTv7A== X-Received: by 2002:a1c:e90b:: with SMTP id q11mr537869wmc.102.1610058505516; Thu, 07 Jan 2021 14:28:25 -0800 (PST) Received: from x1w.redhat.com (241.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.241]) by smtp.gmail.com with ESMTPSA id v20sm11076739wra.19.2021.01.07.14.28.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 14:28:24 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Paolo Bonzini , Laurent Vivier , kvm@vger.kernel.org, Jiaxun Yang , Aurelien Jarno , Huacai Chen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Paul Burton , Richard Henderson Subject: [PULL 64/66] target/mips: Convert Rel6 LLD/SCD opcodes to decodetree Date: Thu, 7 Jan 2021 23:22:51 +0100 Message-Id: <20210107222253.20382-65-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210107222253.20382-1-f4bug@amsat.org> References: <20210107222253.20382-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org LLD/SCD opcodes have been removed from the Release 6. Add a single decodetree entry for the opcodes, triggering Reserved Instruction if ever used. Remove unreachable check_insn_opc_removed() calls. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201208203704.243704-13-f4bug@amsat.org> --- target/mips/mips64r6.decode | 3 +++ target/mips/translate.c | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target/mips/mips64r6.decode b/target/mips/mips64r6.decode index 8c3fc5dae9c..609b8958d25 100644 --- a/target/mips/mips64r6.decode +++ b/target/mips/mips64r6.decode @@ -21,3 +21,6 @@ REMOVED 011010 ----- ----- ---------------- # LDL REMOVED 011011 ----- ----- ---------------- # LDR REMOVED 101100 ----- ----- ---------------- # SDL REMOVED 101101 ----- ----- ---------------- # SDR + +REMOVED 110100 ----- ----- ---------------- # LLD +REMOVED 111100 ----- ----- ---------------- # SCD diff --git a/target/mips/translate.c b/target/mips/translate.c index f46d7c5f80b..9f717aab287 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -28871,7 +28871,6 @@ static bool decode_opc_legacy(CPUMIPSState *env, DisasContext *ctx) if (ctx->insn_flags & INSN_R5900) { check_insn_opc_user_only(ctx, INSN_R5900); } - check_insn_opc_removed(ctx, ISA_MIPS_R6); /* fall through */ case OPC_LDL: case OPC_LDR: @@ -28889,7 +28888,6 @@ static bool decode_opc_legacy(CPUMIPSState *env, DisasContext *ctx) gen_st(ctx, op, rt, rs, imm); break; case OPC_SCD: - check_insn_opc_removed(ctx, ISA_MIPS_R6); check_insn(ctx, ISA_MIPS3); if (ctx->insn_flags & INSN_R5900) { check_insn_opc_user_only(ctx, INSN_R5900); -- 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C1C8C433DB for ; Thu, 7 Jan 2021 23:10:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18863235FF for ; Thu, 7 Jan 2021 23:10:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18863235FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxeQj-0005RP-9k for qemu-devel@archiver.kernel.org; Thu, 07 Jan 2021 18:10:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxdlc-0005iG-IM for qemu-devel@nongnu.org; Thu, 07 Jan 2021 17:28:28 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:37601) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxdlb-0006fk-0y for qemu-devel@nongnu.org; Thu, 07 Jan 2021 17:28:28 -0500 Received: by mail-wm1-x32e.google.com with SMTP id q75so6844980wme.2 for ; Thu, 07 Jan 2021 14:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fdYSuYQvqNKVpq92aM/7Wd5ow52H+eR0/gXxomb4sjQ=; b=p1pIzZixnJJdVf3tNQtie+BS/J9X6mCCyj5oom4aY6rxUcdFR87nVvnNZxj3/d6AO5 +sNJy7DbIn38NuGPBAawa3G83YzTRF8eR4XWGg3sdoEkaGhKStegzMKZf27WgeVyAA/w X+Esuf7b+chUIP8OTLp6wNCNuQhZIFgggjlH5mSgYwQpAG8r8DGTnoiulIDD2EsNYkcy WMD2VK/d4+AfT417dztTwV9dZIFxX1guExgmLZrKXKQBbzAhmuVA1UPH35tM1rPdyno1 +zSDdxO8II4oA8Jswe7FjtDcjPzY1uNyYVTnYsSEFF7Zqecnu1rPlgF1lQFwjb6VaapS zNRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=fdYSuYQvqNKVpq92aM/7Wd5ow52H+eR0/gXxomb4sjQ=; b=h5ulNERzY8Egd+AYIx6xZpb6WcdQPNJ4gDCZKDxR0GlJDQkBo4Ug6/EuG+HNC66F4W NZExhMFGalcjoBhHW3ig29B0iw1yrZvdNsaRk0Ca4EzA4s9JvbVs40iyyPHjObhMgtx3 erdtQM2uTIog8tDPB12/C1M09/Dzp0eIQ+4MO/iDKHaRe4Tzyy12naTJxR7LOxvOu25Y 5EQbGkjNu3aHZ4x5/P62N+mbzNnMBXFqdqc1+178Mm+fWXr94l0hxlsLJKNFFReFknH+ oQE49RsvkafL/D6DwjT4hlZ8CsQSQyeV5h/tkVAqO3qv+B7xEiCWgjGw9E4yRUuvxRpx qr0Q== X-Gm-Message-State: AOAM531tPmZP8lZFCxFvp1vPkRzwnrbdBSptnCY+lN53dx3VA1VHR1Uo 5tZyOvszNsnL10tX1N9UJhR7UfBASWU= X-Google-Smtp-Source: ABdhPJws5xak3FcT1HkGs0Ly6rut//3AP/lYHP4MA74T0CtSIKncybZuO1pBYPc0CUfac9oScLTv7A== X-Received: by 2002:a1c:e90b:: with SMTP id q11mr537869wmc.102.1610058505516; Thu, 07 Jan 2021 14:28:25 -0800 (PST) Received: from x1w.redhat.com (241.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.241]) by smtp.gmail.com with ESMTPSA id v20sm11076739wra.19.2021.01.07.14.28.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 14:28:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 64/66] target/mips: Convert Rel6 LLD/SCD opcodes to decodetree Date: Thu, 7 Jan 2021 23:22:51 +0100 Message-Id: <20210107222253.20382-65-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210107222253.20382-1-f4bug@amsat.org> References: <20210107222253.20382-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Paul Burton , kvm@vger.kernel.org, libvir-list@redhat.com, Huacai Chen , Richard Henderson , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" LLD/SCD opcodes have been removed from the Release 6. Add a single decodetree entry for the opcodes, triggering Reserved Instruction if ever used. Remove unreachable check_insn_opc_removed() calls. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20201208203704.243704-13-f4bug@amsat.org> --- target/mips/mips64r6.decode | 3 +++ target/mips/translate.c | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target/mips/mips64r6.decode b/target/mips/mips64r6.decode index 8c3fc5dae9c..609b8958d25 100644 --- a/target/mips/mips64r6.decode +++ b/target/mips/mips64r6.decode @@ -21,3 +21,6 @@ REMOVED 011010 ----- ----- ---------------- # LDL REMOVED 011011 ----- ----- ---------------- # LDR REMOVED 101100 ----- ----- ---------------- # SDL REMOVED 101101 ----- ----- ---------------- # SDR + +REMOVED 110100 ----- ----- ---------------- # LLD +REMOVED 111100 ----- ----- ---------------- # SCD diff --git a/target/mips/translate.c b/target/mips/translate.c index f46d7c5f80b..9f717aab287 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -28871,7 +28871,6 @@ static bool decode_opc_legacy(CPUMIPSState *env, DisasContext *ctx) if (ctx->insn_flags & INSN_R5900) { check_insn_opc_user_only(ctx, INSN_R5900); } - check_insn_opc_removed(ctx, ISA_MIPS_R6); /* fall through */ case OPC_LDL: case OPC_LDR: @@ -28889,7 +28888,6 @@ static bool decode_opc_legacy(CPUMIPSState *env, DisasContext *ctx) gen_st(ctx, op, rt, rs, imm); break; case OPC_SCD: - check_insn_opc_removed(ctx, ISA_MIPS_R6); check_insn(ctx, ISA_MIPS3); if (ctx->insn_flags & INSN_R5900) { check_insn_opc_user_only(ctx, INSN_R5900); -- 2.26.2