From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC050C433E0 for ; Fri, 8 Jan 2021 04:44:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A6F322DBF for ; Fri, 8 Jan 2021 04:44:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727569AbhAHEnz (ORCPT ); Thu, 7 Jan 2021 23:43:55 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:40388 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbhAHEnz (ORCPT ); Thu, 7 Jan 2021 23:43:55 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kxjcB-0006jz-BN; Fri, 08 Jan 2021 15:43:08 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 08 Jan 2021 15:43:07 +1100 Date: Fri, 8 Jan 2021 15:43:07 +1100 From: Herbert Xu To: Arnd Bergmann Cc: "David S. Miller" , Tero Kristo , Arnd Bergmann , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: omap-sham - Fix link error without crypto-engine Message-ID: <20210108044307.GD12339@gondor.apana.org.au> References: <20210103140318.3902174-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210103140318.3902174-1-arnd@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Jan 03, 2021 at 03:03:04PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The driver was converted to use the crypto engine helper > but is missing the corresponding Kconfig statement to ensure > it is available: > > arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_probe': > omap-sham.c:(.text+0x374): undefined reference to `crypto_engine_alloc_init' > arm-linux-gnueabi-ld: omap-sham.c:(.text+0x384): undefined reference to `crypto_engine_start' > arm-linux-gnueabi-ld: omap-sham.c:(.text+0x510): undefined reference to `crypto_engine_exit' > arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_finish_req': > omap-sham.c:(.text+0x98c): undefined reference to `crypto_finalize_hash_request' > arm-linux-gnueabi-ld: omap-sham.c:(.text+0x9a0): undefined reference to `crypto_transfer_hash_request_to_engine' > arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_update': > omap-sham.c:(.text+0xf24): undefined reference to `crypto_transfer_hash_request_to_engine' > arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_final': > omap-sham.c:(.text+0x1020): undefined reference to `crypto_transfer_hash_request_to_engine' > > Fixes: 133c3d434d91 ("crypto: omap-sham - convert to use crypto engine") > Signed-off-by: Arnd Bergmann > --- > drivers/crypto/Kconfig | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt