All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/4] pinctrl: intel: Split intel_pinctrl_add_padgroups() for better maintenance
Date: Fri, 8 Jan 2021 09:07:55 +0200	[thread overview]
Message-ID: <20210108070755.GY968855@lahna.fi.intel.com> (raw)
In-Reply-To: <20210107190200.41221-1-andriy.shevchenko@linux.intel.com>

On Thu, Jan 07, 2021 at 09:01:57PM +0200, Andy Shevchenko wrote:
> Currently the intel_pinctrl_add_padgroups() is twisted a bit due to
> a different nature of the pin control hardware implementations. Thus,
> its maintenance is a bit hard. Besides that some pieces of code
> are run on all hardware and make this code slightly inefficient,
> and moreover, validation for one case is done in a wrong time in a flow
> which makes it even slower.
> 
> Split intel_pinctrl_add_padgroups() to two functions, one per hardware
> implementation, for better maintenance and readability.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

      parent reply	other threads:[~2021-01-08  7:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 19:01 [PATCH v1 1/4] pinctrl: intel: Split intel_pinctrl_add_padgroups() for better maintenance Andy Shevchenko
2021-01-07 19:01 ` [PATCH v1 2/4] pinctrl: intel: Drop unnecessary check for predefined features Andy Shevchenko
2021-01-08  7:08   ` Mika Westerberg
2021-01-07 19:01 ` [PATCH v1 3/4] pinctrl: intel: Convert revision conditional to switch-case Andy Shevchenko
2021-01-08  7:05   ` Mika Westerberg
2021-01-07 19:02 ` [PATCH v1 4/4] pinctrl: intel: Convert capability list to features Andy Shevchenko
2021-01-08  7:07   ` Mika Westerberg
2021-01-08 12:22     ` Andy Shevchenko
2021-01-08 12:31       ` Andy Shevchenko
2021-01-08 12:46         ` Mika Westerberg
2021-01-08 12:51           ` Andy Shevchenko
2021-01-08 13:11             ` Mika Westerberg
2021-01-08 13:45               ` Andy Shevchenko
2021-01-08  7:07 ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210108070755.GY968855@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.