From: Will Deacon <will@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnd Bergmann <arnd@kernel.org>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
linux-toolchains@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Theodore Ts'o <tytso@mit.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues
Date: Fri, 8 Jan 2021 09:26:56 +0000 [thread overview]
Message-ID: <20210108092655.GA4031@willie-the-truck> (raw)
In-Reply-To: <X/gkMmObbkI4+ip/@hirez.programming.kicks-ass.net>
On Fri, Jan 08, 2021 at 10:21:54AM +0100, Peter Zijlstra wrote:
> On Thu, Jan 07, 2021 at 10:20:38PM +0100, Arnd Bergmann wrote:
> > On Thu, Jan 7, 2021 at 2:37 PM Russell King - ARM Linux admin
>
> > > So, do we raise the minimum gcc version for the kernel as a whole to 5.1
> > > or just for aarch64?
> >
> > I'd personally love to see gcc-5 as the global minimum version, as that
> > would let us finally use --std=gnu11 features instead of gnu89. [There are
> > a couple of useful features that are incompatible with gnu89, and
> > gnu99/gnu11 support in gcc didn't like the kernel sources]
>
> +1 for raising the tree-wide minimum (again!). We actually have a bunch
> of work-arounds for 4.9 bugs we can get rid of as well.
We even just added another one for arm64 KVM! [1]
So yes, I'm in favour of leaving gcc 4.9 to rot as well, especially after
this ext4 debugging experience.
Will
[1] https://git.kernel.org/linus/9fd339a45be5
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-toolchains@vger.kernel.org,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues
Date: Fri, 8 Jan 2021 09:26:56 +0000 [thread overview]
Message-ID: <20210108092655.GA4031@willie-the-truck> (raw)
In-Reply-To: <X/gkMmObbkI4+ip/@hirez.programming.kicks-ass.net>
On Fri, Jan 08, 2021 at 10:21:54AM +0100, Peter Zijlstra wrote:
> On Thu, Jan 07, 2021 at 10:20:38PM +0100, Arnd Bergmann wrote:
> > On Thu, Jan 7, 2021 at 2:37 PM Russell King - ARM Linux admin
>
> > > So, do we raise the minimum gcc version for the kernel as a whole to 5.1
> > > or just for aarch64?
> >
> > I'd personally love to see gcc-5 as the global minimum version, as that
> > would let us finally use --std=gnu11 features instead of gnu89. [There are
> > a couple of useful features that are incompatible with gnu89, and
> > gnu99/gnu11 support in gcc didn't like the kernel sources]
>
> +1 for raising the tree-wide minimum (again!). We actually have a bunch
> of work-arounds for 4.9 bugs we can get rid of as well.
We even just added another one for arm64 KVM! [1]
So yes, I'm in favour of leaving gcc 4.9 to rot as well, especially after
this ext4 debugging experience.
Will
[1] https://git.kernel.org/linus/9fd339a45be5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-08 9:27 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 15:47 Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Russell King - ARM Linux admin
2021-01-05 15:47 ` Russell King - ARM Linux admin
2021-01-05 18:27 ` Darrick J. Wong
2021-01-05 18:27 ` Darrick J. Wong
2021-01-05 19:50 ` Russell King - ARM Linux admin
2021-01-05 19:50 ` Russell King - ARM Linux admin
2021-01-06 11:53 ` Mark Rutland
2021-01-06 11:53 ` Mark Rutland
2021-01-06 12:13 ` Russell King - ARM Linux admin
2021-01-06 12:13 ` Russell King - ARM Linux admin
2021-01-06 13:52 ` Russell King - ARM Linux admin
2021-01-06 17:20 ` Will Deacon
2021-01-06 17:20 ` Will Deacon
2021-01-06 17:46 ` Russell King - ARM Linux admin
2021-01-06 17:46 ` Russell King - ARM Linux admin
2021-01-06 21:04 ` Arnd Bergmann
2021-01-06 21:04 ` Arnd Bergmann
2021-01-06 22:00 ` Arnd Bergmann
2021-01-06 22:00 ` Arnd Bergmann
2021-01-06 22:32 ` Russell King - ARM Linux admin
2021-01-06 22:32 ` Russell King - ARM Linux admin
2021-01-07 11:18 ` Russell King - ARM Linux admin
2021-01-07 11:18 ` Russell King - ARM Linux admin
2021-01-07 12:45 ` Russell King - ARM Linux admin
2021-01-07 12:45 ` Russell King - ARM Linux admin
2021-01-07 13:16 ` Arnd Bergmann
2021-01-07 13:16 ` Arnd Bergmann
2021-01-07 13:37 ` Russell King - ARM Linux admin
2021-01-07 13:37 ` Russell King - ARM Linux admin
2021-01-07 16:27 ` Theodore Ts'o
2021-01-07 16:27 ` Theodore Ts'o
2021-01-07 17:00 ` Florian Weimer
2021-01-07 17:00 ` Florian Weimer
2021-01-07 21:48 ` Arnd Bergmann
2021-01-07 21:48 ` Arnd Bergmann
2021-01-07 22:14 ` Russell King - ARM Linux admin
2021-01-07 22:14 ` Russell King - ARM Linux admin
2021-01-07 22:41 ` Eric Biggers
2021-01-07 22:41 ` Eric Biggers
2021-01-08 8:21 ` Ard Biesheuvel
2021-01-08 8:21 ` Ard Biesheuvel
2021-01-07 22:27 ` Eric Biggers
2021-01-07 22:27 ` Eric Biggers
2021-01-07 23:53 ` Darrick J. Wong
2021-01-07 23:53 ` Darrick J. Wong
2021-01-08 8:05 ` Arnd Bergmann
2021-01-08 8:05 ` Arnd Bergmann
2021-01-08 9:13 ` Peter Zijlstra
2021-01-08 9:13 ` Peter Zijlstra
2021-01-08 10:31 ` Pavel Machek
2021-01-08 10:31 ` Pavel Machek
2021-01-07 21:20 ` Arnd Bergmann
2021-01-07 21:20 ` Arnd Bergmann
2021-01-08 9:21 ` Peter Zijlstra
2021-01-08 9:21 ` Peter Zijlstra
2021-01-08 9:26 ` Will Deacon [this message]
2021-01-08 9:26 ` Will Deacon
2021-01-08 20:02 ` Linus Torvalds
2021-01-08 20:02 ` Linus Torvalds
2021-01-08 20:22 ` Arnd Bergmann
2021-01-08 20:22 ` Arnd Bergmann
2021-01-08 21:20 ` Nick Desaulniers
2021-01-08 21:20 ` Nick Desaulniers
2021-01-08 20:29 ` Russell King - ARM Linux admin
2021-01-08 20:29 ` Russell King - ARM Linux admin
2021-01-12 13:20 ` Lukas Wunner
2021-01-12 13:31 ` Florian Weimer
2021-01-12 13:31 ` Florian Weimer
2021-01-12 13:46 ` David Laight
2021-01-12 13:46 ` David Laight
2021-01-12 17:28 ` Linus Torvalds
2021-01-12 17:28 ` Linus Torvalds
2021-01-14 13:13 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108092655.GA4031@willie-the-truck \
--to=will@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=arnd@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.