All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Maxime Ripard <mripard@kernel.org>,
	Yong Deng <yong.deng@magewell.com>,
	linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH 1/1] v4l: fwnode: v4l2_async_notifier_parse_fwnode_endpoints is deprecated
Date: Fri, 8 Jan 2021 12:09:35 +0200	[thread overview]
Message-ID: <20210108100935.GX11878@paasikivi.fi.intel.com> (raw)
In-Reply-To: <X/gspYsUCNm+wcpS@aptenodytes>

Hi Paul,

On Fri, Jan 08, 2021 at 10:57:57AM +0100, Paul Kocialkowski wrote:
> Hi,
> 
> On Fri 08 Jan 21, 00:07, Sakari Ailus wrote:
> > Hi Ezequiel,
> > 
> > On Thu, Jan 07, 2021 at 04:31:58PM -0300, Ezequiel Garcia wrote:
> > > Hi Sakari,
> > > 
> > > On Mon, 14 Dec 2020 at 18:45, Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
> > > >
> > > > Document that v4l2_async_notifier_parse_fwnode_endpoints() is deprecated.
> > > > Its functionality has been replaced by other, better functions. Also add a
> > > > reference to an example if someone ends up wandering here.
> > > >
> > > 
> > > I'm working on a series to clean up the v4l2_async API a bit,
> > > and came across this patch.
> > > 
> > > As far as I can see, the only user of v4l2_async_notifier_parse_fwnode_endpoints
> > > is drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c.
> > 
> > It may be that's the only one left. The intent was also to avoid anyone
> > proposing new ones.
> > 
> > > Adding Maxime and Yong Deng, it would be great to get rid of this,
> > > so we can remove the API, which would also allow us to remove
> > > some other internal functions and therefore make the API a bit cleaner.
> > 
> > Yes, that'd be very nice. Then we could remove it altogether.
> 
> I've been touching that area a bit with my MIPI CSI-2 support series.
> I'll try to get rid of it along the way if I need to respin the series,
> or come up with a follow-up patch to remove the call to this function.
> 
> If I understand correctly, the preferred way now is to use:
> - fwnode_graph_get_endpoint_by_id
> - v4l2_fwnode_endpoint_parse
> - v4l2_async_notifier_add_fwnode_remote_subdev
> 
> Is that correct? I think that's what I've been doing in the MIPI CSI-2
> bridge drivers so far.

Yes, that's the preferred way.

-- 
Sakari Ailus

  reply	other threads:[~2021-01-08 10:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 21:33 [PATCH 1/1] v4l: fwnode: v4l2_async_notifier_parse_fwnode_endpoints is deprecated Sakari Ailus
2021-01-07 19:31 ` Ezequiel Garcia
2021-01-07 22:07   ` Sakari Ailus
2021-01-08  9:57     ` Paul Kocialkowski
2021-01-08 10:09       ` Sakari Ailus [this message]
2021-01-11  0:59     ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210108100935.GX11878@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=linux-media@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=yong.deng@magewell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.