From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 576D9C433DB for ; Fri, 8 Jan 2021 11:57:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E29492395B for ; Fri, 8 Jan 2021 11:57:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E29492395B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4ym5t1F1RT5hA3FZzLzKATEN6LjjdFWSl6C6mC6hiqE=; b=EpG0bI2PayVwd6lB5pUNubig8 WzsUv3di0oQ872xEYlMQz9z8E98SMixo5hWYJwHSrSWqzJNzz4+kQy16xx9f4+DY/DnKBAIy6S8hx /1IsCbHAKizVq5VPGBUnLdIVkFG6z3THxaisi4n7gqz2MkpF9l1jBCsRSEPAyU6hdCS9UMGzUy0YV 87mqkM+HZ/w7kGt3QhLBbo/WefQ0IbeyANF0bh7H/Qf0vneOJLXpQYcNfGtjnI+CpK6gEsqRO1A/G CI7PZzBMP30uW6k07T/VvZU7IONL29gujpzmWI4zdXqhSwoWyhUWfaDL+qdNL6uhyxdhZvoqoU1Sk uxRaPhKtw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxqLh-0000ek-GM; Fri, 08 Jan 2021 11:54:33 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxqLI-0000YE-Ve for linux-arm-kernel@lists.infradead.org; Fri, 08 Jan 2021 11:54:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kJc3RiI0F+cGpLTf9EiLjO2RjBn7bf4Mjq3GO9JIsAc=; b=R92Ez5RPAUUlk16Tl6QYHO8Ec Hm1ykOpdeCppjKNPJekkv+Y/QDzfeAw3vx9KmGtLObs4+BCzEwgfAMyderacjm2cyuaUgTdAmFjKZ BWO+Z/PLdW0885xIGZKz4L6pn9KVRxwq4Kr2S214ABQHb2rra9aOoQ62V1oakp8X9HEVfAsKdhheN ESHy18ABnBC3/IWn/3Xdj2SdgAKC0FUtKLFPfDdHMzdeYYw2rTmd68DC+HPxbdt6aV1P5UQxsg/YR bKheTYZr73rQvmGJ7DhTaBm/bNvLu45pHXvnXw/6Ksr33pigvgss4nwZSVjtBVnHokX2r7u6ZF3V3 lgYBKlosg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45282) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxqLB-0003v3-74; Fri, 08 Jan 2021 11:54:01 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kxqL7-00027V-41; Fri, 08 Jan 2021 11:53:57 +0000 Date: Fri, 8 Jan 2021 11:53:57 +0000 From: Russell King - ARM Linux admin To: Michael Walle Subject: Re: Broken ethernet on SolidRun cubox-i Message-ID: <20210108115357.GU1551@shell.armlinux.org.uk> References: <2ae000163aa34b963dd387c824bdc3c9@walle.cc> <20201226123421.GD1551@shell.armlinux.org.uk> <1d79aa88e73b6e0118e570a64026817e@walle.cc> <20201227161114.GF1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Uu2n37VG4rOBDVuR" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201227161114.GF1551@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210108_065409_133779_E57717B5 X-CRM114-Status: GOOD ( 25.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matus Ujhelyi , acmattheis@gmx.net, Christoph Mattheis , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --Uu2n37VG4rOBDVuR Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Sun, Dec 27, 2020 at 04:11:14PM +0000, Russell King - ARM Linux admin wrote: > On Sun, Dec 27, 2020 at 04:59:39PM +0100, Michael Walle wrote: > > Am 2020-12-27 16:33, schrieb Michael Walle: > > > Am 2020-12-26 13:34, schrieb Russell King - ARM Linux admin: > > > > I'd forgotten that there were boards out there with this problem... > > > > the PHY address configuration is done via the LED_ACT pin, and > > > > SolidRun > > > > omitted a pull resistor on it, so it "floats" with the leakage current > > > > of the LED/pin - resulting in it sometimes appearing at address 0 and > > > > sometimes at address 4. > > > > > > Mh, I've guessed that too, but there must be more to it. The datasheet > > > says it has an internal weak pull-up. Or Atheros messed up and it > > > doesn't > > > reliably work if there is actually an LED attached to it. But then, why > > > would any other stronger pull-up/down work.. > > > > Mhh, nevermind, from the commit log [1]. > > > > "The LED_ACT pin on the carrier-one boards had a pull down that > > forces the phy address to 0x0; where on CuBox-i and the production > > HummingBoard that pin is connected directly to LED that depending > > on the pull down strength of the LED it might be sampled as '0' or '1' > > thus > > the phy address might appear as either address 0x0 or 0x4." > > > > So it actually depends on the forward voltage of the LED and the > > hi/low thresholds of the AT8035.. nice! Oh and btw. this pin also > > switches between high and low-active LED output. So the missing > > pull-down might not only switch the PHY address to 4 but also invert > > the LED state. > > Indeed. And whether it appears at address 0 or 4 will depend on many > factors, including temperature - LEDs have a decrease of 2mV/°C. > > I wonder if we can just delete the phy-handle property, and list a > PHY at both address 0 and 4 with the appropriate configuration... Michael, can you try the attached patch please? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! --Uu2n37VG4rOBDVuR Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="sr-som.diff" diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi index b06577808ff4..3db08363d3fb 100644 --- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi @@ -53,7 +53,6 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_microsom_enet_ar8035>; - phy-handle = <&phy>; phy-mode = "rgmii-id"; phy-reset-duration = <2>; phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; @@ -63,10 +62,15 @@ #address-cells = <1>; #size-cells = <0>; - phy: ethernet-phy@0 { + ethernet-phy@0 { reg = <0>; qca,clk-out-frequency = <125000000>; }; + + ethernet-phy@4 { + reg = <4>; + qca,clk-out-frequency = <125000000>; + }; }; }; --Uu2n37VG4rOBDVuR Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --Uu2n37VG4rOBDVuR--