All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: Hemant Kumar <hemantk@codeaurora.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] mhi: core: Factorize mhi queuing
Date: Fri, 8 Jan 2021 20:48:45 +0530	[thread overview]
Message-ID: <20210108151845.GB32678@work> (raw)
In-Reply-To: <CAMZdPi-kfYy0x3UL_Hdvj=2t=aqvvxkRrm_BN=K14dF5PzbxyA@mail.gmail.com>

On Fri, Jan 08, 2021 at 04:10:11PM +0100, Loic Poulain wrote:
> Hi Mani,
> 
> On Fri, 8 Jan 2021 at 13:07, Manivannan Sadhasivam <
> manivannan.sadhasivam@linaro.org> wrote:
> 
> > On Thu, Dec 10, 2020 at 12:31:32PM +0100, Loic Poulain wrote:
> > > Instead of duplicating queuing procedure in mhi_queue_dma(),
> > > mhi_queue_buf() and mhi_queue_skb(), add a new generic mhi_queue()
> > > as common helper.
> > >
> >
> > While doing the factoring, please don't make any additional changes. If
> > you want
> > to do, then use incremental patches.
> >
> 
> Well, I've not really performed additional change, I've just aligned all
> mhi_queue*() to use _irq for locking, but that was already the one used in
> mhi_queue_buf(), mhi_queue_dma and mhi_queue_skb now use it as well
> (instead bh), but it's because of the factoring. This has been tested
> carefully.
> 

And you have removed "pre_alloc" check... Either mention all the changes
in the commit message or do it incrementally.

Thanks,
Mani

> Regards,
> Loic

      parent reply	other threads:[~2021-01-08 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 11:31 [PATCH] mhi: core: Factorize mhi queuing Loic Poulain
2021-01-07  2:45 ` Hemant Kumar
2021-01-08 12:07 ` Manivannan Sadhasivam
     [not found]   ` <CAMZdPi-kfYy0x3UL_Hdvj=2t=aqvvxkRrm_BN=K14dF5PzbxyA@mail.gmail.com>
2021-01-08 15:18     ` Manivannan Sadhasivam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210108151845.GB32678@work \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=hemantk@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.