From: Steve Wahl <steve.wahl@hpe.com>
To: Steve Wahl <steve.wahl@hpe.com>,
rja_direct@groups.int.hpe.com,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Cc: "Liang, Kan" <kan.liang@intel.com>
Subject: [PATCH 0/2] perf/x86/intel/uncore: Derive die id from NUMA info with more than 8 nodes
Date: Fri, 8 Jan 2021 09:35:47 -0600 [thread overview]
Message-ID: <20210108153549.108989-1-steve.wahl@hpe.com> (raw)
For Intel uncore, the registers being used to identify the die don't
contain enough bits to uniquely identify more than 8 dies. On
systems with more than 8 dies, this results in error messages of the
form "skx_uncore: probe of XXXX:XX:XX.X failed with error -22", and
some perf counters showing up as "<not supported>".
On such systems, use NUMA information to determine die id.
Continue to use the register information with 8 or fewer numa nodes to
cover cases like NUMA not being enabled.
The first patch moves translation from physical to logical die id
earlier in the code, and stores only the logical id. The logical id
is the only one that is really used. Without this change the second
patch would have to store both physical and logical id, which was much
more complicated.
The second patch adds the alternative of deriving the logical die id
from the NUMA information when there are more than 8 nodes.
Steve Wahl (2):
perf/x86/intel/uncore: Store the logical die id instead of the
physical die id.
perf/x86/intel/uncore: With > 8 nodes, get pci bus die id from NUMA
info
arch/x86/events/intel/uncore.c | 58 +++++---------
arch/x86/events/intel/uncore.h | 5 +-
arch/x86/events/intel/uncore_snb.c | 2 +-
arch/x86/events/intel/uncore_snbep.c | 114 ++++++++++++++++++---------
4 files changed, 99 insertions(+), 80 deletions(-)
--
2.26.2
next reply other threads:[~2021-01-08 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 15:35 Steve Wahl [this message]
2021-01-08 15:35 ` [PATCH 1/2] perf/x86/intel/uncore: Store the logical die id instead of the physical die id Steve Wahl
2021-01-14 11:29 ` [tip: perf/core] " tip-bot2 for Steve Wahl
2021-01-08 15:35 ` [PATCH 2/2] perf/x86/intel/uncore: With > 8 nodes, get pci bus die id from NUMA info Steve Wahl
2021-01-11 13:00 ` Peter Zijlstra
2021-01-11 15:45 ` Steve Wahl
2021-01-12 15:07 ` Peter Zijlstra
2021-01-12 19:42 ` Steve Wahl
2021-01-14 11:29 ` [tip: perf/core] " tip-bot2 for Steve Wahl
2021-01-11 16:39 ` [PATCH 0/2] perf/x86/intel/uncore: Derive die id from NUMA info with more than 8 nodes Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108153549.108989-1-steve.wahl@hpe.com \
--to=steve.wahl@hpe.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rja_direct@groups.int.hpe.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.