All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [linux-stable-rc:linux-5.10.y 642/862] drivers/usb/serial/keyspan_pda.c:550:30: warning: variable 'priv' set but not used
Date: Fri, 08 Jan 2021 22:35:10 +0800	[thread overview]
Message-ID: <202101082251.stzlA1TY-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2910 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
head:   208f314c03c52f01c09eaff3018fd704c2f8fbe2
commit: df2754ae5f0eb7d15d541d837b8e8725d3e56817 [642/862] USB: serial: keyspan_pda: fix write-wakeup use-after-free
config: mips-randconfig-r026-20210108 (attached as .config)
compiler: mips64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=df2754ae5f0eb7d15d541d837b8e8725d3e56817
        git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
        git fetch --no-tags linux-stable-rc linux-5.10.y
        git checkout df2754ae5f0eb7d15d541d837b8e8725d3e56817
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/usb/serial/keyspan_pda.c: In function 'keyspan_pda_write_bulk_callback':
>> drivers/usb/serial/keyspan_pda.c:550:30: warning: variable 'priv' set but not used [-Wunused-but-set-variable]
     550 |  struct keyspan_pda_private *priv;
         |                              ^~~~


vim +/priv +550 drivers/usb/serial/keyspan_pda.c

^1da177e4c3f415 Linus Torvalds 2005-04-16  545  
^1da177e4c3f415 Linus Torvalds 2005-04-16  546  
7d12e780e003f93 David Howells  2006-10-05  547  static void keyspan_pda_write_bulk_callback(struct urb *urb)
^1da177e4c3f415 Linus Torvalds 2005-04-16  548  {
cdc977922891799 Ming Lei       2008-02-24  549  	struct usb_serial_port *port = urb->context;
^1da177e4c3f415 Linus Torvalds 2005-04-16 @550  	struct keyspan_pda_private *priv;
^1da177e4c3f415 Linus Torvalds 2005-04-16  551  
da280e348866004 Johan Hovold   2011-11-06  552  	set_bit(0, &port->write_urbs_free);
^1da177e4c3f415 Linus Torvalds 2005-04-16  553  	priv = usb_get_serial_port_data(port);
^1da177e4c3f415 Linus Torvalds 2005-04-16  554  
^1da177e4c3f415 Linus Torvalds 2005-04-16  555  	/* queue up a wakeup at scheduler time */
df2754ae5f0eb7d Johan Hovold   2020-10-25  556  	usb_serial_port_softint(port);
^1da177e4c3f415 Linus Torvalds 2005-04-16  557  }
^1da177e4c3f415 Linus Torvalds 2005-04-16  558  

:::::: The code at line 550 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 20812 bytes --]

             reply	other threads:[~2021-01-08 14:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 14:35 kernel test robot [this message]
2021-01-08 15:01 ` [linux-stable-rc:linux-5.10.y 642/862] drivers/usb/serial/keyspan_pda.c:550:30: warning: variable 'priv' set but not used Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202101082251.stzlA1TY-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.