Re: [PATCH v1 05/17] media: camss: Refactor VFE HW version support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3491 bytes --]

Hi Robert,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on arm64/for-next/core v5.11-rc2 next-20210108]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Robert-Foss/Add-support-for-SDM845-Camera-Subsystem/20210108-200847
base:   git://linuxtv.org/media_tree.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/22217b7d1cc61585735ff89636574a0d88f609e0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Robert-Foss/Add-support-for-SDM845-Camera-Subsystem/20210108-200847
        git checkout 22217b7d1cc61585735ff89636574a0d88f609e0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/dev_printk.h:14,
                    from include/linux/device.h:15,
                    from drivers/media/platform/qcom/camss/camss.h:13,
                    from drivers/media/platform/qcom/camss/camss-vfe-gen1.c:11:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   drivers/media/platform/qcom/camss/camss-vfe-gen1.c: In function 'vfe_output_update_pong_addr':
>> drivers/media/platform/qcom/camss/camss-vfe-gen1.c:411:6: warning: variable 'addr' set but not used [-Wunused-but-set-variable]
     411 |  u32 addr;
         |      ^~~~


vim +/addr +411 drivers/media/platform/qcom/camss/camss-vfe-gen1.c

   406	
   407	static void vfe_output_update_pong_addr(struct vfe_device *vfe,
   408						struct vfe_output *output, u8 sync,
   409						struct vfe_line *line)
   410	{
 > 411		u32 addr;
   412		unsigned int i;
   413	
   414		for (i = 0; i < output->wm_num; i++) {
   415			if (output->buf[1])
   416				addr = output->buf[1]->addr[i];
   417			else
   418				addr = 0;
   419	
   420			// XXX
   421		}
   422	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 59584 bytes --]