All of lore.kernel.org
 help / color / mirror / Atom feed
* Documentation revision for TCP_USER_TIMEOUT in man7/tcp7
@ 2021-01-09  5:19 Enke Chen
  2021-01-14 12:08 ` Michael Kerrisk (man-pages)
  0 siblings, 1 reply; 4+ messages in thread
From: Enke Chen @ 2021-01-09  5:19 UTC (permalink / raw)
  To: Eric Dumazet; +Cc: linux-man, enkechen2020

diff --git a/man7/tcp.7 b/man7/tcp.7
index 6c91f058b..2ce831c90 100644
--- a/man7/tcp.7
+++ b/man7/tcp.7
@@ -1161,7 +1161,8 @@ This option takes an
 as an argument.
 When the value is greater than 0,
 it specifies the maximum amount of time in milliseconds that transmitted
-data may remain unacknowledged before TCP will forcibly close the
+data may remain unacknowledged, or bufferred data may remain untransmitted
+(due to zero window size) before TCP will forcibly close the
 corresponding connection and return
 .B ETIMEDOUT
 to the application.

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: Documentation revision for TCP_USER_TIMEOUT in man7/tcp7
  2021-01-09  5:19 Documentation revision for TCP_USER_TIMEOUT in man7/tcp7 Enke Chen
@ 2021-01-14 12:08 ` Michael Kerrisk (man-pages)
  2021-01-14 19:27   ` Enke Chen
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Kerrisk (man-pages) @ 2021-01-14 12:08 UTC (permalink / raw)
  To: Enke Chen; +Cc: Eric Dumazet, linux-man

Hello Enke (and Eric),

Thank you for the patch. Is this a change in behavior, or a better
documentation of longstanding behavior?

Eric, do you have an Ack/Review for this patch?

Thanks,

Michael

On Sat, 9 Jan 2021 at 06:21, Enke Chen <enkechen2020@gmail.com> wrote:
>
> diff --git a/man7/tcp.7 b/man7/tcp.7
> index 6c91f058b..2ce831c90 100644
> --- a/man7/tcp.7
> +++ b/man7/tcp.7
> @@ -1161,7 +1161,8 @@ This option takes an
>  as an argument.
>  When the value is greater than 0,
>  it specifies the maximum amount of time in milliseconds that transmitted
> -data may remain unacknowledged before TCP will forcibly close the
> +data may remain unacknowledged, or bufferred data may remain untransmitted
> +(due to zero window size) before TCP will forcibly close the
>  corresponding connection and return
>  .B ETIMEDOUT
>  to the application.



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Documentation revision for TCP_USER_TIMEOUT in man7/tcp7
  2021-01-14 12:08 ` Michael Kerrisk (man-pages)
@ 2021-01-14 19:27   ` Enke Chen
  2021-01-20 11:32     ` Michael Kerrisk (man-pages)
  0 siblings, 1 reply; 4+ messages in thread
From: Enke Chen @ 2021-01-14 19:27 UTC (permalink / raw)
  To: Michael Kerrisk (man-pages); +Cc: Eric Dumazet, linux-man, enkechen2020

Hello Michael:

It is the latter, better documentation of longstanding behavior.

There is a bug, however, that broke the functionality two years ago.
The bug is being fixed.

Thanks.  -- Enke

On Thu, Jan 14, 2021 at 01:08:26PM +0100, Michael Kerrisk (man-pages) wrote:
> Hello Enke (and Eric),
> 
> Thank you for the patch. Is this a change in behavior, or a better
> documentation of longstanding behavior?
> 
> Eric, do you have an Ack/Review for this patch?
> 
> Thanks,
> 
> Michael
> 
> On Sat, 9 Jan 2021 at 06:21, Enke Chen <enkechen2020@gmail.com> wrote:
> >
> > diff --git a/man7/tcp.7 b/man7/tcp.7
> > index 6c91f058b..2ce831c90 100644
> > --- a/man7/tcp.7
> > +++ b/man7/tcp.7
> > @@ -1161,7 +1161,8 @@ This option takes an
> >  as an argument.
> >  When the value is greater than 0,
> >  it specifies the maximum amount of time in milliseconds that transmitted
> > -data may remain unacknowledged before TCP will forcibly close the
> > +data may remain unacknowledged, or bufferred data may remain untransmitted
> > +(due to zero window size) before TCP will forcibly close the
> >  corresponding connection and return
> >  .B ETIMEDOUT
> >  to the application.
> 
> 
> 
> -- 
> Michael Kerrisk
> Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
> Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Documentation revision for TCP_USER_TIMEOUT in man7/tcp7
  2021-01-14 19:27   ` Enke Chen
@ 2021-01-20 11:32     ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Kerrisk (man-pages) @ 2021-01-20 11:32 UTC (permalink / raw)
  To: Enke Chen; +Cc: mtk.manpages, Eric Dumazet, linux-man

On 1/14/21 8:27 PM, Enke Chen wrote:
> Hello Michael:
> 
> It is the latter, better documentation of longstanding behavior.
> 
> There is a bug, however, that broke the functionality two years ago.
> The bug is being fixed.

Thanks for the info, Enke. I've applied the patch.

Cheers,

Michael

> On Thu, Jan 14, 2021 at 01:08:26PM +0100, Michael Kerrisk (man-pages) wrote:
>> Hello Enke (and Eric),
>>
>> Thank you for the patch. Is this a change in behavior, or a better
>> documentation of longstanding behavior?
>>
>> Eric, do you have an Ack/Review for this patch?
>>
>> Thanks,
>>
>> Michael
>>
>> On Sat, 9 Jan 2021 at 06:21, Enke Chen <enkechen2020@gmail.com> wrote:
>>>
>>> diff --git a/man7/tcp.7 b/man7/tcp.7
>>> index 6c91f058b..2ce831c90 100644
>>> --- a/man7/tcp.7
>>> +++ b/man7/tcp.7
>>> @@ -1161,7 +1161,8 @@ This option takes an
>>>  as an argument.
>>>  When the value is greater than 0,
>>>  it specifies the maximum amount of time in milliseconds that transmitted
>>> -data may remain unacknowledged before TCP will forcibly close the
>>> +data may remain unacknowledged, or bufferred data may remain untransmitted
>>> +(due to zero window size) before TCP will forcibly close the
>>>  corresponding connection and return
>>>  .B ETIMEDOUT
>>>  to the application.
>>
>>
>>
>> -- 
>> Michael Kerrisk
>> Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
>> Linux/UNIX System Programming Training: http://man7.org/training/


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-20 12:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-09  5:19 Documentation revision for TCP_USER_TIMEOUT in man7/tcp7 Enke Chen
2021-01-14 12:08 ` Michael Kerrisk (man-pages)
2021-01-14 19:27   ` Enke Chen
2021-01-20 11:32     ` Michael Kerrisk (man-pages)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.