All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chandan Babu R <chandanrlinux@gmail.com>
To: linux-xfs@vger.kernel.org
Cc: Chandan Babu R <chandanrlinux@gmail.com>,
	darrick.wong@oracle.com, djwong@kernel.org, hch@lst.de,
	allison.henderson@oracle.com
Subject: [PATCH V13 13/16] xfs: Remove duplicate assert statement in xfs_bmap_btalloc()
Date: Sun, 10 Jan 2021 08:59:25 +0530	[thread overview]
Message-ID: <20210110032928.3120861-14-chandanrlinux@gmail.com> (raw)
In-Reply-To: <20210110032928.3120861-1-chandanrlinux@gmail.com>

The check for verifying if the allocated extent is from an AG whose
index is greater than or equal to that of tp->t_firstblock is already
done a couple of statements earlier in the same function. Hence this
commit removes the redundant assert statement.

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
---
 fs/xfs/libxfs/xfs_bmap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index 44ed30d0f662..0102aefcf4a6 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -3699,7 +3699,6 @@ xfs_bmap_btalloc(
 		ap->blkno = args.fsbno;
 		if (ap->tp->t_firstblock == NULLFSBLOCK)
 			ap->tp->t_firstblock = args.fsbno;
-		ASSERT(nullfb || fb_agno <= args.agno);
 		ap->length = args.len;
 		/*
 		 * If the extent size hint is active, we tried to round the
-- 
2.29.2


  parent reply	other threads:[~2021-01-10  3:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10  3:29 [PATCH V13 00/16] Bail out if transaction can cause extent count to overflow Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 01/16] xfs: Add helper for checking per-inode extent count overflow Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 02/16] xfs: Check for extent overflow when trivally adding a new extent Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 03/16] xfs: Check for extent overflow when punching a hole Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 04/16] xfs: Check for extent overflow when adding dir entries Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 05/16] xfs: Check for extent overflow when removing " Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 06/16] xfs: Check for extent overflow when renaming " Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 07/16] xfs: Check for extent overflow when adding/removing xattrs Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 08/16] xfs: Check for extent overflow when writing to unwritten extent Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 09/16] xfs: Check for extent overflow when moving extent from cow to data fork Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 10/16] xfs: Check for extent overflow when remapping an extent Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 11/16] xfs: Check for extent overflow when swapping extents Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 12/16] xfs: Introduce error injection to reduce maximum inode fork extent count Chandan Babu R
2021-01-10  3:29 ` Chandan Babu R [this message]
2021-01-10  3:29 ` [PATCH V13 14/16] xfs: Compute bmap extent alignments in a separate function Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 15/16] xfs: Process allocated extent " Chandan Babu R
2021-01-10  3:29 ` [PATCH V13 16/16] xfs: Introduce error injection to allocate only minlen size extents for files Chandan Babu R
2021-01-10  6:46 ` [PATCH V13 00/16] Bail out if transaction can cause extent count to overflow Chandan Babu R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210110032928.3120861-14-chandanrlinux@gmail.com \
    --to=chandanrlinux@gmail.com \
    --cc=allison.henderson@oracle.com \
    --cc=darrick.wong@oracle.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.