* [Buildroot] [PATCH 1/1] fs/cpio: add zstd as compression option
@ 2021-01-10 4:38 José Luis Salvador Rufo
2021-01-10 11:12 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: José Luis Salvador Rufo @ 2021-01-10 4:38 UTC (permalink / raw)
To: buildroot
U-Boot mkimage zstd is available since v2020.10:
https://gitlab.denx.de/u-boot/u-boot/-/commit/26073f9ed3ab0aaf3c2a2b433fecb30a95a067d6
Signed-off-by: Jos? Luis Salvador Rufo <salvador.joseluis@gmail.com>
---
fs/cpio/Config.in | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/cpio/Config.in b/fs/cpio/Config.in
index 83a7fa5824..c1151a2881 100644
--- a/fs/cpio/Config.in
+++ b/fs/cpio/Config.in
@@ -51,6 +51,11 @@ config BR2_TARGET_ROOTFS_CPIO_XZ
help
Do compress the cpio filesystem with xz.
+config BR2_TARGET_ROOTFS_CPIO_ZSTD
+ bool "zstd"
+ help
+ Do compress the cpio filesystem with zstd.
+
endchoice
config BR2_TARGET_ROOTFS_CPIO_UIMAGE
--
2.30.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] fs/cpio: add zstd as compression option
2021-01-10 4:38 [Buildroot] [PATCH 1/1] fs/cpio: add zstd as compression option José Luis Salvador Rufo
@ 2021-01-10 11:12 ` Yann E. MORIN
2021-01-10 19:05 ` [Buildroot] [PATCH v2] " José Luis Salvador Rufo
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2021-01-10 11:12 UTC (permalink / raw)
To: buildroot
Jos?, all,
On 2021-01-10 05:38 +0100, Jos? Luis Salvador Rufo spake thusly:
> U-Boot mkimage zstd is available since v2020.10:
> https://gitlab.denx.de/u-boot/u-boot/-/commit/26073f9ed3ab0aaf3c2a2b433fecb30a95a067d6
>
> Signed-off-by: Jos? Luis Salvador Rufo <salvador.joseluis@gmail.com>
> ---
> fs/cpio/Config.in | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/fs/cpio/Config.in b/fs/cpio/Config.in
> index 83a7fa5824..c1151a2881 100644
> --- a/fs/cpio/Config.in
> +++ b/fs/cpio/Config.in
> @@ -51,6 +51,11 @@ config BR2_TARGET_ROOTFS_CPIO_XZ
> help
> Do compress the cpio filesystem with xz.
>
> +config BR2_TARGET_ROOTFS_CPIO_ZSTD
> + bool "zstd"
> + help
> + Do compress the cpio filesystem with zstd.
How is that expected to work? We do not have zstd support in the fs
infra: https://git.buildroot.org/buildroot/tree/fs/common.mk#n126
Regards,
Yann E. MORIN.
> endchoice
>
> config BR2_TARGET_ROOTFS_CPIO_UIMAGE
> --
> 2.30.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] fs/cpio: add zstd as compression option
2021-01-10 11:12 ` Yann E. MORIN
@ 2021-01-10 19:05 ` José Luis Salvador Rufo
2021-01-16 22:00 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: José Luis Salvador Rufo @ 2021-01-10 19:05 UTC (permalink / raw)
To: buildroot
U-Boot mkimage zstd is available since v2020.10:
https://gitlab.denx.de/u-boot/u-boot/-/commit/26073f9ed3ab0aaf3c2a2b433fecb30a95a067d6
Signed-off-by: Jos? Luis Salvador Rufo <salvador.joseluis@gmail.com>
---
fs/common.mk | 5 +++++
fs/cpio/Config.in | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/fs/common.mk b/fs/common.mk
index 84e13d1b7e..da008ef9e8 100644
--- a/fs/common.mk
+++ b/fs/common.mk
@@ -154,6 +154,11 @@ ifeq ($(BR2_REPRODUCIBLE),)
ROOTFS_$(2)_COMPRESS_CMD += -T $(PARALLEL_JOBS)
endif
endif
+ifeq ($(BR2_TARGET_ROOTFS_$(2)_ZSTD),y)
+ROOTFS_$(2)_DEPENDENCIES += host-zstd
+ROOTFS_$(2)_COMPRESS_EXT = .zst
+ROOTFS_$(2)_COMPRESS_CMD = zstd --ultra -22 -z -f -T$(PARALLEL_JOBS)
+endif
$$(BINARIES_DIR)/$$(ROOTFS_$(2)_FINAL_IMAGE_NAME): ROOTFS=$(2)
$$(BINARIES_DIR)/$$(ROOTFS_$(2)_FINAL_IMAGE_NAME): FAKEROOT_SCRIPT=$$(ROOTFS_$(2)_DIR)/fakeroot
diff --git a/fs/cpio/Config.in b/fs/cpio/Config.in
index 83a7fa5824..c1151a2881 100644
--- a/fs/cpio/Config.in
+++ b/fs/cpio/Config.in
@@ -51,6 +51,11 @@ config BR2_TARGET_ROOTFS_CPIO_XZ
help
Do compress the cpio filesystem with xz.
+config BR2_TARGET_ROOTFS_CPIO_ZSTD
+ bool "zstd"
+ help
+ Do compress the cpio filesystem with zstd.
+
endchoice
config BR2_TARGET_ROOTFS_CPIO_UIMAGE
--
2.30.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] fs/cpio: add zstd as compression option
2021-01-10 19:05 ` [Buildroot] [PATCH v2] " José Luis Salvador Rufo
@ 2021-01-16 22:00 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2021-01-16 22:00 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 10 Jan 2021 20:05:59 +0100
Jos? Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:
> U-Boot mkimage zstd is available since v2020.10:
> https://gitlab.denx.de/u-boot/u-boot/-/commit/26073f9ed3ab0aaf3c2a2b433fecb30a95a067d6
>
> Signed-off-by: Jos? Luis Salvador Rufo <salvador.joseluis@gmail.com>
Thanks, I have applied, with one change, see below.
> ---
> fs/common.mk | 5 +++++
> fs/cpio/Config.in | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/fs/common.mk b/fs/common.mk
> index 84e13d1b7e..da008ef9e8 100644
> --- a/fs/common.mk
> +++ b/fs/common.mk
> @@ -154,6 +154,11 @@ ifeq ($(BR2_REPRODUCIBLE),)
> ROOTFS_$(2)_COMPRESS_CMD += -T $(PARALLEL_JOBS)
> endif
> endif
> +ifeq ($(BR2_TARGET_ROOTFS_$(2)_ZSTD),y)
> +ROOTFS_$(2)_DEPENDENCIES += host-zstd
> +ROOTFS_$(2)_COMPRESS_EXT = .zst
> +ROOTFS_$(2)_COMPRESS_CMD = zstd --ultra -22 -z -f -T$(PARALLEL_JOBS)
To me, it felt a bit extreme to use the --ultra -22 level, which is
documented as requiring a lot of memory, both for compression and
uncompression. So I changed to just -19 instead.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-16 22:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-10 4:38 [Buildroot] [PATCH 1/1] fs/cpio: add zstd as compression option José Luis Salvador Rufo
2021-01-10 11:12 ` Yann E. MORIN
2021-01-10 19:05 ` [Buildroot] [PATCH v2] " José Luis Salvador Rufo
2021-01-16 22:00 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.