From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5724C433E0 for ; Mon, 11 Jan 2021 00:07:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5573B22AAC for ; Mon, 11 Jan 2021 00:07:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5573B22AAC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qcpj7gZ+cj5aDNi/nGkEZsjmeuqQteTegkojjgwyudM=; b=K2I/TqLHYecO66c8GGV68hA7S fKwyr0BEVT24DczX9o9K69ivufQVgATKlTXvR42NuMy2cgkKasfABwT1mWnJuNcRmpfxFXSvb0+Hm Pc17A0YCQc1gfFTvXomrOf0Qw6IU8omELPFmdQ2qIlB0lc6I+u02H2hIhU0jPPle2Ty1EBGlzD8PN ZkxyTRDs6TL/+x7nN9eoLN4csrq2K1IufMm1ysUnopKTXm7rgM7yqP1hLiMveCHpJhMRkbOuI8R41 1G2YFvlnW3otzjQPwbpZnEKl+QAZj2H2rPet367jUhek5zeObpTJYdQIXQAoTIRuPBigqeZ0c6aql 8Q0lM+XgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kykiB-0008Hr-7R; Mon, 11 Jan 2021 00:05:31 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyki7-0008Fu-4Q for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 00:05:29 +0000 Received: by mail-pg1-x52d.google.com with SMTP id i7so11486355pgc.8 for ; Sun, 10 Jan 2021 16:05:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ukbHmrp3rm3Sr5ntr4zS9NosW9h5Tb8iCWMrZatqmd0=; b=hibRqwzWC2H58eOGSmv2BWJUBYvvYs2/eHvMZXKir7iIQghtGwVXIV8nEOSQvr6fI8 1++MCF6eAxAILF9YhACeuVZBeGoUu+pKApnbIxbA2bqvQmKBP8msJJxjJeTOtGDs2r4z wCFndgxVQoX+0XncrcaGBs31nyMj/zdGyHWhZYh3UnzGvaWs3daZifk07WJR3RU1W6Cz u9LSDyJPSWBzUbHyVdQf13uaR8acJJLfUoI9B63TycgiWcgON8mYsBwzkoKShnknRJFA y/VMwBhCFtT6vYpiHX7nwpTNu/FtjqpuuH54giOhmU+8fCRPJZM5tMRT/5ptANB90zvq cNMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ukbHmrp3rm3Sr5ntr4zS9NosW9h5Tb8iCWMrZatqmd0=; b=V4Mvfu2SZLiN8tT44wXA3u95DBWTSKhW2xRS/vrYwbHiV6fPKsmM+C69Zh7ST9EJyw eRs7gN+it2ngKfY4pEyJhRCxhzV1VAxnyNdW6irFrMuYGNMZE3YBC4QvuJnnJXk90puH 17ocqJ/hewALFFBKb/Vo+UQJTLU3OQaABgcnlx59UoiVrrjZC8sQzWJEupmZ98Usxdf/ PArTNBfMoOdRgwpRG45nGRszMqjVAgpZy8KgfuwP4blyYoYb2pg7+3V7/huK7l1ktr67 2tgKerDEECBSpNr/YZ2RT+mVwncgTz/rRyihlJ39UpZuGgPDN2erTkPr2VpiEbljj6mp aWzA== X-Gm-Message-State: AOAM530wg5etpNTUKY5gHA9mwg9dSXgVvkYYFXINALI0GiVWWRGb8wP7 t3PpVBxyOyOmMG2HDDRlqCyslQ== X-Google-Smtp-Source: ABdhPJwjL2XQ7C75TN2n1sS1MZ5S79ITbljF7Uenh/gRF2WGkn73zdV0k8v7jBa5TimtjbnTgCWWnA== X-Received: by 2002:a65:5c48:: with SMTP id v8mr17476220pgr.400.1610323523321; Sun, 10 Jan 2021 16:05:23 -0800 (PST) Received: from leoy-ThinkPad-X240s ([64.120.119.108]) by smtp.gmail.com with ESMTPSA id e10sm17872746pgu.42.2021.01.10.16.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Jan 2021 16:05:22 -0800 (PST) Date: Mon, 11 Jan 2021 08:05:15 +0800 From: Leo Yan To: Suzuki K Poulose Subject: Re: [PATCH] coresight: etm-perf: Add support for PID tracing for kernel at EL2 Message-ID: <20210111000515.GA3241@leoy-ThinkPad-X240s> References: <202101091731.R1nMP6tg-lkp@intel.com> <20210110012430.1874799-1-suzuki.poulose@arm.com> <20210110014133.GA3776@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210110_190527_305123_A8BD04C9 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Al Grant , lkp@intel.com, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, coresight@lists.linaro.org, john.garry@huawei.com, acme@kernel.org, peterz@infradead.org, mingo@redhat.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jan 10, 2021 at 10:34:57PM +0000, Suzuki Kuruppassery Poulose wrote: > On 1/10/21 1:41 AM, Leo Yan wrote: > > Hi Suzuki, > > > > On Sun, Jan 10, 2021 at 01:24:30AM +0000, Suzuki Kuruppassery Poulose wrote: > > > > [...] > > > > > +static ssize_t format_attr_pid_show(struct device *dev, > > > + struct device_attribute *attr, > > > + char *page) > > > +{ > > > + int pid_fmt = ETM_OPT_CTXTID; > > > + > > > +#ifdef CONFIG_CORESIGHT_SOURCE_ETM4X > > > + if (is_kernel_in_hyp_mode()) > > > + pid_fmt = ETM_OPT_CTXTID_IN_VMID; > > > +#endif > > > > I have a different idea for this. As Armv8 Arm describes: "The > > Virtualization Host Extensions only apply to an implementation that > > includes EL2 using AArch64.", seems to me it's more reasable to use > > the condition "#ifdef CONFIG_64BIT", like below: > > > > #ifdef CONFIG_64BIT > > if (is_kernel_in_hyp_mode()) > > pid_fmt = ETM_OPT_CTXTID_IN_VMID; > > #endif > > > > Please let me know if this is better or not. I will resend the patch > > series after agreement. > > I did think of that. But CORESIGHT_SOURCE_ETM4X already depends on CONFIG_ARM64. > So, that is more restrictive in terms of usage. And this wouldn't be the only > build failure if someone tried enable ETM4X for arm32. So I wouldn't worry about > someone trying to use ETM4X on arm32 accidentally. Makes sense, will send v2 with this change. Thanks for confirmation, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel