From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CDFC433DB for ; Mon, 11 Jan 2021 00:26:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39F2022AB0 for ; Mon, 11 Jan 2021 00:26:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727060AbhAKA0R (ORCPT ); Sun, 10 Jan 2021 19:26:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:42448 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726525AbhAKA0R (ORCPT ); Sun, 10 Jan 2021 19:26:17 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0DDA122AAF; Mon, 11 Jan 2021 00:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610324736; bh=YiolvVj0Oj06MeZfYfFnFfa1VQSCBHbzONJiZ8RUYJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eE/WBLA3kC4awatr4XFtpL+PKzGJs9k33Fc8R1LfZdCc4JGYicUXtjR5LQd2U9SEu KujHRJGJ91/ThIcdsQ3xdsstwKnhKJUvzJiKThlKaQGFCBg7wpWO0zY8QDT2KEsQ6R YuQPoUahqOfYqgiRvk032y/9l6I0+lFpcejNDhx9xx1VsdPJ63u+CkhH8cFzmVtCBs hVv4qchh3XJ9HR+Mln7Mm6fm9HrKq4VPh9ogJE1ewK3rF4CGntNdTq2doI/m3GEqS8 iqwa0sUbgSHesHD30UXMDWVoaz4fqjbn6yVaFIPPrdkg6dp1Jx0WgW4kDPle1O1M93 Gjr+NXsQj7u6A== Date: Mon, 11 Jan 2021 08:25:30 +0800 From: Shawn Guo To: Guido =?iso-8859-1?Q?G=FCnther?= Cc: Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Peng Fan , Dong Aisheng , Anson Huang , Krzysztof Kozlowski , Shengjiu Wang , Philipp Zabel , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: imx8mq: Add clock parents for mipi dphy Message-ID: <20210111002530.GQ28365@dragon> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 10, 2021 at 05:55:51PM +0100, Guido Günther wrote: > This makes sure the clock tree setup for the dphy is not dependent on > other components. > > Without this change bringing up the display can fail like > > kernel: phy phy-30a00300.dphy.2: Invalid CM/CN/CO values: 165/217/1 > kernel: phy phy-30a00300.dphy.2: for hs_clk/ref_clk=451656000/593999998 ~ 165/217 > > if LCDIF doesn't set up that part of the clock tree first. This was > noticed when testing the Librem 5 devkit with defconfig. It doesn't > happen when modules are built in. > > Signed-off-by: Guido Günther Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E52EC433DB for ; Mon, 11 Jan 2021 00:27:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38C7122AAF for ; Mon, 11 Jan 2021 00:27:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38C7122AAF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SK7vw3MtLKjq/tWv+BWBEmhi2gdcpy5gATQM6tCWUJE=; b=M9GQlrEgFthgOET1NF9p0xA3M vfD678Ee1RGml/4eCH9zuzeULtRpS9CO5z8SznvpBLHN1PWtRWrdMraiXlnG+qIkEpOonXf+Z5v9z mJySxd+N3oIpZ715RdwyMEe3c6o0hCmtRdlOybYmoLkWMNhlB6ZFaAxKUJH9le+W39oRrQLJmVMFf cvTRC6YvtfgyDqcoc+7gfheG6anSumfjITflrtpgoiYctelgayD8I73XDN9zkrAZ2NK5cDUpWy8Au m8Xzh2Kl4QsAZSlByXo8jEBpwixzvgDTDz0AopvL0QOGPlNmGeZCoeq+tg8c3xEeZAyMwjZK/reJ2 9G2jxaJOg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyl1h-0004Z3-5v; Mon, 11 Jan 2021 00:25:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyl1d-0004Y2-Fc for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 00:25:38 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0DDA122AAF; Mon, 11 Jan 2021 00:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610324736; bh=YiolvVj0Oj06MeZfYfFnFfa1VQSCBHbzONJiZ8RUYJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eE/WBLA3kC4awatr4XFtpL+PKzGJs9k33Fc8R1LfZdCc4JGYicUXtjR5LQd2U9SEu KujHRJGJ91/ThIcdsQ3xdsstwKnhKJUvzJiKThlKaQGFCBg7wpWO0zY8QDT2KEsQ6R YuQPoUahqOfYqgiRvk032y/9l6I0+lFpcejNDhx9xx1VsdPJ63u+CkhH8cFzmVtCBs hVv4qchh3XJ9HR+Mln7Mm6fm9HrKq4VPh9ogJE1ewK3rF4CGntNdTq2doI/m3GEqS8 iqwa0sUbgSHesHD30UXMDWVoaz4fqjbn6yVaFIPPrdkg6dp1Jx0WgW4kDPle1O1M93 Gjr+NXsQj7u6A== Date: Mon, 11 Jan 2021 08:25:30 +0800 From: Shawn Guo To: Guido =?iso-8859-1?Q?G=FCnther?= Subject: Re: [PATCH v2] arm64: dts: imx8mq: Add clock parents for mipi dphy Message-ID: <20210111002530.GQ28365@dragon> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210110_192537_624647_659D5A6B X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , devicetree@vger.kernel.org, Peng Fan , Philipp Zabel , Anson Huang , Sascha Hauer , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Shengjiu Wang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jan 10, 2021 at 05:55:51PM +0100, Guido G=FCnther wrote: > This makes sure the clock tree setup for the dphy is not dependent on > other components. > = > Without this change bringing up the display can fail like > = > kernel: phy phy-30a00300.dphy.2: Invalid CM/CN/CO values: 165/217/1 > kernel: phy phy-30a00300.dphy.2: for hs_clk/ref_clk=3D451656000/5939999= 98 ~ 165/217 > = > if LCDIF doesn't set up that part of the clock tree first. This was > noticed when testing the Librem 5 devkit with defconfig. It doesn't > happen when modules are built in. > = > Signed-off-by: Guido G=FCnther Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel