All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: [igt-dev] [PATCH i-g-t v13 22/31] tests/perf.c: Remove buffer from batch
Date: Mon, 11 Jan 2021 11:25:03 +0100	[thread overview]
Message-ID: <20210111102512.51185-23-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20210111102512.51185-1-zbigniew.kempczynski@intel.com>

Currently we need to ensure intel_buf is a part of single ibb due
to fact it is acquiring address from allocator so we cannot keep
it in two separate ibbs (theoretically it is possible when different
ibbs would be in same context but it is not currently implemented).

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/i915/perf.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/i915/perf.c b/tests/i915/perf.c
index 664fd0a94..e641d5d2d 100644
--- a/tests/i915/perf.c
+++ b/tests/i915/perf.c
@@ -3527,6 +3527,9 @@ gen8_test_single_ctx_render_target_writes_a_counter(void)
 			/* Another redundant flush to clarify batch bo is free to reuse */
 			intel_bb_flush_render(ibb0);
 
+			/* Remove intel_buf from ibb0 added implicitly in rendercopy */
+			intel_bb_remove_intel_buf(ibb0, dst_buf);
+
 			/* submit two copies on the other context to avoid a false
 			 * positive in case the driver somehow ended up filtering for
 			 * context1
@@ -3919,6 +3922,9 @@ static void gen12_single_ctx_helper(void)
 				     BO_REPORT_ID0);
 	intel_bb_flush_render(ibb0);
 
+	/* Remove intel_buf from ibb0 added implicitly in rendercopy */
+	intel_bb_remove_intel_buf(ibb0, dst_buf);
+
 	/* This is the work/context that is measured for counter increments */
 	render_copy(ibb0,
 		    &src[0], 0, 0, width, height,
@@ -3965,6 +3971,9 @@ static void gen12_single_ctx_helper(void)
 				     BO_REPORT_ID3);
 	intel_bb_flush_render(ibb1);
 
+	/* Remove intel_buf from ibb1 added implicitly in rendercopy */
+	intel_bb_remove_intel_buf(ibb1, dst_buf);
+
 	/* Submit an mi-rpc to context0 after all measurable work */
 #define BO_TIMESTAMP_OFFSET1 1032
 #define BO_REPORT_OFFSET1 256
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-01-11 10:26 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 10:24 [igt-dev] [PATCH i-g-t v13 00/31] Introduce IGT allocator Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 01/31] lib/igt_list: igt_hlist implementation Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 02/31] lib/igt_map: Introduce igt_map Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 03/31] lib/igt_core: Track child process pid and tid Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 04/31] lib/intel_allocator_simple: Add simple allocator Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 05/31] lib/intel_allocator_random: Add random allocator Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 06/31] lib/intel_allocator: Add intel_allocator core Zbigniew Kempczyński
2021-01-11 12:06   ` Chris Wilson
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 07/31] lib/intel_allocator: Try to stop smoothly instead of deinit Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 08/31] lib/intel_allocator_msgchannel: Scale to 4k of parallel clients Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 09/31] lib/intel_bufops: Removes handle from allocator, change size Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 10/31] lib/intel_bufops: Add init with handle and size function Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 11/31] lib/intel_batchbuffer: Integrate intel_bb with allocator Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 12/31] lib/intel_batchbuffer: Add tracking intel_buf to intel_bb Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 13/31] lib/intel_aux_pgtable: Get addresses for aux table from an allocator Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 14/31] lib/igt_fb: Initialize intel_buf with same size as fb Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 15/31] tests/api_intel_bb: Modify test to verify intel_bb with allocator Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 16/31] tests/api_intel_bb: Add compressed->compressed copy Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 17/31] tests/api_intel_allocator: Simple allocator test suite Zbigniew Kempczyński
2021-01-11 10:24 ` [igt-dev] [PATCH i-g-t v13 18/31] tests/gem|kms: Remove intel_bb from fixture Zbigniew Kempczyński
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 19/31] tests/gem_mmap_offset: Use intel_buf wrapper code instead direct Zbigniew Kempczyński
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 20/31] tests/gem_ppgtt: Adopt test to use intel_bb with allocator Zbigniew Kempczyński
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 21/31] tests/gem_render_copy_redux: Adopt to use with intel_bb and allocator Zbigniew Kempczyński
2021-01-11 10:25 ` Zbigniew Kempczyński [this message]
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 23/31] tests/gem_linear_blits: Use intel allocator Zbigniew Kempczyński
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 24/31] lib/ioctl_wrappers: Add gem_has_relocations() check Zbigniew Kempczyński
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 25/31] lib/intel_batchbuffer: Use relocations in intel-bb up to gen12 Zbigniew Kempczyński
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 26/31] tests/api_intel_*: Adopt to use relocations as default " Zbigniew Kempczyński
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 27/31] tests/gem_ppgtt: Migrate memory check out of render blits Zbigniew Kempczyński
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 28/31] tests/api_intel_bb: Remove check-canonical test Zbigniew Kempczyński
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 29/31] tests/api_intel_bb: Use allocator in delta-check test Zbigniew Kempczyński
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 30/31] lib/intel_allocator: Separate allocator multiprocess start Zbigniew Kempczyński
2021-01-11 10:25 ` [igt-dev] [PATCH i-g-t v13 31/31] tests/api_intel_allocator: Prepare to run with sanitizer Zbigniew Kempczyński
2021-01-11 11:55 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce IGT allocator (rev14) Patchwork
2021-01-11 13:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-01-11 13:47   ` [igt-dev] =?unknown-8bit?b?4pyT?= " Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111102512.51185-23-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.