Re: [PATCH] seccomp: Add missing return in non-void function

From: Kees Cook <keescook@chromium.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Andy Lutomirski <luto@amacapital.net>,
	Will Drewry <wad@chromium.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] seccomp: Add missing return in non-void function
Date: Mon, 11 Jan 2021 12:04:54 -0800	[thread overview]
Message-ID: <202101111204.971BDEC@keescook> (raw)
In-Reply-To: <20210111172839.640914-1-paul@crapouillou.net>

On Mon, Jan 11, 2021 at 05:28:39PM +0000, Paul Cercueil wrote:
> We don't actually care about the value, since the kernel will panic
> before that; but a value should nonetheless be returned, otherwise the
> compiler will complain.
> 
> Fixes: 8112c4f140fa ("seccomp: remove 2-phase API")
> Cc: stable@vger.kernel.org # 4.7+
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>

Ah, yes, thanks. What was the build config where this actually got
exposed?

> ---
>  kernel/seccomp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/seccomp.c b/kernel/seccomp.c
> index 952dc1c90229..63b40d12896b 100644
> --- a/kernel/seccomp.c
> +++ b/kernel/seccomp.c
> @@ -1284,6 +1284,8 @@ static int __seccomp_filter(int this_syscall, const struct seccomp_data *sd,
>  			    const bool recheck_after_trace)
>  {
>  	BUG();
> +
> +	return -1;
>  }
>  #endif
>  
> -- 
> 2.29.2
> 

-- 
Kees Cook