All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Neeraj Upadhyay <neeraju@codeaurora.org>
Cc: paulmck@kernel.org, josh@joshtriplett.org,
	mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
	joel@joelfernandes.org, rcu@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: Only trace when cbs are accelerated
Date: Mon, 11 Jan 2021 12:34:26 -0500	[thread overview]
Message-ID: <20210111123426.333cd960@gandalf.local.home> (raw)
In-Reply-To: <1610365501-6196-1-git-send-email-neeraju@codeaurora.org>

On Mon, 11 Jan 2021 17:15:01 +0530
Neeraj Upadhyay <neeraju@codeaurora.org> wrote:

> Fix rcu_accelerate_cbs() traces to only trace when cbs are
> accelerated in current call.

The body of the commit should explain "why" not "what". Why not trace the
cbs when not accelerated in the current call?

-- Steve


> 
> Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>

      reply	other threads:[~2021-01-11 17:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 11:45 [PATCH] rcu: Only trace when cbs are accelerated Neeraj Upadhyay
2021-01-11 17:34 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111123426.333cd960@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=neeraju@codeaurora.org \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.