From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC96C433E6 for ; Mon, 11 Jan 2021 13:12:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E535B22AAB for ; Mon, 11 Jan 2021 13:11:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731452AbhAKNLp (ORCPT ); Mon, 11 Jan 2021 08:11:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730764AbhAKNK4 (ORCPT ); Mon, 11 Jan 2021 08:10:56 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5F1FC06179F for ; Mon, 11 Jan 2021 05:10:15 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id u4so8842630pjn.4 for ; Mon, 11 Jan 2021 05:10:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yPCLa6FZjqK4D17lMqre5j2awEs5gnDDXh+r5vWQ68M=; b=XcGOC0tDejK2g+VJ42m5jhAZimTZauS9GkLVMP224pD0LlOJCB7skxgUk1n7Cs9KfK r3PoZGKfKQ04dqejCrtJdgg+xwuhaBgYds1n4Qi2zSmnGYU3rw//grbrkI8/yg2ioUlh MRPoyOiPZwMCPFfymg5WGy5jx1nyLxVcMuG0LiZ34SCRQSc0yaSer1aAcjpnETnFPeUR WnbUZNZ55HeUROOFhc4AZMGGMtJ5x0gnuocyfTDGZxXVeynvxD06I+dBdnWZfchBGmvd B/SZBAY171ygyFZ+A05KvUMpr3i/TwcJG5tarIVdmfhh9ntslkisXv+JmKhTfjpBR4gh MPvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yPCLa6FZjqK4D17lMqre5j2awEs5gnDDXh+r5vWQ68M=; b=sjzXXgRJ9UGvtHC9szmkv3wmPMtzv3zzbWOyhU41Ehutdr5UTyhwhZ/Cnh7e4pl195 tyIrKmPO18UXLiGzPT2kBOVve9nK/OWD9iDuCidvjTRNRTF7Ipl155txsJe47XXO1qNe j46JHcRHGng8mFM9PGS6/F0O6QXEj7Z1TniWCSYmdYG09kmDAsP7iMi6uTrgVr2Ht12/ GjA+SXgBu2RMLemI3jCHFOnKabwk+dackL1k6vO/wegIJbujtSOqf2SbsGtdiM8IN4H6 g1t/J+EjbCCs+3CUpvkrny8mllBhvIqcdu72jbu1bREx5lcI/Znz4UuuQPfLzitSzMiu VRDQ== X-Gm-Message-State: AOAM531KYhuRqnvbD7E5AwJ81DQs9dQPKhg1SQt+35GXMK/SFdye28U1 7phIW3+RIYj1w5uefAdPvQpO2w== X-Google-Smtp-Source: ABdhPJy2XE4QraMGyMvItnMnUYzA9ToHqlvjoaRvAujliJ93tmmsZyrq0XX/dELem2s97VNVM1BO4w== X-Received: by 2002:a17:902:9a97:b029:db:f96a:bb4d with SMTP id w23-20020a1709029a97b02900dbf96abb4dmr19262180plp.27.1610370615250; Mon, 11 Jan 2021 05:10:15 -0800 (PST) Received: from leoy-ThinkPad-X240s ([64.120.119.108]) by smtp.gmail.com with ESMTPSA id s5sm18951963pju.9.2021.01.11.05.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 05:10:14 -0800 (PST) Date: Mon, 11 Jan 2021 21:10:08 +0800 From: Leo Yan To: Suzuki K Poulose Cc: Arnaldo Carvalho de Melo , Mathieu Poirier , Mike Leach , Alexander Shishkin , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , Namhyung Kim , Daniel Kiss , Denis Nikitin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Al Grant Subject: Re: [PATCH v1 7/7] perf cs-etm: Detect pid in VMID for kernel running at EL2 Message-ID: <20210111131008.GA222747@leoy-ThinkPad-X240s> References: <20210109074435.626855-1-leo.yan@linaro.org> <20210109074435.626855-8-leo.yan@linaro.org> <19205bb1-369a-9274-d752-d94f33a909f8@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19205bb1-369a-9274-d752-d94f33a909f8@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 10:07:03AM +0000, Suzuki Kuruppassery Poulose wrote: > Hi Leo > > On 1/9/21 7:44 AM, Leo Yan wrote: > > From: Suzuki K Poulose > > > > The pid of the task could be traced as VMID when the kernel is > > running at EL2. Teach the decoder to look for vmid when the > > context_id is invalid but we have a valid VMID. > > Thank you again for cleaning up this ! Please see one comment > below. Welcome! > > Cc: Mike Leach > > Cc: Mathieu Poirier > > Cc: Al Grant > > Co-developed-by: Leo Yan > > Signed-off-by: Suzuki K Poulose > > Signed-off-by: Leo Yan > > --- > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 32 ++++++++++++++++--- > > 1 file changed, 28 insertions(+), 4 deletions(-) > > > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > index cd007cc9c283..9e81169dfa76 100644 > > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > @@ -6,6 +6,7 @@ > > * Author: Mathieu Poirier > > */ > > +#include > > #include > > #include > > #include > > @@ -500,13 +501,36 @@ cs_etm_decoder__set_tid(struct cs_etm_queue *etmq, > > const ocsd_generic_trace_elem *elem, > > const uint8_t trace_chan_id) > > { > > - pid_t tid; > > + pid_t tid = -1; > > + u64 pid_fmt; > > + int ret; > > - /* Ignore PE_CONTEXT packets that don't have a valid contextID */ > > - if (!elem->context.ctxt_id_valid) > > + ret = cs_etm__get_pid_fmt(trace_chan_id, &pid_fmt); > > + if (ret) > > + return OCSD_RESP_FATAL_SYS_ERR; > > The patch looks fine to me. I am wondering if this can be cached somewhere in > the etmq to avoid doing the search everytime we hit a CID ? Surely for a session, > this woudn't change and thus for the decoder life time. Good suggestion, will refine for this in next version. Thanks, Leo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C278CC4332D for ; Mon, 11 Jan 2021 13:12:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B88F22515 for ; Mon, 11 Jan 2021 13:12:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B88F22515 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w7d5F8QG0u/7S6El9UFParxf37Y4Tlu8TEfGPuwuanA=; b=dlyHYj7VfbVKPkwWUKrS8w+HT fxLasytURNzf5uOIMlKXP8ooMYaqUiVljDOn7CKFfi1JzzICn5nGNRUpR72OZPyXedR7rT3PldvsZ kLvL5t5W/ByWUtmxptr1rdYhVtdnYGZrnaGMh1WoaN8YU/CydA8zC1artAv/1xMIIx4Y0ex1xbDlL +KEdIHsxaEeuAHZOmNAizgpeCl6eOzFGRAx1K46AdGonTaYscNBWa0w2QSZeE+fegfUa48/enMa65 vGcYH0qoWIINwVZth2TJAjlhKSErNzfM4dMBW8ygjHgE/+/hKlNcvi/nmnt/gzCTMg6en0Sw/ZpNK nYtgG2fCA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kywxm-0000JB-Tm; Mon, 11 Jan 2021 13:10:27 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kywxi-0000Fr-VX for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 13:10:25 +0000 Received: by mail-pl1-x631.google.com with SMTP id x18so9491234pln.6 for ; Mon, 11 Jan 2021 05:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yPCLa6FZjqK4D17lMqre5j2awEs5gnDDXh+r5vWQ68M=; b=XcGOC0tDejK2g+VJ42m5jhAZimTZauS9GkLVMP224pD0LlOJCB7skxgUk1n7Cs9KfK r3PoZGKfKQ04dqejCrtJdgg+xwuhaBgYds1n4Qi2zSmnGYU3rw//grbrkI8/yg2ioUlh MRPoyOiPZwMCPFfymg5WGy5jx1nyLxVcMuG0LiZ34SCRQSc0yaSer1aAcjpnETnFPeUR WnbUZNZ55HeUROOFhc4AZMGGMtJ5x0gnuocyfTDGZxXVeynvxD06I+dBdnWZfchBGmvd B/SZBAY171ygyFZ+A05KvUMpr3i/TwcJG5tarIVdmfhh9ntslkisXv+JmKhTfjpBR4gh MPvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yPCLa6FZjqK4D17lMqre5j2awEs5gnDDXh+r5vWQ68M=; b=Vgqmppb3RQEPlqFbnCI/zNKoxLZvzZmixRXRwjKT5FMUp4j1pqtnY6DO2RLSaZ6Eim djB1rTJVmzRkAqyfonutvjq1e49FKXDVSd5RJnRVIJkto3JJc8oeOf1S8yX9r27hcmuA SjBQrzjzwEpEx52eERCnpq4VdA3g/vuaUMSRPOolm5r1+Ct1XIDSHS+k2eT3JFUp7zjX KwEgY7ooODTVVciForKdkd3rxl53a6w1R9ACqmlDP/uM9bDPCj7p3sMwWM5HL1FZ/c0p SlMm8oKFy5xLXsRIOCFnHwl8ZU+mFPsrGoghUzU4Hf2gyt0kcDW1l9D3lqT2u9lO7o4M /duQ== X-Gm-Message-State: AOAM533BqUBpdpqF554qBm4biTCZxynTu8big94Jryrsr49IPuc822RU Rjn1oV5Szx0VA+3GPUpZeKWA2A== X-Google-Smtp-Source: ABdhPJy2XE4QraMGyMvItnMnUYzA9ToHqlvjoaRvAujliJ93tmmsZyrq0XX/dELem2s97VNVM1BO4w== X-Received: by 2002:a17:902:9a97:b029:db:f96a:bb4d with SMTP id w23-20020a1709029a97b02900dbf96abb4dmr19262180plp.27.1610370615250; Mon, 11 Jan 2021 05:10:15 -0800 (PST) Received: from leoy-ThinkPad-X240s ([64.120.119.108]) by smtp.gmail.com with ESMTPSA id s5sm18951963pju.9.2021.01.11.05.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 05:10:14 -0800 (PST) Date: Mon, 11 Jan 2021 21:10:08 +0800 From: Leo Yan To: Suzuki K Poulose Subject: Re: [PATCH v1 7/7] perf cs-etm: Detect pid in VMID for kernel running at EL2 Message-ID: <20210111131008.GA222747@leoy-ThinkPad-X240s> References: <20210109074435.626855-1-leo.yan@linaro.org> <20210109074435.626855-8-leo.yan@linaro.org> <19205bb1-369a-9274-d752-d94f33a909f8@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <19205bb1-369a-9274-d752-d94f33a909f8@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_081023_368019_C84710F7 X-CRM114-Status: GOOD ( 24.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Al Grant , Denis Nikitin , Mathieu Poirier , Alexander Shishkin , Jiri Olsa , coresight@lists.linaro.org, John Garry , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Daniel Kiss , Will Deacon , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 11, 2021 at 10:07:03AM +0000, Suzuki Kuruppassery Poulose wrote: > Hi Leo > > On 1/9/21 7:44 AM, Leo Yan wrote: > > From: Suzuki K Poulose > > > > The pid of the task could be traced as VMID when the kernel is > > running at EL2. Teach the decoder to look for vmid when the > > context_id is invalid but we have a valid VMID. > > Thank you again for cleaning up this ! Please see one comment > below. Welcome! > > Cc: Mike Leach > > Cc: Mathieu Poirier > > Cc: Al Grant > > Co-developed-by: Leo Yan > > Signed-off-by: Suzuki K Poulose > > Signed-off-by: Leo Yan > > --- > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 32 ++++++++++++++++--- > > 1 file changed, 28 insertions(+), 4 deletions(-) > > > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > index cd007cc9c283..9e81169dfa76 100644 > > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > @@ -6,6 +6,7 @@ > > * Author: Mathieu Poirier > > */ > > +#include > > #include > > #include > > #include > > @@ -500,13 +501,36 @@ cs_etm_decoder__set_tid(struct cs_etm_queue *etmq, > > const ocsd_generic_trace_elem *elem, > > const uint8_t trace_chan_id) > > { > > - pid_t tid; > > + pid_t tid = -1; > > + u64 pid_fmt; > > + int ret; > > - /* Ignore PE_CONTEXT packets that don't have a valid contextID */ > > - if (!elem->context.ctxt_id_valid) > > + ret = cs_etm__get_pid_fmt(trace_chan_id, &pid_fmt); > > + if (ret) > > + return OCSD_RESP_FATAL_SYS_ERR; > > The patch looks fine to me. I am wondering if this can be cached somewhere in > the etmq to avoid doing the search everytime we hit a CID ? Surely for a session, > this woudn't change and thus for the decoder life time. Good suggestion, will refine for this in next version. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel