From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCCB4C433E6 for ; Mon, 11 Jan 2021 14:28:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8C65224B1 for ; Mon, 11 Jan 2021 14:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387990AbhAKO2G (ORCPT ); Mon, 11 Jan 2021 09:28:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:40168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731825AbhAKO2F (ORCPT ); Mon, 11 Jan 2021 09:28:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 737C122473; Mon, 11 Jan 2021 14:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610375244; bh=NeQZAI3Se6XnjBLgTKT5kwYcHmcn0zV0JGG0txZc5HA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JER9akiF6aHhzPy1WYWZfp7WhPw4SxmNlvZhH5vN2GhTQ7jRed4db3ImU5rXEjSAi mrtqazmvZoUKQYJ9rFF16yAtoJmcdcjKv94VpMeTNUBixIL/eKT9Q2eYQfNGyCLdWa ThQIRnU9rwrPz5kP9b9pMaJQbvY6mLvtMr7e9jw2w3oqNZ5G//M+zuGWwJ66JMBZds AlIYa//Thf6u+BxkDvys78gi06c3TfomSX5ht7+7Bxzulx9+ZcNGgVGXPb+XP/b7Mk pbB5QdbwqOkAiACEYea5ccWGwDTAu79n8qKVvSdGAWb7rC4ZTAm+3HZSr1gvm7iTpH 47AQpo6KJEprA== Date: Mon, 11 Jan 2021 14:27:19 +0000 From: Will Deacon To: "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , "Kirill A . Shutemov" , Linus Torvalds , Vinayak Menon , Hugh Dickins , kernel-team@android.com Subject: Re: [PATCH v2 1/3] mm: Cleanup faultaround and finish_fault() codepaths Message-ID: <20210111142718.GC7642@willie-the-truck> References: <20210108171517.5290-1-will@kernel.org> <20210108171517.5290-2-will@kernel.org> <20210111142620.ylv3ccrsubef62mi@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210111142620.ylv3ccrsubef62mi@box> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 05:26:20PM +0300, Kirill A. Shutemov wrote: > On Fri, Jan 08, 2021 at 05:15:15PM +0000, Will Deacon wrote: > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index ecdf8a8cd6ae..801dd99f733c 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -542,8 +542,8 @@ struct vm_fault { > > * is not NULL, otherwise pmd. > > */ > > pgtable_t prealloc_pte; /* Pre-allocated pte page table. > > - * vm_ops->map_pages() calls > > - * alloc_set_pte() from atomic context. > > + * vm_ops->map_pages() sets up a page > > + * table from from atomic context. > > * do_fault_around() pre-allocates > > * page table to avoid allocation from > > * atomic context. > > The typo Matthew has pointed out: > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index d3d4e307fa09..358fc8616d8b 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -535,7 +535,7 @@ struct vm_fault { > */ > pgtable_t prealloc_pte; /* Pre-allocated pte page table. > * vm_ops->map_pages() sets up a page > - * table from from atomic context. > + * table from atomic context. > * do_fault_around() pre-allocates > * page table to avoid allocation from > * atomic context. Cheers, fixed locally and will include for v3! Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21F49C433DB for ; Mon, 11 Jan 2021 14:30:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDFE022473 for ; Mon, 11 Jan 2021 14:30:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDFE022473 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZaIIG/RSl4gG6PCzVGA7665HUnQqEk3YrOJRAvjvGw8=; b=si44KnqDicu0fBGb/3Oag968A m+mHPC6DkYthBs51M9A3SyKb83YeYXVhPKdW+42UXKHV4x4AIhzuRNL85Q6NAZ4eqb6smClHM3iNJ UDOt6GjAensia975oCqT9H213ssBahZkp0KrTn1CnOqmAVbopbzLoEhXbsNw6Kc570n3KGAcKGG3K 0tvcN0bCU91x4wUHqTJ71lqy315V0mfIJp7EOEtQRSyMGfMK53bqkxVZq41UATknpyZBNngMLmj2x EBs3G+9KMVcR/0LAMTnIOZx4hYdugAmieWsYScRwuGsGYYAnjcmtA6oYOJEZyEREtBmHnAgvEawzy eYDhdSGpA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyyBU-0005yB-F2; Mon, 11 Jan 2021 14:28:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyyAI-0005Kb-U8 for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 14:27:28 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 737C122473; Mon, 11 Jan 2021 14:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610375244; bh=NeQZAI3Se6XnjBLgTKT5kwYcHmcn0zV0JGG0txZc5HA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JER9akiF6aHhzPy1WYWZfp7WhPw4SxmNlvZhH5vN2GhTQ7jRed4db3ImU5rXEjSAi mrtqazmvZoUKQYJ9rFF16yAtoJmcdcjKv94VpMeTNUBixIL/eKT9Q2eYQfNGyCLdWa ThQIRnU9rwrPz5kP9b9pMaJQbvY6mLvtMr7e9jw2w3oqNZ5G//M+zuGWwJ66JMBZds AlIYa//Thf6u+BxkDvys78gi06c3TfomSX5ht7+7Bxzulx9+ZcNGgVGXPb+XP/b7Mk pbB5QdbwqOkAiACEYea5ccWGwDTAu79n8qKVvSdGAWb7rC4ZTAm+3HZSr1gvm7iTpH 47AQpo6KJEprA== Date: Mon, 11 Jan 2021 14:27:19 +0000 From: Will Deacon To: "Kirill A. Shutemov" Subject: Re: [PATCH v2 1/3] mm: Cleanup faultaround and finish_fault() codepaths Message-ID: <20210111142718.GC7642@willie-the-truck> References: <20210108171517.5290-1-will@kernel.org> <20210108171517.5290-2-will@kernel.org> <20210111142620.ylv3ccrsubef62mi@box> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210111142620.ylv3ccrsubef62mi@box> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_092727_546368_AAD8EB19 X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, Jan Kara , Minchan Kim , Catalin Marinas , Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vinayak Menon , "Kirill A . Shutemov" , Andrew Morton , Linus Torvalds , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 11, 2021 at 05:26:20PM +0300, Kirill A. Shutemov wrote: > On Fri, Jan 08, 2021 at 05:15:15PM +0000, Will Deacon wrote: > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index ecdf8a8cd6ae..801dd99f733c 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -542,8 +542,8 @@ struct vm_fault { > > * is not NULL, otherwise pmd. > > */ > > pgtable_t prealloc_pte; /* Pre-allocated pte page table. > > - * vm_ops->map_pages() calls > > - * alloc_set_pte() from atomic context. > > + * vm_ops->map_pages() sets up a page > > + * table from from atomic context. > > * do_fault_around() pre-allocates > > * page table to avoid allocation from > > * atomic context. > > The typo Matthew has pointed out: > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index d3d4e307fa09..358fc8616d8b 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -535,7 +535,7 @@ struct vm_fault { > */ > pgtable_t prealloc_pte; /* Pre-allocated pte page table. > * vm_ops->map_pages() sets up a page > - * table from from atomic context. > + * table from atomic context. > * do_fault_around() pre-allocates > * page table to avoid allocation from > * atomic context. Cheers, fixed locally and will include for v3! Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel