From: Jan Kara <jack@suse.cz> To: Eric Biggers <ebiggers@kernel.org> Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Theodore Ts'o <tytso@mit.edu>, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH v2 03/12] fs: only specify I_DIRTY_TIME when needed in generic_update_time() Date: Mon, 11 Jan 2021 15:50:29 +0100 [thread overview] Message-ID: <20210111145029.GB18475@quack2.suse.cz> (raw) In-Reply-To: <20210109075903.208222-4-ebiggers@kernel.org> On Fri 08-01-21 23:58:54, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > generic_update_time() always passes I_DIRTY_TIME to > __mark_inode_dirty(), which doesn't really make sense because (a) > generic_update_time() might be asked to do only an i_version update, not > also a timestamps update; and (b) I_DIRTY_TIME is only supposed to be > set in i_state if the filesystem has lazytime enabled, so using it > unconditionally in generic_update_time() is inconsistent. > > As a result there is a weird edge case where if only an i_version update > was requested (not also a timestamps update) but it is no longer needed > (i.e. inode_maybe_inc_iversion() returns false), then I_DIRTY_TIME will > be set in i_state even if the filesystem isn't mounted with lazytime. > > Fix this by only passing I_DIRTY_TIME to __mark_inode_dirty() if the > timestamps were updated and the filesystem has lazytime enabled. > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Eric Biggers <ebiggers@google.com> Looks good to me. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/inode.c | 38 ++++++++++++++++++++------------------ > 1 file changed, 20 insertions(+), 18 deletions(-) > > diff --git a/fs/inode.c b/fs/inode.c > index 6442d97d9a4ab..d0fa43d8e9d5c 100644 > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -1743,24 +1743,26 @@ static int relatime_need_update(struct vfsmount *mnt, struct inode *inode, > > int generic_update_time(struct inode *inode, struct timespec64 *time, int flags) > { > - int iflags = I_DIRTY_TIME; > - bool dirty = false; > - > - if (flags & S_ATIME) > - inode->i_atime = *time; > - if (flags & S_VERSION) > - dirty = inode_maybe_inc_iversion(inode, false); > - if (flags & S_CTIME) > - inode->i_ctime = *time; > - if (flags & S_MTIME) > - inode->i_mtime = *time; > - if ((flags & (S_ATIME | S_CTIME | S_MTIME)) && > - !(inode->i_sb->s_flags & SB_LAZYTIME)) > - dirty = true; > - > - if (dirty) > - iflags |= I_DIRTY_SYNC; > - __mark_inode_dirty(inode, iflags); > + int dirty_flags = 0; > + > + if (flags & (S_ATIME | S_CTIME | S_MTIME)) { > + if (flags & S_ATIME) > + inode->i_atime = *time; > + if (flags & S_CTIME) > + inode->i_ctime = *time; > + if (flags & S_MTIME) > + inode->i_mtime = *time; > + > + if (inode->i_sb->s_flags & SB_LAZYTIME) > + dirty_flags |= I_DIRTY_TIME; > + else > + dirty_flags |= I_DIRTY_SYNC; > + } > + > + if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false)) > + dirty_flags |= I_DIRTY_SYNC; > + > + __mark_inode_dirty(inode, dirty_flags); > return 0; > } > EXPORT_SYMBOL(generic_update_time); > -- > 2.30.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz> To: Eric Biggers <ebiggers@kernel.org> Cc: Theodore Ts'o <tytso@mit.edu>, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Christoph Hellwig <hch@lst.de> Subject: Re: [f2fs-dev] [PATCH v2 03/12] fs: only specify I_DIRTY_TIME when needed in generic_update_time() Date: Mon, 11 Jan 2021 15:50:29 +0100 [thread overview] Message-ID: <20210111145029.GB18475@quack2.suse.cz> (raw) In-Reply-To: <20210109075903.208222-4-ebiggers@kernel.org> On Fri 08-01-21 23:58:54, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > generic_update_time() always passes I_DIRTY_TIME to > __mark_inode_dirty(), which doesn't really make sense because (a) > generic_update_time() might be asked to do only an i_version update, not > also a timestamps update; and (b) I_DIRTY_TIME is only supposed to be > set in i_state if the filesystem has lazytime enabled, so using it > unconditionally in generic_update_time() is inconsistent. > > As a result there is a weird edge case where if only an i_version update > was requested (not also a timestamps update) but it is no longer needed > (i.e. inode_maybe_inc_iversion() returns false), then I_DIRTY_TIME will > be set in i_state even if the filesystem isn't mounted with lazytime. > > Fix this by only passing I_DIRTY_TIME to __mark_inode_dirty() if the > timestamps were updated and the filesystem has lazytime enabled. > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Eric Biggers <ebiggers@google.com> Looks good to me. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/inode.c | 38 ++++++++++++++++++++------------------ > 1 file changed, 20 insertions(+), 18 deletions(-) > > diff --git a/fs/inode.c b/fs/inode.c > index 6442d97d9a4ab..d0fa43d8e9d5c 100644 > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -1743,24 +1743,26 @@ static int relatime_need_update(struct vfsmount *mnt, struct inode *inode, > > int generic_update_time(struct inode *inode, struct timespec64 *time, int flags) > { > - int iflags = I_DIRTY_TIME; > - bool dirty = false; > - > - if (flags & S_ATIME) > - inode->i_atime = *time; > - if (flags & S_VERSION) > - dirty = inode_maybe_inc_iversion(inode, false); > - if (flags & S_CTIME) > - inode->i_ctime = *time; > - if (flags & S_MTIME) > - inode->i_mtime = *time; > - if ((flags & (S_ATIME | S_CTIME | S_MTIME)) && > - !(inode->i_sb->s_flags & SB_LAZYTIME)) > - dirty = true; > - > - if (dirty) > - iflags |= I_DIRTY_SYNC; > - __mark_inode_dirty(inode, iflags); > + int dirty_flags = 0; > + > + if (flags & (S_ATIME | S_CTIME | S_MTIME)) { > + if (flags & S_ATIME) > + inode->i_atime = *time; > + if (flags & S_CTIME) > + inode->i_ctime = *time; > + if (flags & S_MTIME) > + inode->i_mtime = *time; > + > + if (inode->i_sb->s_flags & SB_LAZYTIME) > + dirty_flags |= I_DIRTY_TIME; > + else > + dirty_flags |= I_DIRTY_SYNC; > + } > + > + if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false)) > + dirty_flags |= I_DIRTY_SYNC; > + > + __mark_inode_dirty(inode, dirty_flags); > return 0; > } > EXPORT_SYMBOL(generic_update_time); > -- > 2.30.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-01-11 14:51 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-09 7:58 [PATCH v2 00/12] lazytime fix and cleanups Eric Biggers 2021-01-09 7:58 ` [f2fs-dev] " Eric Biggers 2021-01-09 7:58 ` [PATCH v2 01/12] fs: fix lazytime expiration handling in __writeback_single_inode() Eric Biggers 2021-01-09 7:58 ` [f2fs-dev] " Eric Biggers 2021-01-11 10:48 ` Christoph Hellwig 2021-01-11 10:48 ` [f2fs-dev] " Christoph Hellwig 2021-01-11 14:46 ` Jan Kara 2021-01-11 14:46 ` [f2fs-dev] " Jan Kara 2021-01-09 7:58 ` [PATCH v2 02/12] fs: correctly document the inode dirty flags Eric Biggers 2021-01-09 7:58 ` [f2fs-dev] " Eric Biggers 2021-01-11 14:48 ` Jan Kara 2021-01-11 14:48 ` [f2fs-dev] " Jan Kara 2021-01-09 7:58 ` [PATCH v2 03/12] fs: only specify I_DIRTY_TIME when needed in generic_update_time() Eric Biggers 2021-01-09 7:58 ` [f2fs-dev] " Eric Biggers 2021-01-11 14:50 ` Jan Kara [this message] 2021-01-11 14:50 ` Jan Kara 2021-01-09 7:58 ` [PATCH v2 04/12] fat: only specify I_DIRTY_TIME when needed in fat_update_time() Eric Biggers 2021-01-09 7:58 ` [f2fs-dev] " Eric Biggers 2021-01-11 10:52 ` Christoph Hellwig 2021-01-11 10:52 ` [f2fs-dev] " Christoph Hellwig 2021-01-11 19:50 ` Eric Biggers 2021-01-11 19:50 ` [f2fs-dev] " Eric Biggers 2021-01-12 5:21 ` Dave Chinner 2021-01-12 5:21 ` [f2fs-dev] " Dave Chinner 2021-01-12 13:23 ` Christoph Hellwig 2021-01-12 13:23 ` [f2fs-dev] " Christoph Hellwig 2021-01-11 14:52 ` Jan Kara 2021-01-11 14:52 ` [f2fs-dev] " Jan Kara 2021-01-09 7:58 ` [PATCH v2 05/12] fs: don't call ->dirty_inode for lazytime timestamp updates Eric Biggers 2021-01-09 7:58 ` [f2fs-dev] " Eric Biggers 2021-01-11 14:54 ` Jan Kara 2021-01-11 14:54 ` [f2fs-dev] " Jan Kara 2021-01-09 7:58 ` [PATCH v2 06/12] fs: pass only I_DIRTY_INODE flags to ->dirty_inode Eric Biggers 2021-01-09 7:58 ` [f2fs-dev] " Eric Biggers 2021-01-11 14:56 ` Jan Kara 2021-01-11 14:56 ` [f2fs-dev] " Jan Kara 2021-01-09 7:58 ` [PATCH v2 07/12] fs: clean up __mark_inode_dirty() a bit Eric Biggers 2021-01-09 7:58 ` [f2fs-dev] " Eric Biggers 2021-01-11 14:59 ` Jan Kara 2021-01-11 14:59 ` [f2fs-dev] " Jan Kara 2021-01-09 7:58 ` [PATCH v2 08/12] fs: drop redundant check from __writeback_single_inode() Eric Biggers 2021-01-09 7:58 ` [f2fs-dev] " Eric Biggers 2021-01-11 10:52 ` Christoph Hellwig 2021-01-11 10:52 ` [f2fs-dev] " Christoph Hellwig 2021-01-11 15:00 ` Jan Kara 2021-01-11 15:00 ` [f2fs-dev] " Jan Kara 2021-01-09 7:59 ` [PATCH v2 09/12] fs: improve comments for writeback_single_inode() Eric Biggers 2021-01-09 7:59 ` [f2fs-dev] " Eric Biggers 2021-01-11 10:53 ` Christoph Hellwig 2021-01-11 10:53 ` [f2fs-dev] " Christoph Hellwig 2021-01-11 15:05 ` Jan Kara 2021-01-11 15:05 ` [f2fs-dev] " Jan Kara 2021-01-09 7:59 ` [PATCH v2 10/12] gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync() Eric Biggers 2021-01-09 7:59 ` [f2fs-dev] " Eric Biggers 2021-01-11 15:06 ` Jan Kara 2021-01-11 15:06 ` [f2fs-dev] " Jan Kara 2021-01-09 7:59 ` [PATCH v2 11/12] ext4: simplify i_state checks in __ext4_update_other_inode_time() Eric Biggers 2021-01-09 7:59 ` [f2fs-dev] " Eric Biggers 2021-01-11 10:53 ` Christoph Hellwig 2021-01-11 10:53 ` [f2fs-dev] " Christoph Hellwig 2021-01-11 20:23 ` Eric Biggers 2021-01-11 20:23 ` [f2fs-dev] " Eric Biggers 2021-01-12 13:25 ` Christoph Hellwig 2021-01-12 13:25 ` [f2fs-dev] " Christoph Hellwig 2021-02-03 5:16 ` Theodore Ts'o 2021-02-03 5:16 ` [f2fs-dev] " Theodore Ts'o 2021-01-11 15:11 ` Jan Kara 2021-01-11 15:11 ` [f2fs-dev] " Jan Kara 2021-01-09 7:59 ` [PATCH v2 12/12] xfs: remove a stale comment from xfs_file_aio_write_checks() Eric Biggers 2021-01-09 7:59 ` [f2fs-dev] " Eric Biggers 2021-01-12 17:31 ` Darrick J. Wong 2021-01-12 17:31 ` [f2fs-dev] " Darrick J. Wong 2021-01-11 15:15 ` [PATCH v2 00/12] lazytime fix and cleanups Jan Kara 2021-01-11 15:15 ` [f2fs-dev] " Jan Kara 2021-01-11 20:44 ` Eric Biggers 2021-01-11 20:44 ` [f2fs-dev] " Eric Biggers 2021-02-03 5:11 ` Theodore Ts'o 2021-02-03 5:11 ` [f2fs-dev] " Theodore Ts'o 2021-02-03 5:22 ` Eric Biggers 2021-02-03 5:22 ` [f2fs-dev] " Eric Biggers 2021-02-03 15:49 ` Theodore Ts'o 2021-02-03 15:49 ` [f2fs-dev] " Theodore Ts'o
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210111145029.GB18475@quack2.suse.cz \ --to=jack@suse.cz \ --cc=ebiggers@kernel.org \ --cc=hch@lst.de \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.