All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Atish Patra <atish.patra@wdc.com>
Cc: linux-kernel@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea@microchip.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@microchip.com>
Subject: Re: [PATCH] net: macb: Add default usrio config to default gem config
Date: Mon, 11 Jan 2021 15:13:54 -0800	[thread overview]
Message-ID: <20210111151354.7aec0780@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210111195553.3745008-1-atish.patra@wdc.com>

On Mon, 11 Jan 2021 11:55:53 -0800 Atish Patra wrote:
> There is no usrio config defined for default gem config leading to
> a kernel panic devices that don't define a data. This issue can be
> reprdouced with microchip polar fire soc where compatible string
> is defined as "cdns,macb".
> 
> Fixes: edac63861db7 ("add userio bits as platform configuration")
> 
> Signed-off-by: Atish Patra <atish.patra@wdc.com>

Fixes tag needs work:

Fixes tag: Fixes: edac63861db7 ("add userio bits as platform configuration")
Has these problem(s):
	- empty line after the tag
	- Subject does not match target commit subject
	  Just use
		git log -1 --format='Fixes: %h ("%s")'

Please put [PATCH net] as subject prefix, to indicate this 
is a networking fix.

You can also CC Andrew Lunn like get_maintainer.pl suggests,
but drop linux-kernel from the CC/To.

  reply	other threads:[~2021-01-12  0:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 19:55 [PATCH] net: macb: Add default usrio config to default gem config Atish Patra
2021-01-11 23:13 ` Jakub Kicinski [this message]
2021-01-12  1:48   ` Atish Patra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111151354.7aec0780@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=atish.patra@wdc.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.