From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11541C433E0 for ; Mon, 11 Jan 2021 16:57:49 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 7CF3F2242A for ; Mon, 11 Jan 2021 16:57:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CF3F2242A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70F53140F5A; Mon, 11 Jan 2021 17:57:47 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id E9F55140F58; Mon, 11 Jan 2021 17:57:45 +0100 (CET) IronPort-SDR: jCRNEnAhayIZF/eWIOTPyadhaEEyCu/u/pePx6aqDgSJ63ifnztG4IJwzYCf+vcCjnghWRCjT+ RhMw40LxtLPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="157077557" X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="157077557" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 08:57:43 -0800 IronPort-SDR: ud6CTd3JAx0DiVAouy8f8OMhdy3TZUCQk9OUWBT5+R1+GEFJl2KTcgv/NqRCs+oQYH6E0lrv9M u3WEZCTyJi1w== X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="464219436" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.28.133]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 Jan 2021 08:57:42 -0800 Date: Mon, 11 Jan 2021 16:57:38 +0000 From: Bruce Richardson To: Andrew Boyer Cc: dev , thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, stable@dpdk.org Message-ID: <20210111165738.GA1083@bricha3-MOBL.ger.corp.intel.com> References: <20210111135559.1169775-1-bruce.richardson@intel.com> <0EF8D1A0-3838-442A-A4E9-006258035C34@pensando.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0EF8D1A0-3838-442A-A4E9-006258035C34@pensando.io> Subject: Re: [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jan 11, 2021 at 11:19:26AM -0500, Andrew Boyer wrote: > > > > On Jan 11, 2021, at 8:55 AM, Bruce Richardson > > wrote: > > > > Rather than having the DPDK configuration error out when linking apps > > and examples when "both" is select for "default_library" option, we can > > detect that setting earlier in the build config and provide a suitable > > error message to the user. > > > > CC: stable@dpdk.org > > > > Signed-off-by: Bruce Richardson --- > > config/meson.build | 9 +++++++++ 1 file changed, 9 insertions(+) > > > > diff --git a/config/meson.build b/config/meson.build index > > 3ddcc3539..05e9cede5 100644 --- a/config/meson.build +++ > > b/config/meson.build @@ -308,3 +308,12 @@ if get_option('b_lto') > > add_project_link_arguments('-Wno-lto-type-mismatch', language: 'c') > > endif endif + +if get_option('default_library') == 'both' + error( ''' > > + Unsupported value "both" for "default_library" option. + + > > NOTE: DPDK always builds both shared and static libraries. Please set > > + "default_library" to either "static" or "shared" to select default > > linkage + for apps and any examples''') > > Should there be a period after ‘examples’? > Yes, to have it a valid English sentence. If there are no other comments to fix I'll not do a v2 for it alone, though - committers, feel free to add one on apply. /Bruce