From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F549C433DB for ; Mon, 11 Jan 2021 17:35:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA70522A83 for ; Mon, 11 Jan 2021 17:35:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA70522A83 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E43089CB3; Mon, 11 Jan 2021 17:35:51 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3D7E89CB3 for ; Mon, 11 Jan 2021 17:35:49 +0000 (UTC) IronPort-SDR: +GY3a7Gr4ZAuSOt8T2kiNxSUbzt9UojkzL4gwtpkmsa23rrEri0KQMT0wjPDyop1uVd4OjbHHt RQ2Q+jV6Di4w== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="175325723" X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="175325723" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 09:35:49 -0800 IronPort-SDR: 0HXAZT+Q/0MbEDzcvR/jKGI3sSTMeEl/lYDkhUXJQSA6eyzg96u8hUE/TDMCQ7FIKZqYB6HJJ9 oSHlTN8Ew7SA== X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="363207850" Received: from jaksamit-mobl.amr.corp.intel.com (HELO intel.com) ([10.212.178.167]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 09:35:48 -0800 Date: Mon, 11 Jan 2021 12:35:45 -0500 From: Rodrigo Vivi To: Chris Wilson Message-ID: <20210111173545.GB3689@intel.com> References: <20210110150404.19535-1-chris@chris-wilson.co.uk> <20210110150404.19535-2-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210110150404.19535-2-chris@chris-wilson.co.uk> Subject: Re: [Intel-gfx] [PATCH 02/11] drm/i915/gt: Restore clear-residual mitigations for Ivybridge, Baytrail X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sun, Jan 10, 2021 at 03:03:55PM +0000, Chris Wilson wrote: > The mitigation is required for all gen7 platforms, now that it does not > cause GPU hangs, restore it for Ivybridge and Baytrail. > > Fixes: 47f8253d2b89 ("drm/i915/gen7: Clear all EU/L3 residual contexts") > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Prathap Kumar Valsan > Cc: Akeem G Abodunrin > Cc: Bloomfield Jon > --- > drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > index 1c6d421f6fe5..724d56c9583d 100644 > --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c > +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > @@ -1324,7 +1324,7 @@ int intel_ring_submission_setup(struct intel_engine_cs *engine) > > GEM_BUG_ON(timeline->hwsp_ggtt != engine->status_page.vma); > > - if (IS_HASWELL(engine->i915) && engine->class == RENDER_CLASS) { > + if (IS_GEN(engine->i915, 7) && engine->class == RENDER_CLASS) { when CI is really happy Reviewed-by: Rodrigo Vivi > err = gen7_ctx_switch_bb_init(engine); > if (err) > goto err_ring_unpin; > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx