All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	Brian Foster <bfoster@redhat.com>,
	Eric Sandeen <sandeen@sandeen.net>
Subject: Re: [PATCH v3 3/4] xfs: hoist out xfs_resizefs_init_new_ags()
Date: Tue, 12 Jan 2021 01:47:45 +0800	[thread overview]
Message-ID: <20210111174745.GA1213845@xiangao.remote.csb> (raw)
In-Reply-To: <20210111173249.GC848188@infradead.org>

On Mon, Jan 11, 2021 at 05:32:49PM +0000, Christoph Hellwig wrote:
> > +	xfs_mount_t		*mp,
> 
> Please use the struct type here.

Sigh... sometimes still forget to modify after copy & paste from
somewhere... Will fix tomorrow.

> 
> > +	/*
> > +	 * Write new AG headers to disk. Non-transactional, but need to be
> > +	 * written and completed prior to the growfs transaction being logged.
> > +	 * To do this, we use a delayed write buffer list and wait for
> > +	 * submission and IO completion of the list as a whole. This allows the
> > +	 * IO subsystem to merge all the AG headers in a single AG into a single
> > +	 * IO and hide most of the latency of the IO from us.
> > +	 *
> > +	 * This also means that if we get an error whilst building the buffer
> > +	 * list to write, we can cancel the entire list without having written
> > +	 * anything.
> > +	 */
> 
> Maybe move the comment on top of the whole function, as it really
> explains what the function does.

Ok. Will update tomorrow too.

Thanks,
Gao Xiang

> 


  reply	other threads:[~2021-01-11 17:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 19:09 [PATCH v3 0/4] xfs: support shrinking free space in the last AG Gao Xiang
2021-01-08 19:09 ` [PATCH v3 1/4] xfs: rename `new' to `delta' in xfs_growfs_data_private() Gao Xiang
2021-01-08 21:23   ` Darrick J. Wong
2021-01-08 19:09 ` [PATCH v3 2/4] xfs: get rid of xfs_growfs_{data,log}_t Gao Xiang
2021-01-08 21:21   ` Darrick J. Wong
2021-01-08 21:27     ` Eric Sandeen
2021-01-09  0:49       ` Gao Xiang
2021-01-10 21:04         ` Dave Chinner
2021-01-11  0:17           ` Gao Xiang
2021-01-11 17:30             ` Christoph Hellwig
2021-01-11 18:02               ` Gao Xiang
2021-01-08 19:09 ` [PATCH v3 3/4] xfs: hoist out xfs_resizefs_init_new_ags() Gao Xiang
2021-01-08 21:20   ` Darrick J. Wong
2021-01-11 17:32   ` Christoph Hellwig
2021-01-11 17:47     ` Gao Xiang [this message]
2021-01-08 19:09 ` [PATCH v3 4/4] xfs: support shrinking unused space in the last AG Gao Xiang
2021-01-08 21:19   ` Darrick J. Wong
2021-01-09  0:47     ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111174745.GA1213845@xiangao.remote.csb \
    --to=hsiangkao@redhat.com \
    --cc=bfoster@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.