From: Keith Busch <kbusch@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Michal Krakowiak <michal.krakowiak@intel.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Michal Krakowiak <michal.krakowiak@linux.intel.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: trace: parse format nvm command in detail
Date: Mon, 11 Jan 2021 09:50:18 -0800 [thread overview]
Message-ID: <20210111175018.GD1458209@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <CAPcyv4g3LKRmUOj1QHmkQ5rZ4BfH6TQaK6jKhXfb2DoBW-MoUQ@mail.gmail.com>
On Mon, Jan 11, 2021 at 09:10:34AM -0800, Dan Williams wrote:
> On Mon, Jan 11, 2021 at 9:01 AM Keith Busch <kbusch@kernel.org> wrote:
> >
> > On Fri, Jan 08, 2021 at 04:12:31PM -0800, Dan Williams wrote:
> > > Is there a more centralized place to land such a helper? trace-cmd,
> > > perf? The nice thing about kernel parsing is I don't need to have a
> > > separate pile of disparate tools across subsystems.
> >
> > Yes, I just placed it in a temporary location to see if the other nvme
> > stakeholders are okay with the idea. If so, I can make a real patch
> > series to remove the in-kernel decoding, and add the parsing script
> > somewhere in tools/.
>
> "Somewhere in tools/" is still not quite what I'm asking for, I want
> something nearly as automatic and seamless as the kernel ftrace pipe.
> If I need nvme tools for nvme events and mce tools for mce events etc,
> I'd rather just have decode in the kernel. Perhaps this is a use case
> for a usermode helper that accompanies a new kernel tracing file?. If
> the helper exists the events supported events are decoded if the
> helper is missing the interface is equivalent to the raw formatted
> events. Decoded events "just work".
My only concern is that decoding omits fields, so you have to ugprade
your kernel in order to see the missing ones when the current kernel's
decoding doesn't "just work". If that's how people want to maintain
them, then I won't object any longer.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-11 17:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 15:53 [PATCH] nvme: trace: parse format nvm command in detail Michal Krakowiak
2021-01-04 16:02 ` Keith Busch
2021-01-06 9:00 ` Christoph Hellwig
2021-01-08 22:34 ` Keith Busch
2021-01-09 0:12 ` Dan Williams
2021-01-11 17:01 ` Keith Busch
2021-01-11 17:10 ` Dan Williams
2021-01-11 17:50 ` Keith Busch [this message]
2021-01-11 20:15 ` Michal Krakowiak
2021-01-12 8:33 ` Christoph Hellwig
2021-01-05 19:31 ` Minwoo Im
2021-01-27 17:46 ` Christoph Hellwig
2021-01-28 12:25 ` Michal Krakowiak
2021-01-28 12:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111175018.GD1458209@dhcp-10-100-145-180.wdc.com \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=michal.krakowiak@intel.com \
--cc=michal.krakowiak@linux.intel.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.