From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 754E3C433DB for ; Tue, 12 Jan 2021 00:40:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 458FD224F9 for ; Tue, 12 Jan 2021 00:40:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405183AbhALAZP (ORCPT ); Mon, 11 Jan 2021 19:25:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:38986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404232AbhALAHN (ORCPT ); Mon, 11 Jan 2021 19:07:13 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E6D222D2B; Tue, 12 Jan 2021 00:06:32 +0000 (UTC) Date: Mon, 11 Jan 2021 19:06:31 -0500 From: Steven Rostedt To: Qiujun Huang Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ring-buffer: Remove cpu_buffer argument from the rb_inc_page() Message-ID: <20210111190631.433c3d07@gandalf.local.home> In-Reply-To: <20201225140356.23008-1-hqjagain@gmail.com> References: <20201225140356.23008-1-hqjagain@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Dec 2020 22:03:56 +0800 Qiujun Huang wrote: > The cpu_buffer argument is not used inside the rb_inc_page() after > commit 3adc54fa82a6 ("ring-buffer: make the buffer a true circular link > list"). > And cpu_buffer argument is not used inside the two functions too, > rb_is_head_page/rb_set_list_to_head. > > Signed-off-by: Qiujun Huang > --- Thanks, I added this to my queue. -- Steve