From: Igor Mammedov <imammedo@redhat.com>
To: Marian Posteuca <posteuca@mutex.one>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Sergio Lopez <slp@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Ben Warren <ben@skyportsystems.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Dongjiu Geng <gengdongjiu@huawei.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
Xiang Zheng <zhengxiang9@huawei.com>,
qemu-arm@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>
Subject: Re: [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed
Date: Mon, 11 Jan 2021 20:23:47 +0100 [thread overview]
Message-ID: <20210111202347.41b65fd5@redhat.com> (raw)
In-Reply-To: <87bldvldsl.fsf@mutex.one>
On Mon, 11 Jan 2021 16:59:54 +0200
Marian Posteuca <posteuca@mutex.one> wrote:
> Igor Mammedov <imammedo@redhat.com> writes:
>
> > overall looks good.
> > Please add a test case for it, see
> > tests/qtest/bios-tables-test.c for description how to do it
> > an/or at
> > "[PATCH v3 08/12] tests/acpi: allow updates for expected data files"
> > and follow up patches on the list.
> When you say add a test case, do you mean only updating the binary
> files in tests/data/acpi/{microvm,pc,q35,virt} according to the steps
> at the start of the file bios-tables-test.c? Or do you also mean an actual
> test case to be added in bios-tables-test.c?
an new test in bios-tables-test.c, which will test that new option works as expected.
> Also the step 6 described in bios-tables-test.c mentions that the diff of
> the ACPI table must be added to the commit log, but my change touches
> all the tables for all architectures so that would mean that I would
> have to create a huge commit log. How should I approach this?
I don't think that large commit message is problem, it helps reviewer
to see expected changes (if|before one actually tests)
next prev parent reply other threads:[~2021-01-11 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 22:13 [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed Marian Posteuca
2021-01-06 17:24 ` Igor Mammedov
2021-01-11 14:59 ` Marian Posteuca
2021-01-11 19:23 ` Igor Mammedov [this message]
2021-01-13 14:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111202347.41b65fd5@redhat.com \
--to=imammedo@redhat.com \
--cc=ben@skyportsystems.com \
--cc=ehabkost@redhat.com \
--cc=gengdongjiu@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=posteuca@mutex.one \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shannon.zhaosl@gmail.com \
--cc=slp@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=zhengxiang9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.