From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07D49C433E6 for ; Mon, 11 Jan 2021 21:51:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA25922CB8 for ; Mon, 11 Jan 2021 21:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732176AbhAKVup (ORCPT ); Mon, 11 Jan 2021 16:50:45 -0500 Received: from mail-ot1-f43.google.com ([209.85.210.43]:37508 "EHLO mail-ot1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727380AbhAKVuo (ORCPT ); Mon, 11 Jan 2021 16:50:44 -0500 Received: by mail-ot1-f43.google.com with SMTP id o11so350980ote.4; Mon, 11 Jan 2021 13:50:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qZB7YFnYmK5pmVyjaf+FA297zYveGF4/mkcj6q7QOss=; b=KzzdNZ6Atd3vBpENJVNI0RJlHFY4HrjV+UMAXXdX00Rah+o4Fl1mJCK/L9LhydwEGD UBkdr1YSw5din4zzw9jg3kI+rDjFEZMR1eV/eKMCa9J+bT7fdxH3G1IyqP4ZZH91OjG0 BHQOsgyKaJpl4/BV9D8HDdFc6C6tflQUSNhEzlXKsm0kvIdG/0IdXWk4cQAPmkUbQt8L eAtQ1FV5acmEQGkjaebMlD01hygS9bIlXx0pTbPipZ2k1aJ4irsHg25X0Drp2Rjyr9xJ zlvb8VaqbZH77Au1hgxblZnIYAn8POm9FuNekOSEZV58gqGoP6zDGTk8vj32l8mCR2ZF JXXg== X-Gm-Message-State: AOAM53088rib++/Yfr0VEHejVfTiIWtEYfyhsXKZo1UIk/udhHTNwNhs Kv4w46R3+5BYL3ew65PalQ== X-Google-Smtp-Source: ABdhPJx4sESqsRtj0tIKhFssBKghbCoKpOR5OcYFGX1jMiDvJvhAgfB0xNG4OTZoj71kNHt+15hP5w== X-Received: by 2002:a05:6830:1343:: with SMTP id r3mr753075otq.344.1610401803679; Mon, 11 Jan 2021 13:50:03 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id f18sm214594otf.55.2021.01.11.13.50.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 13:50:02 -0800 (PST) Received: (nullmailer pid 3120427 invoked by uid 1000); Mon, 11 Jan 2021 21:50:01 -0000 Date: Mon, 11 Jan 2021 15:50:01 -0600 From: Rob Herring To: Timon Baetz Cc: Krzysztof Kozlowski , Marek Szyprowski , Liam Girdwood , Mark Brown , MyungJoo Ham , Chanwoo Choi , Lee Jones , Sebastian Reichel , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Message-ID: <20210111215001.GA3111856@robh.at.kernel.org> References: <20201230205139.1812366-1-timon.baetz@protonmail.com> <20201230205139.1812366-2-timon.baetz@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201230205139.1812366-2-timon.baetz@protonmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 30, 2020 at 08:52:07PM +0000, Timon Baetz wrote: > Add maxim,max8997-battery and maxim,max8997-muic optional nodes. > > Signed-off-by: Timon Baetz > Acked-by: Krzysztof Kozlowski > --- > v6: No change. > v5: No change. > v4: Make extcon and charger-supply optional. > v3: Reorder patch, no change. > v2: Add patch. > > .../bindings/regulator/max8997-regulator.txt | 12 ++++++++++++ > 1 file changed, 12 insertions(+) This exceeds my threshold of changes for please convert this to schema first. However, I agree with what Mark has said already, so maybe some of this isn't needed. > > diff --git a/Documentation/devicetree/bindings/regulator/max8997-regulator.txt b/Documentation/devicetree/bindings/regulator/max8997-regulator.txt > index 6fe825b8ac1b..faaf2bbf0272 100644 > --- a/Documentation/devicetree/bindings/regulator/max8997-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/max8997-regulator.txt > @@ -53,6 +53,18 @@ Additional properties required if either of the optional properties are used: > - max8997,pmic-buck125-dvs-gpios: GPIO specifiers for three host gpio's used > for dvs. The format of the gpio specifier depends in the gpio controller. > > +Optional nodes: > +- charger: Node for configuring the charger driver. > + Required properties: > + - compatible: "maxim,max8997-battery" > + Optional properties: > + - extcon: extcon specifier for charging events Don't use 'extcon' for new bindings. Define a connector node. USB I suppose? > + - charger-supply: regulator node for charging current > + > +- muic: Node used only by extcon consumers. > + Required properties: > + - compatible: "maxim,max8997-muic" > + > Regulators: The regulators of max8997 that have to be instantiated should be > included in a sub-node named 'regulators'. Regulator nodes included in this > sub-node should be of the format as listed below. > -- > 2.25.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E79BC433DB for ; Mon, 11 Jan 2021 21:51:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2F0C22CAF for ; Mon, 11 Jan 2021 21:51:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2F0C22CAF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lorR4rj8Z9ypOLomY+1nHQOYPn7R3iaXYLf847RSf70=; b=GLzRHKJgCWLnaOOeGGJj+Sz/u Gnx0bPjqNOmNpKEZt33b6JiinCDIUsH4BA+DAzPBU+6HZttryd0FyHeFDQ7D16mDCLMVLgJq4CCCw fTbyjYZWKc2HwarSFKoW8x/X6Pw6tc+s1yL+lDhFjAHVlYsxB7tL2q6plDo1PjBemGEBqeCA7dgll Bk/5pvZX4XqefJFZei0mEP4C5DGPttSZq4yHpbND28fAN33aLQe7CBIxYrqxohfhGbI/08yW4dXji kG27VnWs1iBx8SSguuExmkWGrXgpQpjmO9Ak3NO37ca9+z/gKDU4fPqAKhsI57JINijI8zeYTEu0Q eP7cJmY7Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz54i-0003BI-Ku; Mon, 11 Jan 2021 21:50:08 +0000 Received: from mail-ot1-f41.google.com ([209.85.210.41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz54e-00039k-Q8 for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 21:50:06 +0000 Received: by mail-ot1-f41.google.com with SMTP id j20so342573otq.5 for ; Mon, 11 Jan 2021 13:50:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qZB7YFnYmK5pmVyjaf+FA297zYveGF4/mkcj6q7QOss=; b=UWH3hZUPppkKSzO53Cyz4xre47+UA38Cnyr/u4luqcBarNWgCYQyGTpdzzdj6gdN/D 1hY0qA3XuGw2XoH8A2qJU74VAnQ32PwU1AwsZeYoU4MLzeTn+0UgTFNUIVo32slwVDQR hjagsGEczkjmljyhDCSuWBCGl0P6uOGDjK9WPDTmcQkFdZxDh+TUpprwvgoBrDf6Rn6f TYd3psh8PeuIc0Oqbgvc4faZ1oEoqfNjTICG5kAkGJ32M1TEmGLGmPLUWDUCgHLSukfJ eBOtnljjcd7jNaO2i+zoSDc44T3zEGu6cIytMQxx1sFZ7MIpt+yyZ2cVWq2xGzo17fOB jApQ== X-Gm-Message-State: AOAM533Vrd6UDLAXEtorFNHXXsVqslI1haPkZi8FDrZoMJxvEvYDI1I8 VPV5yrsqhPi87EaR+FVclw== X-Google-Smtp-Source: ABdhPJx4sESqsRtj0tIKhFssBKghbCoKpOR5OcYFGX1jMiDvJvhAgfB0xNG4OTZoj71kNHt+15hP5w== X-Received: by 2002:a05:6830:1343:: with SMTP id r3mr753075otq.344.1610401803679; Mon, 11 Jan 2021 13:50:03 -0800 (PST) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id f18sm214594otf.55.2021.01.11.13.50.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 13:50:02 -0800 (PST) Received: (nullmailer pid 3120427 invoked by uid 1000); Mon, 11 Jan 2021 21:50:01 -0000 Date: Mon, 11 Jan 2021 15:50:01 -0600 From: Rob Herring To: Timon Baetz Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Message-ID: <20210111215001.GA3111856@robh.at.kernel.org> References: <20201230205139.1812366-1-timon.baetz@protonmail.com> <20201230205139.1812366-2-timon.baetz@protonmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201230205139.1812366-2-timon.baetz@protonmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_165004_895833_BCC366EA X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Liam Girdwood , Krzysztof Kozlowski , Sebastian Reichel , Chanwoo Choi , MyungJoo Ham , ~postmarketos/upstreaming@lists.sr.ht, Lee Jones , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 30, 2020 at 08:52:07PM +0000, Timon Baetz wrote: > Add maxim,max8997-battery and maxim,max8997-muic optional nodes. > > Signed-off-by: Timon Baetz > Acked-by: Krzysztof Kozlowski > --- > v6: No change. > v5: No change. > v4: Make extcon and charger-supply optional. > v3: Reorder patch, no change. > v2: Add patch. > > .../bindings/regulator/max8997-regulator.txt | 12 ++++++++++++ > 1 file changed, 12 insertions(+) This exceeds my threshold of changes for please convert this to schema first. However, I agree with what Mark has said already, so maybe some of this isn't needed. > > diff --git a/Documentation/devicetree/bindings/regulator/max8997-regulator.txt b/Documentation/devicetree/bindings/regulator/max8997-regulator.txt > index 6fe825b8ac1b..faaf2bbf0272 100644 > --- a/Documentation/devicetree/bindings/regulator/max8997-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/max8997-regulator.txt > @@ -53,6 +53,18 @@ Additional properties required if either of the optional properties are used: > - max8997,pmic-buck125-dvs-gpios: GPIO specifiers for three host gpio's used > for dvs. The format of the gpio specifier depends in the gpio controller. > > +Optional nodes: > +- charger: Node for configuring the charger driver. > + Required properties: > + - compatible: "maxim,max8997-battery" > + Optional properties: > + - extcon: extcon specifier for charging events Don't use 'extcon' for new bindings. Define a connector node. USB I suppose? > + - charger-supply: regulator node for charging current > + > +- muic: Node used only by extcon consumers. > + Required properties: > + - compatible: "maxim,max8997-muic" > + > Regulators: The regulators of max8997 that have to be instantiated should be > included in a sub-node named 'regulators'. Regulator nodes included in this > sub-node should be of the format as listed below. > -- > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel